Revision: 13710
          http://edk2.svn.sourceforge.net/edk2/?rev=13710&view=rev
Author:   ydong10
Date:     2012-09-10 03:03:40 +0000 (Mon, 10 Sep 2012)
Log Message:
-----------
When question not have storage with it, not restore old value for it.

Signed-off-by: Eric Dong <[email protected]>
Reviewed-by: Liming Gao <[email protected]>

Modified Paths:
--------------
    trunk/edk2/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c

Modified: trunk/edk2/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c
===================================================================
--- trunk/edk2/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c   2012-09-10 
02:36:17 UTC (rev 13709)
+++ trunk/edk2/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c   2012-09-10 
03:03:40 UTC (rev 13710)
@@ -3655,6 +3655,11 @@
   EFI_STATUS              Status;
 
   //
+  // Extract default from IFR binary for no storage questions.
+  //  
+  ExtractDefault (FormSet, NULL, EFI_HII_DEFAULT_CLASS_STANDARD, FormSetLevel, 
GetDefaultForNoStorage, NULL, TRUE);
+
+  //
   // Request current settings from Configuration Driver
   //
   Link = GetFirstNode (&FormSet->StorageListHead);
@@ -3716,11 +3721,6 @@
   // If has old formset, get the old nv update status.
   //
   if (gOldFormSet != NULL) {
-    //
-    // Restore question value for questions without storage.
-    //
-    CopyOldValueForNoStorageQst (FormSet, gOldFormSet);
-
     Link = GetFirstNode (&FormSet->FormListHead);
     while (!IsNull (&FormSet->FormListHead, Link)) {
       Form = FORM_BROWSER_FORM_FROM_LINK (Link);
@@ -3738,11 +3738,6 @@
       }
       Link = GetNextNode (&FormSet->FormListHead, Link);
     }
-  } else {
-    //
-    // Extract default from IFR binary for no storage questions.
-    //  
-    ExtractDefault (FormSet, NULL, EFI_HII_DEFAULT_CLASS_STANDARD, 
FormSetLevel, GetDefaultForNoStorage, NULL, TRUE);
   }
 
   return EFI_SUCCESS;

This was sent by the SourceForge.net collaborative development platform, the 
world's largest Open Source development site.


------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
edk2-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-commits

Reply via email to