Revision: 15734 http://sourceforge.net/p/edk2/code/15734 Author: li-elvin Date: 2014-08-01 05:08:40 +0000 (Fri, 01 Aug 2014) Log Message: ----------- MdeModulePkg: Fix wrong check for SetAttribute in Consplitter Original code check if Attribute > 0x7FFFFFFF, this is wrong and fail to check valid case per UEFI spec.
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Elvin Li <elvin...@intel.com> Reviewed-by: Jaben Carsey <jaben.car...@intel.com> Modified Paths: -------------- trunk/edk2/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c Modified: trunk/edk2/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c =================================================================== --- trunk/edk2/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c 2014-08-01 04:44:16 UTC (rev 15733) +++ trunk/edk2/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c 2014-08-01 05:08:40 UTC (rev 15734) @@ -16,7 +16,7 @@ never removed. Such design ensures sytem function well during none console device situation. -Copyright (c) 2006 - 2012, Intel Corporation. All rights reserved.<BR> +Copyright (c) 2006 - 2014, Intel Corporation. All rights reserved.<BR> This program and the accompanying materials are licensed and made available under the terms and conditions of the BSD License which accompanies this distribution. The full text of the license may be found at @@ -4557,7 +4557,7 @@ // // Check whether param Attribute is valid. // - if ( (Attribute > (UINTN)(((UINT32)-1)>>1)) ) { + if ((Attribute | 0x7F) != 0x7F) { return EFI_UNSUPPORTED; } This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. ------------------------------------------------------------------------------ Want fast and easy access to all the code in your enterprise? Index and search up to 200,000 lines of code with a free copy of Black Duck Code Sight - the same software that powers the world's largest code search on Ohloh, the Black Duck Open Hub! Try it now. http://p.sf.net/sfu/bds _______________________________________________ edk2-commits mailing list edk2-commits@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-commits