Revision: 19607 http://sourceforge.net/p/edk2/code/19607 Author: shenshushi Date: 2016-01-06 07:40:56 +0000 (Wed, 06 Jan 2016) Log Message: ----------- ShellPkg: Fix Shell assert when mv a file to a NULL target.
When run command 'mv file ' the Shell assert. The patch refined the length of the buffer to fix this bug. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin <shumin....@intel.com> Reviewed-by: Jaben Carsey <jaben.car...@intel.com> Modified Paths: -------------- trunk/edk2/ShellPkg/Library/UefiShellLevel2CommandsLib/Mv.c Modified: trunk/edk2/ShellPkg/Library/UefiShellLevel2CommandsLib/Mv.c =================================================================== --- trunk/edk2/ShellPkg/Library/UefiShellLevel2CommandsLib/Mv.c 2016-01-06 03:25:50 UTC (rev 19606) +++ trunk/edk2/ShellPkg/Library/UefiShellLevel2CommandsLib/Mv.c 2016-01-06 07:40:56 UTC (rev 19607) @@ -2,7 +2,7 @@ Main file for mv shell level 2 function. (C) Copyright 2013-2015 Hewlett-Packard Development Company, L.P.<BR> - Copyright (c) 2009 - 2015, Intel Corporation. All rights reserved.<BR> + Copyright (c) 2009 - 2016, Intel Corporation. All rights reserved.<BR> This program and the accompanying materials are licensed and made available under the terms and conditions of the BSD License which accompanies this distribution. The full text of the license may be found at @@ -731,7 +731,7 @@ // // ValidateAndMoveFiles will report errors to the screen itself // - CwdSize = StrSize(ShellGetCurrentDir(NULL)) + 1; + CwdSize = StrSize(ShellGetCurrentDir(NULL)) + sizeof(CHAR16); Cwd = AllocateZeroPool(CwdSize); ASSERT (Cwd != NULL); StrCpyS(Cwd, CwdSize/sizeof(CHAR16), ShellGetCurrentDir(NULL)); ------------------------------------------------------------------------------ _______________________________________________ edk2-commits mailing list edk2-commits@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-commits