Branch: refs/heads/master
  Home:   https://github.com/tianocore/edk2
  Commit: d508fe87fe73f1e99c5e71ff2aa49459cbe68d2f
      
https://github.com/tianocore/edk2/commit/d508fe87fe73f1e99c5e71ff2aa49459cbe68d2f
  Author: Dandan Bi <[email protected]>
  Date:   2017-04-18 (Tue, 18 Apr 2017)

  Changed paths:
    M MdeModulePkg/Library/BootMaintenanceManagerUiLib/ConsoleOption.c

  Log Message:
  -----------
  MdeModulePkg/BMMUiLib: Update codes of initializing ConsoleXXXCheck array

When initializing ConsoleOutCheck/ConsoleInCheck/ConsoleErrCheck array in
BMM_FAKE_NV_DATA structure, also need to consider whether the terminal
device is ConOut/ConIn/ConErr or not.

Cc: Eric Dong <[email protected]>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi <[email protected]>
Reviewed-by: Eric Dong <[email protected]>


  Commit: f76bc44362e5f0a2ea509c07b2f6846bd9833ee8
      
https://github.com/tianocore/edk2/commit/f76bc44362e5f0a2ea509c07b2f6846bd9833ee8
  Author: Dandan Bi <[email protected]>
  Date:   2017-04-18 (Tue, 18 Apr 2017)

  Changed paths:
    M MdeModulePkg/Universal/HiiDatabaseDxe/Image.c

  Log Message:
  -----------
  MdeModulePkg/HiiDB: Avoid incorrect results of multiplication

An example:
The codes in function Output8bitPixel in Image.c:
OffsetY = BITMAP_LEN_8_BIT ((UINT32) Image->Width, Ypos);

Both Image->Width and Ypos are of type UINT16. They will be promoted to
int (signed) first, and then perform the multiplication defined by macro
BITMAP_LEN_8_BIT. If the result of multiplication between Image->Width and
Ypos exceeds the range of type int, a potential incorrect results
will be assigned to OffsetY.

This commit adds explicit UINT32 type cast for 'Image->Width' to avoid
possible overflow in the int range. And also fix similar issues in
HiiDatabase.

Cc: Eric Dong <[email protected]>
Cc: Liming Gao <[email protected]>
Cc: Hao Wu <[email protected]>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi <[email protected]>
Reviewed-by: Hao Wu <[email protected]>


Compare: https://github.com/tianocore/edk2/compare/51de5c302fed...f76bc44362e5
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
edk2-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-commits

Reply via email to