Branch: refs/heads/master
Home: https://github.com/tianocore/edk2
Commit: 2dbed5250648794bdb6cb0d9111af9924a4e4e00
https://github.com/tianocore/edk2/commit/2dbed5250648794bdb6cb0d9111af9924a4e4e00
Author: Ard Biesheuvel <[email protected]>
Date: 2022-02-25 (Fri, 25 Feb 2022)
Changed paths:
M ArmVirtPkg/Library/ArmVirtMemoryInitPeiLib/ArmVirtMemoryInitPeiLib.c
Log Message:
-----------
ArmVirtPkg/ArmVirtMemoryInitPeiLib: avoid redundant cache invalidation
Alex reports that the cache invalidation performed by
ArmVirtMemoryInitPeiLib takes a non-negligible amount of time at boot.
This cache invalidation used to be necessary to avoid inconsistencies
between the CPU's cached and uncached views of the permanent PEI memory
region, given that the PEI phase is where the MMU gets enabled.
The only allocations done from permanent PEI memory with the MMU off are
pages used for page tables, and since commit 748fea6279ef
("ArmPkg/ArmMmuLib AARCH64: invalidate page tables before populating
them"), each of those is invalidated in the caches explicitly, for
reasons described in the patch's commit log. All other allocations done
in PEI are either from temporary PEI memory, which includes the stack,
or from permanent PEI memory but after the MMU has been enabled.
This means that the cache invalidation in ArmVirtMemoryInitPeiLib is no
longer necessary, and can simply be dropped.
Reported-by: Alexander Graf <[email protected]>
Reviewed-by: Leif Lindholm <[email protected]>
Reviewed-by: Alexander Graf <[email protected]>
Signed-off-by: Ard Biesheuvel <[email protected]>
Commit: 54cddc3ad4b3a317985ce5f491f9b1f31ab10dd8
https://github.com/tianocore/edk2/commit/54cddc3ad4b3a317985ce5f491f9b1f31ab10dd8
Author: Ard Biesheuvel <[email protected]>
Date: 2022-02-25 (Fri, 25 Feb 2022)
Changed paths:
M ArmVirtPkg/ArmVirtKvmTool.dsc
Log Message:
-----------
ArmVirtPkg/ArmVirtKvmTool: wire up configurable timeout
Use the correct PCD type for PcdPlatformBootTimeOut so it gets wired up
to the Timeout EFI variable automatically, which is how the boot manager
stores the timeout preference.
Note that this changes the default to 5 seconds, which appears to be
common across platforms.
Signed-off-by: Ard Biesheuvel <[email protected]>
Reviewed-by: Pierre Gondois <[email protected]>
Reviewed-by: Sami Mujawar <[email protected]>
Compare: https://github.com/tianocore/edk2/compare/b24306f15daa...54cddc3ad4b3
_______________________________________________
edk2-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-commits
