Branch: refs/heads/master
Home: https://github.com/tianocore/edk2
Commit: f16b05a13bb3a4c685c4c6161c1367e43fcd61f7
https://github.com/tianocore/edk2/commit/f16b05a13bb3a4c685c4c6161c1367e43fcd61f7
Author: Michael Kubacki <[email protected]>
Date: 2022-04-04 (Mon, 04 Apr 2022)
Changed paths:
M .pytool/Plugin/UncrustifyCheck/UncrustifyCheck.py
Log Message:
-----------
.pytool/Plugin/UncrustifyCheck: Update func to return absolute paths
Currently, UncrustifyCheck._get_git_ignored_paths() is documented to
return a list of absolute file paths but it currently returns a list
of relative file paths.
This change updates the function to return a list of absolute file
paths. The result is later compared to the list of absolute file
paths for files to run against Uncrustify.
Cc: Michael D Kinney <[email protected]>
Cc: Liming Gao <[email protected]>
Cc: Sean Brogan <[email protected]>
Cc: Bret Barkelew <[email protected]>
Signed-off-by: Michael Kubacki <[email protected]>
Reviewed-by: Michael D Kinney <[email protected]>
Reviewed-by: Jiewen Yao <[email protected]>
Commit: dbfbaedb21c94ef8344086ba6532e964e40f5526
https://github.com/tianocore/edk2/commit/dbfbaedb21c94ef8344086ba6532e964e40f5526
Author: Michael Kubacki <[email protected]>
Date: 2022-04-04 (Mon, 04 Apr 2022)
Changed paths:
M .pytool/Plugin/UncrustifyCheck/Readme.md
M .pytool/Plugin/UncrustifyCheck/UncrustifyCheck.py
Log Message:
-----------
.pytool/Plugin/UncrustifyCheck: Add ignore file support
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3880
Currently UncrustifyCheck.py provides the following exclusion
options:
1. Override the type of files UncrustifyCheck operates against by
default (.c and .h files). Using the "IgnoreStandardPaths"
configuration option.
2. By default, UncrustifyCheck skips files in git submodules and
ignored by git (the "SkipGitExclusions" configuration option can
override this behavior).
The goal of UncrustifyCheck is to provide consistent formatting
across the codebase. In some rare circumstances, maintainers might
need to exclude a specific file (or file pattern) within their
package. For example, a small set of auto-generated files from
another repository.
This change adds a new configuration option that can be specified
in a package CI YAML file to describe a list of files within the
package that should be ignored by UncrustifyCheck.
The configuration option is called "IgnoreFiles" and it uses similar
syntax to git ignore to ignore a list of files.
Cc: Michael D Kinney <[email protected]>
Cc: Liming Gao <[email protected]>
Cc: Sean Brogan <[email protected]>
Cc: Bret Barkelew <[email protected]>
Signed-off-by: Michael Kubacki <[email protected]>
Reviewed-by: Jiewen Yao <[email protected]>
Reviewed-by: Sean Brogan <[email protected]>
Reviewed-by: Michael D Kinney <[email protected]>
Commit: d932199d39a5e8e47e2d431e897a765b70ceb51e
https://github.com/tianocore/edk2/commit/d932199d39a5e8e47e2d431e897a765b70ceb51e
Author: Michael Kubacki <[email protected]>
Date: 2022-04-04 (Mon, 04 Apr 2022)
Changed paths:
M OvmfPkg/Bhyve/BhyveRfbDxe/VbeShim.h
M OvmfPkg/QemuVideoDxe/VbeShim.h
Log Message:
-----------
OvmfPkg: Revert Uncrustify formatting in VbeShim.h files
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3875
Reverts changes automatically applied by Uncrustify in commit
ac0a286.
Cc: Ard Biesheuvel <[email protected]>
Cc: Jiewen Yao <[email protected]>
Cc: Jordan Justen <[email protected]>
Cc: Gerd Hoffmann <[email protected]>
Cc: Rebecca Cran <[email protected]>
Cc: Peter Grehan <[email protected]>
Cc: Laszlo Ersek <[email protected]>
Signed-off-by: Michael Kubacki <[email protected]>
Acked-by: Gerd Hoffmann <[email protected]>
Acked-by: Laszlo Ersek <[email protected]>
Reviewed-by: Jiewen Yao <[email protected]>
Reviewed-by: Michael D Kinney <[email protected]>
Commit: ad6816c319cdbd927d81e071996a0dea33c86e4a
https://github.com/tianocore/edk2/commit/ad6816c319cdbd927d81e071996a0dea33c86e4a
Author: Michael Kubacki <[email protected]>
Date: 2022-04-04 (Mon, 04 Apr 2022)
Changed paths:
M OvmfPkg/OvmfPkg.ci.yaml
Log Message:
-----------
OvmfPkg: Do not check VbeShim.h formatting with Uncrustify
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3875
The following files:
OvmfPkg/Bhyve/BhyveRfbDxe/VbeShim.h
OvmfPkg/QemuVideoDxe/VbeShim.h
Are auto generated by the following generators:
OvmfPkg/Bhyve/BhyveRfbDxe/VbeShim.sh
OvmfPkg/QemuVideoDxe/VbeShim.sh
Therefore, Uncrustify causes a file update to produce a very large
diff due to formatting changes.
This change does the following:
1. Reverts the Uncrustify changes applied to the files in commit
ac0a286f4d74.
2. Uses a new UncrustifyCheck CI plugin configuration option to
exclude the files from future formatting checks.
Cc: Ard Biesheuvel <[email protected]>
Cc: Jiewen Yao <[email protected]>
Cc: Jordan Justen <[email protected]>
Cc: Gerd Hoffmann <[email protected]>
Cc: Rebecca Cran <[email protected]>
Cc: Peter Grehan <[email protected]>
Cc: Laszlo Ersek <[email protected]>
Signed-off-by: Michael Kubacki <[email protected]>
Acked-by: Gerd Hoffmann <[email protected]>
Acked-by: Laszlo Ersek <[email protected]>
Reviewed-by: Jiewen Yao <[email protected]>
Reviewed-by: Michael D Kinney <[email protected]>
Compare: https://github.com/tianocore/edk2/compare/3e130e40fc55...ad6816c319cd
_______________________________________________
edk2-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-commits
