Branch: refs/heads/master
Home: https://github.com/tianocore/edk2
Commit: 392456240aa74966ee857ae1e5628943ee8c1b88
https://github.com/tianocore/edk2/commit/392456240aa74966ee857ae1e5628943ee8c1b88
Author: Zhiguang Liu <[email protected]>
Date: 2023-09-18 (Mon, 18 Sep 2023)
Changed paths:
M BaseTools/Source/C/GenFv/GenFvInternalLib.c
Log Message:
-----------
BaseTools: Remove logic to create AP waking vector in GenFv
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4494
Today for SEC core(not VTF-0), GenFv finds free 4K aligned space in
FV for AP waking vector and JMP to 4G-30h in the waking vector.
There is no usage of this today. Remove the logic to avoid confusing
and save spaces in reset vector.
Cc: Rebecca Cran <[email protected]>
Cc: Liming Gao <[email protected]>
Cc: Bob Feng <[email protected]>
Cc: Yuwei Chen <[email protected]>
Reviewed-by: Ray Ni <[email protected]>
Reviewed-by: Liming Gao <[email protected]>
Signed-off-by: Zhiguang Liu <[email protected]>
Commit: 718cf21a5a1dab6184cd83d2323236ae69e178e8
https://github.com/tianocore/edk2/commit/718cf21a5a1dab6184cd83d2323236ae69e178e8
Author: Zhiguang Liu <[email protected]>
Date: 2023-09-18 (Mon, 18 Sep 2023)
Changed paths:
M UefiCpuPkg/SecCore/Ia32/ResetVec.nasmb
Log Message:
-----------
UefiCpuPkg/SecCore: Remove AP waking Vector logic in SecCore
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4494
There are two part of AP waking Vector logic in SecCore.
The first one working with GenFv to find a free 4K aligned space,
use the 4K aligned address as AP waking Vector and jump to 4G-30h,
and finally jump to ApStartup..
The second one hard code uses 4G-1000h as AP waking Vector and
jump to ApStartup.
Both usages are no longer used. Remove them.
Cc: Eric Dong <[email protected]>
Cc: Ray Ni <[email protected]>
Cc: Rahul Kumar <[email protected]>
Cc: Gerd Hoffmann <[email protected]>
Reviewed-by: Ray Ni <[email protected]>
Signed-off-by: Zhiguang Liu <[email protected]>
Commit: dea6002d6e612ee3066fc755b5ad47558d84d645
https://github.com/tianocore/edk2/commit/dea6002d6e612ee3066fc755b5ad47558d84d645
Author: Zhiguang Liu <[email protected]>
Date: 2023-09-18 (Mon, 18 Sep 2023)
Changed paths:
M OvmfPkg/ResetVector/Ia16/ResetVectorVtf0.asm
M OvmfPkg/XenResetVector/Ia16/ResetVectorVtf0.asm
Log Message:
-----------
OvmfPkg: Remove applicationProcessorEntryPoint
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4494
Current reset vector uses 0xffffffe0 as AP waking vector, and expects
GenFv generates code aligned on a 4k boundary which will jump to this
location. However, some issues are listed below
1. GenFV doesn't generate code as the comment expects, because GenFv
assumes no modifications are required to the VTF-0 'Volume Top File'.
2. Even if removing VFT0 signature and let GenFv to modify, Genfv is
hard-code using another flash address 0xffffffd0.
3. In the same patch series, AP waking vector code is removed from
GenFv, because no such usage anymore. The existing of first two issues
also approve the usage is not available for a long time.
Therefore, remove AP waking vector related code.
Cc: Ard Biesheuvel <[email protected]>
Cc: Jiewen Yao <[email protected]>
Cc: Jordan Justen <[email protected]>
Cc: Gerd Hoffmann <[email protected]>
Cc: Anthony Perard <[email protected]>
Cc: Julien Grall <[email protected]>
Reviewed-by: Ray Ni <[email protected]>
Acked-by: Anthony PERARD <[email protected]>
Signed-off-by: Zhiguang Liu <[email protected]>
Commit: db38c7de64d4dda2bf3cc6e5d764b027b00afa59
https://github.com/tianocore/edk2/commit/db38c7de64d4dda2bf3cc6e5d764b027b00afa59
Author: Zhiguang Liu <[email protected]>
Date: 2023-09-18 (Mon, 18 Sep 2023)
Changed paths:
M UefiCpuPkg/ResetVector/Vtf0/Ia16/Init16.asm
M UefiCpuPkg/ResetVector/Vtf0/Ia16/ResetVectorVtf0.asm
Log Message:
-----------
UefiCpuPkg/ResetVector: Remove AP waking vector from ResetVector
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4494
Current reset vector uses 0xffffffe0 as AP waking vector, and expects
GenFv generates code aligned on a 4k boundary which will jump to this
location. However, some issues are listed below
1. GenFV doesn't generate code as the comment expects, because GenFv
assumes no modifications are required to the VTF-0 'Volume Top File'.
2. Even if removing VFT0 signature and let GenFv to modify, Genfv is
hard-code using another flash address 0xffffffd0.
3. In the same patch series, AP waking vector code is removed from
GenFv, because no such usage anymore. The existing of first two issues
also approve the usage is not available for a long time.
Therefore, remove AP waking vector related code.
Cc: Eric Dong <[email protected]>
Cc: Ray Ni <[email protected]>
Cc: Rahul Kumar <[email protected]>
Cc: Gerd Hoffmann <[email protected]>
Reviewed-by: Ray Ni <[email protected]>
Signed-off-by: Zhiguang Liu <[email protected]>
Compare: https://github.com/tianocore/edk2/compare/29cce3356aec...db38c7de64d4
_______________________________________________
edk2-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-commits
