Branch: refs/heads/master
Home: https://github.com/tianocore/edk2
Commit: cbf0e4f5b370a874ace11a0b20533e891dbc25ab
https://github.com/tianocore/edk2/commit/cbf0e4f5b370a874ace11a0b20533e891dbc25ab
Author: Leif Lindholm <[email protected]>
Date: 2023-10-02 (Mon, 02 Oct 2023)
Changed paths:
M MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.S
M MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.asm
M MdePkg/Library/BaseLib/Arm/SetJumpLongJump.S
M MdePkg/Library/BaseLib/Arm/SetJumpLongJump.asm
Log Message:
-----------
MdePkg/BaseLib: fix comments in ARM* SetJump/LongJump implementations
Drop redundant comment about IPF (clearly copied across from now deleted
code).
Also change
"Instead is resumes execution" ->
"Instead it resumes execution"
Signed-off-by: Leif Lindholm <[email protected]>
Cc: Ard Biesheuvel <[email protected]>
Cc: Sami Mujawar <[email protected]>
Reviewed-by: Sami Mujawar <[email protected]>
Commit: 80bbea192aa44ab664ba8be29ac06c83f246e99c
https://github.com/tianocore/edk2/commit/80bbea192aa44ab664ba8be29ac06c83f246e99c
Author: Leif Lindholm <[email protected]>
Date: 2023-10-02 (Mon, 02 Oct 2023)
Changed paths:
M MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.S
M MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.asm
Log Message:
-----------
MdePkg/BaseLib: add ASSERT in ARM* SetJump implementations
The SetJump comment header states that:
If JumpBuffer is NULL, then ASSERT().
However, this was not currently done.
Add a call to InternalAssertJumpBuffer.
Signed-off-by: Leif Lindholm <[email protected]>
Cc: Ard Biesheuvel <[email protected]>
Cc: Sami Mujawar <[email protected]>
Reviewed-by: Sami Mujawar <[email protected]>
Commit: ae79efb7bd436068156605ae7111b93dab710546
https://github.com/tianocore/edk2/commit/ae79efb7bd436068156605ae7111b93dab710546
Author: Leif Lindholm <[email protected]>
Date: 2023-10-02 (Mon, 02 Oct 2023)
Changed paths:
M MdePkg/Library/BaseLib/Arm/SetJumpLongJump.S
M MdePkg/Library/BaseLib/Arm/SetJumpLongJump.asm
Log Message:
-----------
MdePkg/BaseLib: use normal register init in ARM SetJump implementations
There may be architectures on which there are benefits to
eor r0, r0(, r0)
but ARM was never one of them. Change to more readable
mov r0, #0
instead.
Signed-off-by: Leif Lindholm <[email protected]>
Cc: Ard Biesheuvel <[email protected]>
Cc: Sami Mujawar <[email protected]>
Reviewed-by: Sami Mujawar <[email protected]>
Commit: 2b2705343a810538bc27f5e897da693984c82394
https://github.com/tianocore/edk2/commit/2b2705343a810538bc27f5e897da693984c82394
Author: Leif Lindholm <[email protected]>
Date: 2023-10-02 (Mon, 02 Oct 2023)
Changed paths:
M MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.S
M MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.asm
Log Message:
-----------
MdePkg/BaseLib: correct register sizes in AArch64 SetJump/LongJump
Both in SetJump and in InternalLongJump, 32-bit w register views were
used for the UINTN return value. In SetJump, this did not cause errors;
it was only counterintuitive. But in InternalLongJump, it meant the top
32 bits of Value were stripped off.
Change all of these to use the 64-bit x register views.
Signed-off-by: Leif Lindholm <[email protected]>
Reanimated-by: Andrei Warkentin <[email protected]>
Cc: Ard Biesheuvel <[email protected]>
Cc: Sami Mujawar <[email protected]>
Reviewed-by: Sami Mujawar <[email protected]>
Reviewed-by: Andrei Warkentin <[email protected]>
Commit: 1a66bd51ca21f341281d8e3157d3d3f4a94fd26c
https://github.com/tianocore/edk2/commit/1a66bd51ca21f341281d8e3157d3d3f4a94fd26c
Author: Leif Lindholm <[email protected]>
Date: 2023-10-02 (Mon, 02 Oct 2023)
Changed paths:
M MdePkg/Library/BaseLib/Arm/SetJumpLongJump.S
M MdePkg/Library/BaseLib/Arm/SetJumpLongJump.asm
Log Message:
-----------
MdePkg/BaseLib: ensure ARM LongJump never returns 0
The ARM implementation of InternalLongJump always returned the value
Value - but it is not supposed to ever return 0. Add the test to prevent
that, and return 1 if Value is 0 - as is already present in AArch64.
Signed-off-by: Leif Lindholm <[email protected]>
Cc: Ard Biesheuvel <[email protected]>
Cc: Sami Mujawar <[email protected]>
Reviewed-by: Sami Mujawar <[email protected]>
Compare: https://github.com/tianocore/edk2/compare/f6a314e5b5dc...1a66bd51ca21
_______________________________________________
edk2-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-commits
