Branch: refs/heads/master
Home: https://github.com/tianocore/edk2
Commit: c62fb455491bc029ca225e61702a7259c4ec324a
https://github.com/tianocore/edk2/commit/c62fb455491bc029ca225e61702a7259c4ec324a
Author: Laszlo Ersek <[email protected]>
Date: 2023-10-18 (Wed, 18 Oct 2023)
Changed paths:
M PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe/PcRtcEntry.c
Log Message:
-----------
PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe: rename LibRtcVirtualNotifyEvent
PcatRealTimeClockRuntimeDxe seems to have copied the interface name
LibRtcVirtualNotifyEvent() from EmbeddedPkg's RealTimeClockLib class.
That's not right, for two reasons:
- PcatRealTimeClockRuntimeDxe doesn't consume "EmbeddedPkg.dec" in the
first place,
- in EmbeddedPkg, the RealTimeClockLib class API
LibRtcVirtualNotifyEvent() is about to be eliminated (it's a bogus API).
Rename the LibRtcVirtualNotifyEvent() function to VirtualNotifyEvent(),
and make it static.
Tested with booting OVMF.
Cc: Ray Ni <[email protected]>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4564
Signed-off-by: Laszlo Ersek <[email protected]>
Message-Id: <[email protected]>
Reviewed-by: Sami Mujawar <[email protected]>
Tested-by: Sami Mujawar <[email protected]>
Reviewed-by: Ard Biesheuvel <[email protected]>
Commit: 189addfde6e01b49de269700c979551675336f80
https://github.com/tianocore/edk2/commit/189addfde6e01b49de269700c979551675336f80
Author: Laszlo Ersek <[email protected]>
Date: 2023-10-18 (Wed, 18 Oct 2023)
Changed paths:
M ArmPlatformPkg/Library/PL031RealTimeClockLib/PL031RealTimeClockLib.c
Log Message:
-----------
ArmPlatformPkg/PL031RealTimeClockLib: hide LibRtcVirtualNotifyEvent
The RealTimeClockLib class header in edk2 mistakenly declares a function
called LibRtcVirtualNotifyEvent(). No component ever calls this function
crossing module boundaries; all RealTimeClockLib instances in edk2 and
edk2-platforms are supposed to register (and do register) their
SetVirtualAddressMap() notification functions.
Rename LibRtcVirtualNotifyEvent() to VirtualNotifyEvent(), and make it
static, in preparation for removing the LibRtcVirtualNotifyEvent()
declaration from the lib class header later.
Build- and boot-tested with ArmVirtQemu.
Cc: Ard Biesheuvel <[email protected]>
Cc: Leif Lindholm <[email protected]>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4564
Signed-off-by: Laszlo Ersek <[email protected]>
Message-Id: <[email protected]>
Reviewed-by: Sami Mujawar <[email protected]>
Reviewed-by: Ard Biesheuvel <[email protected]>
Commit: e6e0e7ba74b670564efea79e628207f5f76ce743
https://github.com/tianocore/edk2/commit/e6e0e7ba74b670564efea79e628207f5f76ce743
Author: Laszlo Ersek <[email protected]>
Date: 2023-10-18 (Wed, 18 Oct 2023)
Changed paths:
M EmbeddedPkg/Library/TemplateRealTimeClockLib/RealTimeClockLib.c
Log Message:
-----------
EmbeddedPkg/TemplateRealTimeClockLib: drop LibRtcVirtualNotifyEvent
The RealTimeClockLib class header in edk2 mistakenly declares a function
called LibRtcVirtualNotifyEvent(). No component ever calls this function
crossing module boundaries; all RealTimeClockLib instances in edk2 and
edk2-platforms are supposed to register (and do register) their
SetVirtualAddressMap() notification functions.
In particular, TemplateRealTimeClockLib *itself* doesn't even use
LibRtcVirtualNotifyEvent() -- the function is defined with an empty body,
clearly in an understandable, but misguided, attempt, to conform to the
(bogus) library interface. Remove the function.
Build-tested only (with "EmbeddedPkg.dsc").
Cc: Abner Chang <[email protected]>
Cc: Ard Biesheuvel <[email protected]>
Cc: Daniel Schaefer <[email protected]>
Cc: Leif Lindholm <[email protected]>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4564
Signed-off-by: Laszlo Ersek <[email protected]>
Message-Id: <[email protected]>
Reviewed-by: Ard Biesheuvel <[email protected]>
Commit: 3c3136d3b6ae2976cbe05ff2b8f23ae58b780034
https://github.com/tianocore/edk2/commit/3c3136d3b6ae2976cbe05ff2b8f23ae58b780034
Author: Laszlo Ersek <[email protected]>
Date: 2023-10-18 (Wed, 18 Oct 2023)
Changed paths:
M EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.c
Log Message:
-----------
EmbeddedPkg/VirtualRealTimeClockLib: drop LibRtcVirtualNotifyEvent
The RealTimeClockLib class header in edk2 mistakenly declares a function
called LibRtcVirtualNotifyEvent(). No component ever calls this function
crossing module boundaries; all RealTimeClockLib instances in edk2 and
edk2-platforms are supposed to register (and do register) their
SetVirtualAddressMap() notification functions.
In particular, VirtualRealTimeClockLib *itself* doesn't even use
LibRtcVirtualNotifyEvent() -- the function is defined with an empty body,
clearly in an understandable, but misguided, attempt, to conform to the
(bogus) library interface. Remove the function.
Build-tested only (with "RiscVVirtQemu.dsc").
Cc: Abner Chang <[email protected]>
Cc: Ard Biesheuvel <[email protected]>
Cc: Daniel Schaefer <[email protected]>
Cc: Leif Lindholm <[email protected]>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4564
Signed-off-by: Laszlo Ersek <[email protected]>
Message-Id: <[email protected]>
Reviewed-by: Ard Biesheuvel <[email protected]>
Commit: 7fe49887c4d227e585d5aa5530ee8a8d79d5fa1e
https://github.com/tianocore/edk2/commit/7fe49887c4d227e585d5aa5530ee8a8d79d5fa1e
Author: Laszlo Ersek <[email protected]>
Date: 2023-10-18 (Wed, 18 Oct 2023)
Changed paths:
M EmbeddedPkg/Include/Library/RealTimeClockLib.h
Log Message:
-----------
EmbeddedPkg/RealTimeClockLib: drop LibRtcVirtualNotifyEvent from lib class
The RealTimeClockLib class header in edk2 mistakenly declares a function
called LibRtcVirtualNotifyEvent(). No component ever calls this function
crossing module boundaries; all RealTimeClockLib instances in edk2 and
edk2-platforms are supposed to register (and do register) their
SetVirtualAddressMap() notification functions.
At this point, the word "LibRtcVirtualNotifyEvent" no longer occurs in any
of edk2, edk2-platforms, even edk2-non-osi, except the library class
header proper. Remove the LibRtcVirtualNotifyEvent() function declaration.
Build-tested only (with "EmbeddedPkg.dsc").
Cc: Abner Chang <[email protected]>
Cc: Ard Biesheuvel <[email protected]>
Cc: Daniel Schaefer <[email protected]>
Cc: Leif Lindholm <[email protected]>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4564
Signed-off-by: Laszlo Ersek <[email protected]>
Message-Id: <[email protected]>
Reviewed-by: Ard Biesheuvel <[email protected]>
Compare: https://github.com/tianocore/edk2/compare/747a08eae26b...7fe49887c4d2
_______________________________________________
edk2-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-commits
