Branch: refs/heads/master
Home: https://github.com/tianocore/edk2
Commit: 575bd4f55c0aea6096579a649a018cfd183546fc
https://github.com/tianocore/edk2/commit/575bd4f55c0aea6096579a649a018cfd183546fc
Author: Jeshua Smith <[email protected]>
Date: 2023-10-23 (Mon, 23 Oct 2023)
Changed paths:
M
DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManagerObjectParser.c
Log Message:
-----------
DynamicTablesPkg/TableHelperLib: Fix and improve text handling
This fixes two bugs and adds some enhancements to the handling of
characters and strings in objects being printed by the CM ObjectParser.
Bug fixes:
1. PrintOemID() currently attempts to print characters with "%C",
but the correct syntax is (lowercase) "%c". This bug results in
"CCCCCC" being printed instead of the actual ASCII characters.
2. PrintString() is being passed a pointer to data in objects, but in
some cases this data is the actual string to print and other cases
it is a pointer to the string to print. This adds a PrintStringPtr
function and uses the correct functions depending on the situation.
Enhancements:
1. Some objects contain ASCII characters, which are currently printed
as their hex values. This adds functions to print out ASCII
character fields as text rather than hex, and uses those functions in
several cases where the object data is defined to be ASCII.
2. The PrintOemID() function is replaced with the new identical but more
generecically-named PrintChar6() function.
Signed-off-by: Jeshua Smith <[email protected]>
Reviewed-by: Pierre Gondois <[email protected]>
Reviewed-by: Sami Mujawar <[email protected]>
Commit: ec7f73436646a9232c6494d1ce23fb38000e10d3
https://github.com/tianocore/edk2/commit/ec7f73436646a9232c6494d1ce23fb38000e10d3
Author: Jeshua Smith <[email protected]>
Date: 2023-10-23 (Mon, 23 Oct 2023)
Changed paths:
M
DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManagerObjectParser.c
Log Message:
-----------
DynamicTablesPkg/TableHelperLib: Enhance error handling
This patch enhances error handling and reporting in the CM ObjectParser.
Specifically:
1. ObjectIDs used as array indexes are checked for being out of bounds,
and if so an error message is printed before the assert.
2. An error message is printed for unsupported NameSpaceIDs.
3. Adds support for unimplemented parsers by allowing IDs to list a
NULL parser, resulting in an unimplemented message being printed.
Signed-off-by: Jeshua Smith <[email protected]>
Reviewed-by: Pierre Gondois <[email protected]>
Reviewed-by: Sami Mujawar <[email protected]>
Compare: https://github.com/tianocore/edk2/compare/c591395f4ab5...ec7f73436646
_______________________________________________
edk2-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-commits
