Branch: refs/heads/master
Home: https://github.com/tianocore/edk2
Commit: 506cc670c000e243c10c6796fee0aa8137c58e32
https://github.com/tianocore/edk2/commit/506cc670c000e243c10c6796fee0aa8137c58e32
Author: Laszlo Ersek <[email protected]>
Date: 2023-12-07 (Thu, 07 Dec 2023)
Changed paths:
M OvmfPkg/Bhyve/BhyveX64.dsc
M OvmfPkg/IntelTdx/IntelTdxX64.dsc
M OvmfPkg/OvmfPkgIa32.dsc
M OvmfPkg/OvmfPkgIa32X64.dsc
M OvmfPkg/OvmfPkgX64.dsc
M OvmfPkg/OvmfXen.dsc
Log Message:
-----------
OvmfPkg: cripple CSM_ENABLE macro
We're going to gradually tear down and remove the Compatibility Support
Module (CSM) in OvmfPkg (due to it having no maintainer). Start by making
all platforms that have thus far accepted "-D CSM_ENABLE" reject that
macro, so that mid-series, the partially removed infrastructure cannot be
built or booted.
Insert an !error directive in each DSC file's first "!ifdef $(CSM_ENABLE)"
conditional.
At the end of the series, the !error directive introduced in this patch
will be removed.
Cc: Anthony Perard <[email protected]>
Cc: Ard Biesheuvel <[email protected]>
Cc: Corvin Köhne <[email protected]>
Cc: Gerd Hoffmann <[email protected]>
Cc: Jiewen Yao <[email protected]>
Cc: Rebecca Cran <[email protected]>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4588
Signed-off-by: Laszlo Ersek <[email protected]>
Message-Id: <[email protected]>
Reviewed-by: Jiewen Yao <[email protected]>
Reviewed-by: Ard Biesheuvel <[email protected]>
Acked-by: Corvin Köhne <[email protected]>
Acked-by: Gerd Hoffmann <[email protected]>
Commit: 3099db510e209195ccf662785ecae541d75e6ab8
https://github.com/tianocore/edk2/commit/3099db510e209195ccf662785ecae541d75e6ab8
Author: Laszlo Ersek <[email protected]>
Date: 2023-12-07 (Thu, 07 Dec 2023)
Changed paths:
M OvmfPkg/IntelTdx/IntelTdxX64.dsc
M OvmfPkg/OvmfPkg.dec
M OvmfPkg/OvmfPkgIa32.dsc
M OvmfPkg/OvmfPkgIa32X64.dsc
M OvmfPkg/OvmfPkgX64.dsc
M OvmfPkg/OvmfXen.dsc
M OvmfPkg/PlatformPei/MemDetect.c
M OvmfPkg/PlatformPei/PlatformPei.inf
Log Message:
-----------
OvmfPkg: remove PcdCsmEnable
PcdCsmEnable was introduced in commits 50f911d25d39 ("OvmfPkg: introduce
PcdCsmEnable feature flag", 2020-02-05) and 75839f977d37
("OvmfPkg/PlatformPei: detect SMRAM at default SMBASE (for real)",
2020-02-05). Remove it, and substitute constant FALSE wherever it has been
evaluated thus far.
Regression test: after building OVMF IA32X64 with -D SMM_REQUIRE, and
booting it on Q35, the log still contains
> Q35SmramAtDefaultSmbaseInitialization: SMRAM at default SMBASE found
Cc: Anthony Perard <[email protected]>
Cc: Ard Biesheuvel <[email protected]>
Cc: Gerd Hoffmann <[email protected]>
Cc: Jiewen Yao <[email protected]>
https://bugzilla.tianocore.org/show_bug.cgi?id=4588
Signed-off-by: Laszlo Ersek <[email protected]>
Message-Id: <[email protected]>
Reviewed-by: Jiewen Yao <[email protected]>
Reviewed-by: Ard Biesheuvel <[email protected]>
Acked-by: Corvin Köhne <[email protected]>
Acked-by: Gerd Hoffmann <[email protected]>
Commit: 0600bea167e8bc8c75728907eb641e5aade61da1
https://github.com/tianocore/edk2/commit/0600bea167e8bc8c75728907eb641e5aade61da1
Author: Laszlo Ersek <[email protected]>
Date: 2023-12-07 (Thu, 07 Dec 2023)
Changed paths:
M OvmfPkg/Bhyve/BhyveX64.dsc
M OvmfPkg/OvmfPkgIa32.dsc
M OvmfPkg/OvmfPkgIa32X64.dsc
M OvmfPkg/OvmfPkgX64.dsc
M OvmfPkg/OvmfXen.dsc
Log Message:
-----------
OvmfPkg: unplug LegacyBootManagerLib from BdsDxe and UiApp
Don't register the LegacyBmRefreshAllBootOption() and LegacyBmBoot()
functions in BdsDxe and UiApp.
Cc: Anthony Perard <[email protected]>
Cc: Ard Biesheuvel <[email protected]>
Cc: Corvin Köhne <[email protected]>
Cc: Gerd Hoffmann <[email protected]>
Cc: Jiewen Yao <[email protected]>
Cc: Rebecca Cran <[email protected]>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4588
Signed-off-by: Laszlo Ersek <[email protected]>
Message-Id: <[email protected]>
Reviewed-by: Jiewen Yao <[email protected]>
Reviewed-by: Ard Biesheuvel <[email protected]>
Acked-by: Corvin Köhne <[email protected]>
Acked-by: Gerd Hoffmann <[email protected]>
Commit: 3f3e90d67822c7a2842370611717a9500b06b836
https://github.com/tianocore/edk2/commit/3f3e90d67822c7a2842370611717a9500b06b836
Author: Laszlo Ersek <[email protected]>
Date: 2023-12-07 (Thu, 07 Dec 2023)
Changed paths:
R OvmfPkg/Csm/LegacyBootManagerLib/InternalLegacyBm.h
R OvmfPkg/Csm/LegacyBootManagerLib/LegacyBm.c
R OvmfPkg/Csm/LegacyBootManagerLib/LegacyBootManagerLib.inf
R OvmfPkg/Csm/LegacyBootManagerLib/LegacyBootManagerLib.uni
Log Message:
-----------
OvmfPkg: remove LegacyBootManagerLib
LegacyBootManagerLib is not used by any platform at this point, remove it.
This patch removes mentions of the following CSM resources from the source
code:
- GUIDs (protocols or otherwise):
- gEfiLegacyBiosProtocolGuid
- gEfiLegacyDevOrderVariableGuid
- headers:
- Guid/LegacyDevOrder.h
- Protocol/LegacyBios.h
which extends the list of resources scheduled for removal to:
- GUIDs (protocols or otherwise):
- gEfiLegacyBiosProtocolGuid
- gEfiLegacyDevOrderVariableGuid
- headers:
- Guid/LegacyDevOrder.h
- Protocol/LegacyBios.h
Cc: Ard Biesheuvel <[email protected]>
Cc: Gerd Hoffmann <[email protected]>
Cc: Jiewen Yao <[email protected]>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4588
Signed-off-by: Laszlo Ersek <[email protected]>
Message-Id: <[email protected]>
Reviewed-by: Jiewen Yao <[email protected]>
Reviewed-by: Ard Biesheuvel <[email protected]>
Acked-by: Corvin Köhne <[email protected]>
Acked-by: Gerd Hoffmann <[email protected]>
Commit: 237a0564d4865afb03c83723986c2d572caebc92
https://github.com/tianocore/edk2/commit/237a0564d4865afb03c83723986c2d572caebc92
Author: Laszlo Ersek <[email protected]>
Date: 2023-12-07 (Thu, 07 Dec 2023)
Changed paths:
M OvmfPkg/Bhyve/BhyveX64.dsc
M OvmfPkg/OvmfPkgIa32.dsc
M OvmfPkg/OvmfPkgIa32X64.dsc
M OvmfPkg/OvmfPkgX64.dsc
M OvmfPkg/OvmfXen.dsc
Log Message:
-----------
OvmfPkg: unplug LegacyBootMaintUiLib from UiApp
LegacyBootMaintUiLib registers a form (HII Config Access Protocol
instance) with UiApp, for configuring legacy boot options; stop plugging
it into UiApp.
Cc: Anthony Perard <[email protected]>
Cc: Ard Biesheuvel <[email protected]>
Cc: Corvin Köhne <[email protected]>
Cc: Gerd Hoffmann <[email protected]>
Cc: Jiewen Yao <[email protected]>
Cc: Rebecca Cran <[email protected]>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4588
Signed-off-by: Laszlo Ersek <[email protected]>
Message-Id: <[email protected]>
Reviewed-by: Jiewen Yao <[email protected]>
Reviewed-by: Ard Biesheuvel <[email protected]>
Acked-by: Corvin Köhne <[email protected]>
Acked-by: Gerd Hoffmann <[email protected]>
Commit: 545a5f6b68c15b714b896b881b8fa044a7c854d7
https://github.com/tianocore/edk2/commit/545a5f6b68c15b714b896b881b8fa044a7c854d7
Author: Laszlo Ersek <[email protected]>
Date: 2023-12-07 (Thu, 07 Dec 2023)
Changed paths:
R OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUi.c
R OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUi.h
R OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiLib.inf
R OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiLib.uni
R OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiStrings.uni
R OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiVfr.Vfr
R OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiVfr.h
Log Message:
-----------
OvmfPkg: remove LegacyBootMaintUiLib
LegacyBootMaintUiLib is not used by any platform at this point, remove it.
This patch removes mentions of the following CSM resources from the source
code:
- GUIDs (protocols or otherwise):
- gEfiLegacyBiosProtocolGuid
- gEfiLegacyDevOrderVariableGuid
- headers:
- Guid/LegacyDevOrder.h
- Protocol/LegacyBios.h
which extends the list of resources scheduled for removal to:
- GUIDs (protocols or otherwise):
- gEfiLegacyBiosProtocolGuid
- gEfiLegacyDevOrderVariableGuid
- headers:
- Guid/LegacyDevOrder.h
- Protocol/LegacyBios.h
Cc: Ard Biesheuvel <[email protected]>
Cc: Gerd Hoffmann <[email protected]>
Cc: Jiewen Yao <[email protected]>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4588
Signed-off-by: Laszlo Ersek <[email protected]>
Message-Id: <[email protected]>
Reviewed-by: Jiewen Yao <[email protected]>
Reviewed-by: Ard Biesheuvel <[email protected]>
Acked-by: Corvin Köhne <[email protected]>
Acked-by: Gerd Hoffmann <[email protected]>
Commit: e948ceeb80cd9a0b95871154eb9ae083cc659b1b
https://github.com/tianocore/edk2/commit/e948ceeb80cd9a0b95871154eb9ae083cc659b1b
Author: Laszlo Ersek <[email protected]>
Date: 2023-12-07 (Thu, 07 Dec 2023)
Changed paths:
R OvmfPkg/Csm/Include/Guid/LegacyDevOrder.h
M OvmfPkg/OvmfPkg.dec
Log Message:
-----------
OvmfPkg: remove gEfiLegacyDevOrderVariableGuid
At this point, gEfiLegacyDevOrderVariableGuid is unused; remove it.
This shrinks the list of resources scheduled for removal to:
- GUIDs (protocols or otherwise):
- gEfiLegacyBiosProtocolGuid
- headers:
- Protocol/LegacyBios.h
Cc: Ard Biesheuvel <[email protected]>
Cc: Gerd Hoffmann <[email protected]>
Cc: Jiewen Yao <[email protected]>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4588
Signed-off-by: Laszlo Ersek <[email protected]>
Message-Id: <[email protected]>
Reviewed-by: Jiewen Yao <[email protected]>
Reviewed-by: Ard Biesheuvel <[email protected]>
Acked-by: Corvin Köhne <[email protected]>
Acked-by: Gerd Hoffmann <[email protected]>
Commit: ac79397267fe3b9e010549ace38a1e4c8c360d54
https://github.com/tianocore/edk2/commit/ac79397267fe3b9e010549ace38a1e4c8c360d54
Author: Laszlo Ersek <[email protected]>
Date: 2023-12-07 (Thu, 07 Dec 2023)
Changed paths:
M OvmfPkg/Bhyve/BhyveRfbDxe/GopDriver.c
M OvmfPkg/Bhyve/BhyveX64.dsc
M OvmfPkg/Bhyve/BhyveX64.fdf
M OvmfPkg/IntelTdx/IntelTdxX64.dsc
M OvmfPkg/OvmfPkgIa32.dsc
M OvmfPkg/OvmfPkgIa32.fdf
M OvmfPkg/OvmfPkgIa32X64.dsc
M OvmfPkg/OvmfPkgIa32X64.fdf
M OvmfPkg/OvmfPkgX64.dsc
M OvmfPkg/OvmfPkgX64.fdf
M OvmfPkg/OvmfXen.dsc
M OvmfPkg/OvmfXen.fdf
Log Message:
-----------
OvmfPkg: exclude the CSM-based VideoDxe driver
The CSM-based VideoDxe driver is a special UEFI_DRIVER module that both
follows and doesn't follow the UEFI driver model.
Namely, in the Supported and Start members of its Driver Binding Protocol
instance, it consumes the Legacy Bios Protocol directly from the UEFI
protocol database, as opposed to (only) opening protocols on the handle
that it is supposed to bind.
Furthermore, the driver "marks" its own image handle with the
NULL-interface "Legacy Bios" (pseudo-protocol) GUID, in order to "inform
back" the provider of the Legacy Bios Protocol, i.e., LegacyBiosDxe, that
VideoDxe is a "BIOS Thunk Driver" in the system.
Quoting "OvmfPkg/Csm/Include/Guid/LegacyBios.h", such a driver follows the
UEFI Driver Model, but still uses the Int86() or FarCall() services of the
Legacy Bios Protocol as the basis for the UEFI protocol it produces.
In a sense, there is a circular dependency between VideoDxe and
LegacyBiosDxe; each knows about the other. However, VideoDxe is a
UEFI_DRIVER, while LegacyBiosDxe is a platform DXE_DRIVER with a very long
DEPEX. Therefore, for keeping dependencies conceptually intact, first
exclude VideoDxe from the OVMF platforms. Always include the
hypervisor-specific real UEFI video driver.
--*--
Note that the pathname
"IntelFrameworkModulePkg/Csm/BiosThunk/VideoDxe/VideoDxe.inf" in the bhyve
platform DSC and FDF files is bogus anyway.
Cc: Anthony Perard <[email protected]>
Cc: Ard Biesheuvel <[email protected]>
Cc: Corvin Köhne <[email protected]>
Cc: Gerd Hoffmann <[email protected]>
Cc: Jiewen Yao <[email protected]>
Cc: Rebecca Cran <[email protected]>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4588
Signed-off-by: Laszlo Ersek <[email protected]>
Message-Id: <[email protected]>
Reviewed-by: Jiewen Yao <[email protected]>
Reviewed-by: Ard Biesheuvel <[email protected]>
Acked-by: Corvin Köhne <[email protected]>
Acked-by: Gerd Hoffmann <[email protected]>
Commit: 59dc8743ceb980cab2699aae62e436fcf56fcf53
https://github.com/tianocore/edk2/commit/59dc8743ceb980cab2699aae62e436fcf56fcf53
Author: Laszlo Ersek <[email protected]>
Date: 2023-12-07 (Thu, 07 Dec 2023)
Changed paths:
R OvmfPkg/Csm/BiosThunk/VideoDxe/BiosVideo.c
R OvmfPkg/Csm/BiosThunk/VideoDxe/BiosVideo.h
R OvmfPkg/Csm/BiosThunk/VideoDxe/BiosVideoDxe.uni
R OvmfPkg/Csm/BiosThunk/VideoDxe/BiosVideoDxeExtra.uni
R OvmfPkg/Csm/BiosThunk/VideoDxe/ComponentName.c
R OvmfPkg/Csm/BiosThunk/VideoDxe/VesaBiosExtensions.h
R OvmfPkg/Csm/BiosThunk/VideoDxe/VideoDxe.inf
Log Message:
-----------
OvmfPkg: remove Csm/BiosThunk/VideoDxe
Csm/BiosThunk/VideoDxe is not used by any platform at this point, remove
it.
This patch removes mentions of the following CSM resources from the source
code:
- GUIDs (protocols or otherwise):
- gEfiLegacyBiosGuid
- gEfiLegacyBiosProtocolGuid
- gEfiVgaMiniPortProtocolGuid
- headers:
- FrameworkDxe.h
- Guid/LegacyBios.h
- Protocol/LegacyBios.h
- Protocol/VgaMiniPort.h
- PCDs:
- PcdBiosVideoCheckVbeEnable
- PcdBiosVideoCheckVgaEnable
- PcdBiosVideoSetTextVgaModeEnable
which extends the list of resources scheduled for removal to:
- GUIDs (protocols or otherwise):
- gEfiLegacyBiosGuid
- gEfiLegacyBiosProtocolGuid
- gEfiVgaMiniPortProtocolGuid
- headers:
- FrameworkDxe.h
- Guid/LegacyBios.h
- Protocol/LegacyBios.h
- Protocol/VgaMiniPort.h
- PCDs:
- PcdBiosVideoCheckVbeEnable
- PcdBiosVideoCheckVgaEnable
- PcdBiosVideoSetTextVgaModeEnable
Cc: Ard Biesheuvel <[email protected]>
Cc: Gerd Hoffmann <[email protected]>
Cc: Jiewen Yao <[email protected]>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4588
Signed-off-by: Laszlo Ersek <[email protected]>
Message-Id: <[email protected]>
Reviewed-by: Jiewen Yao <[email protected]>
Reviewed-by: Ard Biesheuvel <[email protected]>
Acked-by: Corvin Köhne <[email protected]>
Acked-by: Gerd Hoffmann <[email protected]>
Commit: 4493d74e18e330370d4c7a4724833840daa8646c
https://github.com/tianocore/edk2/commit/4493d74e18e330370d4c7a4724833840daa8646c
Author: Laszlo Ersek <[email protected]>
Date: 2023-12-07 (Thu, 07 Dec 2023)
Changed paths:
R OvmfPkg/Csm/Include/Protocol/VgaMiniPort.h
M OvmfPkg/OvmfPkg.dec
Log Message:
-----------
OvmfPkg: remove gEfiVgaMiniPortProtocolGuid
At this point, gEfiVgaMiniPortProtocolGuid is unused; remove it.
This shrinks the list of resources scheduled for removal to:
- GUIDs (protocols or otherwise):
- gEfiLegacyBiosGuid
- gEfiLegacyBiosProtocolGuid
- headers:
- FrameworkDxe.h
- Guid/LegacyBios.h
- Protocol/LegacyBios.h
- PCDs:
- PcdBiosVideoCheckVbeEnable
- PcdBiosVideoCheckVgaEnable
- PcdBiosVideoSetTextVgaModeEnable
Cc: Ard Biesheuvel <[email protected]>
Cc: Gerd Hoffmann <[email protected]>
Cc: Jiewen Yao <[email protected]>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4588
Signed-off-by: Laszlo Ersek <[email protected]>
Message-Id: <[email protected]>
Reviewed-by: Jiewen Yao <[email protected]>
Reviewed-by: Ard Biesheuvel <[email protected]>
Acked-by: Corvin Köhne <[email protected]>
Acked-by: Gerd Hoffmann <[email protected]>
Commit: ec60da42325a73e658877eac6435fd6fda8f3a3a
https://github.com/tianocore/edk2/commit/ec60da42325a73e658877eac6435fd6fda8f3a3a
Author: Laszlo Ersek <[email protected]>
Date: 2023-12-07 (Thu, 07 Dec 2023)
Changed paths:
M OvmfPkg/OvmfPkg.dec
Log Message:
-----------
OvmfPkg: remove Bios Video PCDs
PcdBiosVideoSetTextVgaModeEnable, PcdBiosVideoCheckVbeEnable and
PcdBiosVideoCheckVgaEnable are unused at this point, remove them.
This shrinks the list of resources scheduled for removal to:
- GUIDs (protocols or otherwise):
- gEfiLegacyBiosGuid
- gEfiLegacyBiosProtocolGuid
- headers:
- FrameworkDxe.h
- Guid/LegacyBios.h
- Protocol/LegacyBios.h
Cc: Ard Biesheuvel <[email protected]>
Cc: Gerd Hoffmann <[email protected]>
Cc: Jiewen Yao <[email protected]>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4588
Signed-off-by: Laszlo Ersek <[email protected]>
Message-Id: <[email protected]>
Reviewed-by: Jiewen Yao <[email protected]>
Reviewed-by: Ard Biesheuvel <[email protected]>
Acked-by: Corvin Köhne <[email protected]>
Acked-by: Gerd Hoffmann <[email protected]>
Commit: 934b7f5a730f69ee59144ffc264347956411c9bf
https://github.com/tianocore/edk2/commit/934b7f5a730f69ee59144ffc264347956411c9bf
Author: Laszlo Ersek <[email protected]>
Date: 2023-12-07 (Thu, 07 Dec 2023)
Changed paths:
M OvmfPkg/Bhyve/BhyveX64.dsc
M OvmfPkg/Bhyve/BhyveX64.fdf
M OvmfPkg/OvmfPkgIa32.dsc
M OvmfPkg/OvmfPkgIa32.fdf
M OvmfPkg/OvmfPkgIa32X64.dsc
M OvmfPkg/OvmfPkgIa32X64.fdf
M OvmfPkg/OvmfPkgX64.dsc
M OvmfPkg/OvmfPkgX64.fdf
M OvmfPkg/OvmfXen.dsc
M OvmfPkg/OvmfXen.fdf
Log Message:
-----------
OvmfPkg: exclude LegacyBiosDxe
LegacyBiosDxe is the core CSM driver. It procudes
gEfiLegacyBiosProtocolGuid, on top of several smaller, more foundational
legacy BIOS protocols, whose drivers we've not excluded yet. In the course
of tearing down CSM support in (reverse) dependency order, exclude
LegacyBiosDxe at this point.
Cc: Anthony Perard <[email protected]>
Cc: Ard Biesheuvel <[email protected]>
Cc: Corvin Köhne <[email protected]>
Cc: Gerd Hoffmann <[email protected]>
Cc: Jiewen Yao <[email protected]>
Cc: Rebecca Cran <[email protected]>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4588
Signed-off-by: Laszlo Ersek <[email protected]>
Message-Id: <[email protected]>
Reviewed-by: Jiewen Yao <[email protected]>
Reviewed-by: Ard Biesheuvel <[email protected]>
Acked-by: Corvin Köhne <[email protected]>
Acked-by: Gerd Hoffmann <[email protected]>
Commit: 87d0e572c82689ffec896379e5e4037717df933e
https://github.com/tianocore/edk2/commit/87d0e572c82689ffec896379e5e4037717df933e
Author: Laszlo Ersek <[email protected]>
Date: 2023-12-07 (Thu, 07 Dec 2023)
Changed paths:
M OvmfPkg/IncompatiblePciDeviceSupportDxe/IncompatiblePciDeviceSupport.c
M OvmfPkg/IncompatiblePciDeviceSupportDxe/IncompatiblePciDeviceSupport.inf
Log Message:
-----------
OvmfPkg/IncompatiblePciDeviceSupportDxe: ignore CSM presence
The UEFI protocol database cannot contain gEfiLegacyBiosProtocolGuid any
longer, after excluding LegacyBiosDxe from the OVMF platforms. Therefore,
instruct PciBusDxe from IncompatiblePciDeviceSupportDxe to allocate 64-bit
BARs above 4 GB regardless of a CSM.
Regression test: in commit 855743f71774 ("OvmfPkg: prevent 64-bit MMIO BAR
degradation if there is no CSM", 2016-05-25), where we introduced
IncompatiblePciDeviceSupportDxe, we said, "By default, the PCI Bus driver
considers an option ROM reason enough for allocating the 64-bit MMIO BARs
in 32-bit address space". Therefore it suffices to verify the 64-bit BARs
of a device for which QEMU provides an option ROM. The simplest case is
the virtio-net-pci device. And indeed, with this patch applied, the log
contains:
> PciBus: Discovered PCI @ [04|00|00] [VID = 0x1AF4, DID = 0x1041]
> BAR[1]: Type = Mem32; Alignment = 0xFFF; Length = 0x1000;
> Offset = 0x14
> BAR[4]: Type = PMem64; Alignment = 0x3FFF; Length = 0x4000;
> Offset = 0x20
This portion shows that Bus|Device|Function 04|00|00 is a (modern)
virito-net-pci device [VID = 0x1AF4, DID = 0x1041].
> PciBus: Resource Map for Bridge [00|01|03]
> Type = Mem32; Base = 0x81200000; Length = 0x200000; Alignment =
> 0x1FFFFF
> Base = Padding; Length = 0x200000; Alignment = 0x1FFFFF
> Base = 0x81200000; Length = 0x1000; Alignment = 0xFFF; Owner
> = PCI [04|00|00:14]
> Type = Mem32; Base = 0x81A43000; Length = 0x1000; Alignment =
> 0xFFF
> Type = PMem64; Base = 0x800200000; Length = 0x100000; Alignment =
> 0xFFFFF
> Base = 0x800200000; Length = 0x4000; Alignment = 0x3FFF; Owner
> = PCI [04|00|00:20]
This quote shows that 04|00|00 has a BAR at 0x8_0020_0000.
(It also shows that the device is behind a bridge (PCIe root port) whose
own BDF is 00|01|03.)
> [Security] 3rd party image[7CEEB418] can be loaded after EndOfDxe:
> PciRoot(0x0)/Pci(0x1,0x3)/Pci(0x0,0x0)/Offset(0x10E00,0x273FF).
> None of Tcg2Protocol/CcMeasurementProtocol is installed.
> InstallProtocolInterface: [EfiLoadedImageProtocol] 7D2E5140
> Loading driver at 0x0007CA9F000 EntryPoint=0x0007CAA5447 1af41000.efi
> InstallProtocolInterface: [EfiLoadedImageDevicePathProtocol] 7D5B2198
And this part finally shows that the iPXE option ROM for the device
(1af41000.efi) was detected and is loaded. (Same PCIe root port, and PCIe
root ports can only host a single device.)
Cc: Ard Biesheuvel <[email protected]>
Cc: Gerd Hoffmann <[email protected]>
Cc: Jiewen Yao <[email protected]>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4588
Signed-off-by: Laszlo Ersek <[email protected]>
Message-Id: <[email protected]>
Reviewed-by: Jiewen Yao <[email protected]>
Reviewed-by: Ard Biesheuvel <[email protected]>
Acked-by: Corvin Köhne <[email protected]>
Acked-by: Gerd Hoffmann <[email protected]>
Commit: 209480b04743b609c4a14bf6fb61b165f81e1e1a
https://github.com/tianocore/edk2/commit/209480b04743b609c4a14bf6fb61b165f81e1e1a
Author: Laszlo Ersek <[email protected]>
Date: 2023-12-07 (Thu, 07 Dec 2023)
Changed paths:
M OvmfPkg/OvmfPkgIa32X64.dsc
M OvmfPkg/OvmfPkgX64.dsc
Log Message:
-----------
Revert "OvmfPkg: don't assign PCI BARs above 4GiB when CSM enabled"
This reverts commit c7341877f69505e69acd199c84b6c09218058bfa.
That commit was a later (2019-06-26), heavier weight exclusion of 64-bit
BARs when a CSM was included, and is similarly superfluous now, so revert
it.
Cc: Ard Biesheuvel <[email protected]>
Cc: Gerd Hoffmann <[email protected]>
Cc: Jiewen Yao <[email protected]>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4588
Signed-off-by: Laszlo Ersek <[email protected]>
Message-Id: <[email protected]>
Reviewed-by: Jiewen Yao <[email protected]>
Reviewed-by: Ard Biesheuvel <[email protected]>
Acked-by: Corvin Köhne <[email protected]>
Acked-by: Gerd Hoffmann <[email protected]>
Commit: f0c5d652d93b01cb7fce2272045f632a6af79765
https://github.com/tianocore/edk2/commit/f0c5d652d93b01cb7fce2272045f632a6af79765
Author: Laszlo Ersek <[email protected]>
Date: 2023-12-07 (Thu, 07 Dec 2023)
Changed paths:
R OvmfPkg/Csm/LegacyBiosDxe/IA32/InterruptTable.nasm
R OvmfPkg/Csm/LegacyBiosDxe/LegacyBbs.c
R OvmfPkg/Csm/LegacyBiosDxe/LegacyBda.c
R OvmfPkg/Csm/LegacyBiosDxe/LegacyBios.c
R OvmfPkg/Csm/LegacyBiosDxe/LegacyBiosDxe.inf
R OvmfPkg/Csm/LegacyBiosDxe/LegacyBiosDxe.uni
R OvmfPkg/Csm/LegacyBiosDxe/LegacyBiosDxeExtra.uni
R OvmfPkg/Csm/LegacyBiosDxe/LegacyBiosInterface.h
R OvmfPkg/Csm/LegacyBiosDxe/LegacyBootSupport.c
R OvmfPkg/Csm/LegacyBiosDxe/LegacyCmos.c
R OvmfPkg/Csm/LegacyBiosDxe/LegacyIde.c
R OvmfPkg/Csm/LegacyBiosDxe/LegacyPci.c
R OvmfPkg/Csm/LegacyBiosDxe/LegacySio.c
R OvmfPkg/Csm/LegacyBiosDxe/Thunk.c
R OvmfPkg/Csm/LegacyBiosDxe/X64/InterruptTable.nasm
Log Message:
-----------
OvmfPkg: remove LegacyBiosDxe
LegacyBiosDxe is not used by any platform at this point, remove it.
This patch removes mentions of the following CSM resources from the source
code [*] [**]:
- GUIDs (protocols or otherwise):
- gEfiIsaIoProtocolGuid
- gEfiLegacy8259ProtocolGuid
- gEfiLegacyBiosGuid
- gEfiLegacyBiosPlatformProtocolGuid
- gEfiLegacyBiosProtocolGuid
- gEfiLegacyInterruptProtocolGuid
- headers:
- FrameworkDxe.h
- Guid/LegacyBios.h
- Protocol/IsaIo.h
- Protocol/Legacy8259.h
- Protocol/LegacyBios.h
- Protocol/LegacyBiosPlatform.h
- Protocol/LegacyInterrupt.h
- PCDs:
- PcdEbdaReservedMemorySize
- PcdEndOpromShadowAddress
- PcdHighPmmMemorySize
- PcdLegacyBiosCacheLegacyRegion
- PcdLowPmmMemorySize
- PcdOpromReservedMemoryBase
- PcdOpromReservedMemorySize
which extends the list of resources scheduled for removal to:
- GUIDs (protocols or otherwise):
- gEfiIsaIoProtocolGuid
- gEfiLegacy8259ProtocolGuid
- gEfiLegacyBiosGuid
- gEfiLegacyBiosPlatformProtocolGuid
- gEfiLegacyBiosProtocolGuid
- gEfiLegacyInterruptProtocolGuid
- headers:
- FrameworkDxe.h
- Guid/LegacyBios.h
- Protocol/IsaIo.h
- Protocol/Legacy8259.h
- Protocol/LegacyBios.h
- Protocol/LegacyBiosPlatform.h
- Protocol/LegacyInterrupt.h
- PCDs:
- PcdEbdaReservedMemorySize
- PcdEndOpromShadowAddress
- PcdHighPmmMemorySize
- PcdLegacyBiosCacheLegacyRegion
- PcdLowPmmMemorySize
- PcdOpromReservedMemoryBase
- PcdOpromReservedMemorySize
[*] Note that gEfiGenericMemTestProtocolGuid, while not a CSM-related
protocol, also becomes useless in the OVMF platforms, so we'll deal with
that later in the series as well.
[**] Note that gEfiLegacyRegion2ProtocolGuid, while a CSM-related
protocol, cannot be scheduled for removal, because the protocol GUID is
defined in "MdePkg.dec", and it's not only "OvmfPkg/Csm/CsmSupportLib"
that produces it in all of edk2, but also
"MdeModulePkg/Universal/LegacyRegion2Dxe" (not used by OVMF). For the same
reason, the "Protocol/LegacyRegion2.h" header (from MdePkg) cannot be
scheduled for removal.
Cc: Ard Biesheuvel <[email protected]>
Cc: Gerd Hoffmann <[email protected]>
Cc: Jiewen Yao <[email protected]>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4588
Signed-off-by: Laszlo Ersek <[email protected]>
Message-Id: <[email protected]>
Reviewed-by: Jiewen Yao <[email protected]>
Reviewed-by: Ard Biesheuvel <[email protected]>
Acked-by: Corvin Köhne <[email protected]>
Acked-by: Gerd Hoffmann <[email protected]>
Commit: d7e41ce3409366f1faed7016fdc4a2cd2ed61918
https://github.com/tianocore/edk2/commit/d7e41ce3409366f1faed7016fdc4a2cd2ed61918
Author: Laszlo Ersek <[email protected]>
Date: 2023-12-07 (Thu, 07 Dec 2023)
Changed paths:
M OvmfPkg/AmdSev/AmdSevX64.dsc
M OvmfPkg/AmdSev/AmdSevX64.fdf
M OvmfPkg/Bhyve/BhyveX64.dsc
M OvmfPkg/Bhyve/BhyveX64.fdf
M OvmfPkg/CloudHv/CloudHvX64.dsc
M OvmfPkg/CloudHv/CloudHvX64.fdf
M OvmfPkg/IntelTdx/IntelTdxX64.dsc
M OvmfPkg/IntelTdx/IntelTdxX64.fdf
M OvmfPkg/Microvm/MicrovmX64.dsc
M OvmfPkg/Microvm/MicrovmX64.fdf
M OvmfPkg/OvmfPkgIa32.dsc
M OvmfPkg/OvmfPkgIa32.fdf
M OvmfPkg/OvmfPkgIa32X64.dsc
M OvmfPkg/OvmfPkgIa32X64.fdf
M OvmfPkg/OvmfPkgX64.dsc
M OvmfPkg/OvmfPkgX64.fdf
M OvmfPkg/OvmfXen.dsc
M OvmfPkg/OvmfXen.fdf
M OvmfPkg/RiscVVirt/RiscVVirtQemu.fdf
Log Message:
-----------
OvmfPkg: exclude NullMemoryTestDxe driver
NullMemoryTestDxe was included in the OVMF platforms in historical commit
999a815e9ff3 ("OvmfPkg: Add NullMemoryTestDxe driver", 2011-01-21). It
produces gEfiGenericMemTestProtocolGuid. With LegacyBiosDxe gone, the only
consumer of this protocol in all of edk2 is
"EmulatorPkg/Library/PlatformBmLib/PlatformBmMemoryTest.c". Thus, exclude
NullMemoryTestDxe from all OVMF platforms.
(Notably, ArmVirtPkg platforms don't include NullMemoryTestDxe either.)
Cc: Anatol Belski <[email protected]>
Cc: Andrei Warkentin <[email protected]>
Cc: Anthony Perard <[email protected]>
Cc: Ard Biesheuvel <[email protected]>
Cc: Corvin Köhne <[email protected]>
Cc: Erdem Aktas <[email protected]>
Cc: Gerd Hoffmann <[email protected]>
Cc: Jianyong Wu <[email protected]>
Cc: Jiewen Yao <[email protected]>
Cc: Michael Roth <[email protected]>
Cc: Min Xu <[email protected]>
Cc: Rebecca Cran <[email protected]>
Cc: Sunil V L <[email protected]>
Cc: Tom Lendacky <[email protected]>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4588
Signed-off-by: Laszlo Ersek <[email protected]>
Message-Id: <[email protected]>
Reviewed-by: Jiewen Yao <[email protected]>
Reviewed-by: Ard Biesheuvel <[email protected]>
Acked-by: Corvin Köhne <[email protected]>
Acked-by: Gerd Hoffmann <[email protected]>
Commit: 0730f564ad3600a31ce8bbbb7dddd4cb526d4aa3
https://github.com/tianocore/edk2/commit/0730f564ad3600a31ce8bbbb7dddd4cb526d4aa3
Author: Laszlo Ersek <[email protected]>
Date: 2023-12-07 (Thu, 07 Dec 2023)
Changed paths:
R OvmfPkg/Csm/Include/Protocol/IsaIo.h
M OvmfPkg/OvmfPkg.dec
Log Message:
-----------
OvmfPkg: remove gEfiIsaIoProtocolGuid
At this point, gEfiIsaIoProtocolGuid is unused; remove it.
Recursively, this patch removes mentions of the following further CSM
resources from the source code:
- GUIDs (protocols or otherwise):
- gEfiIsaAcpiProtocolGuid (by cutting the <Protocol/IsaAcpi.h> link)
- headers:
- Protocol/IsaAcpi.h
This changes the list of resources scheduled for removal to:
- GUIDs (protocols or otherwise):
- gEfiIsaAcpiProtocolGuid
- gEfiLegacy8259ProtocolGuid
- gEfiLegacyBiosGuid
- gEfiLegacyBiosPlatformProtocolGuid
- gEfiLegacyBiosProtocolGuid
- gEfiLegacyInterruptProtocolGuid
- headers:
- FrameworkDxe.h
- Guid/LegacyBios.h
- Protocol/IsaAcpi.h
- Protocol/Legacy8259.h
- Protocol/LegacyBios.h
- Protocol/LegacyBiosPlatform.h
- Protocol/LegacyInterrupt.h
- PCDs:
- PcdEbdaReservedMemorySize
- PcdEndOpromShadowAddress
- PcdHighPmmMemorySize
- PcdLegacyBiosCacheLegacyRegion
- PcdLowPmmMemorySize
- PcdOpromReservedMemoryBase
- PcdOpromReservedMemorySize
Cc: Ard Biesheuvel <[email protected]>
Cc: Gerd Hoffmann <[email protected]>
Cc: Jiewen Yao <[email protected]>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4588
Signed-off-by: Laszlo Ersek <[email protected]>
Message-Id: <[email protected]>
Reviewed-by: Jiewen Yao <[email protected]>
Reviewed-by: Ard Biesheuvel <[email protected]>
Acked-by: Corvin Köhne <[email protected]>
Acked-by: Gerd Hoffmann <[email protected]>
Commit: 5161ba8ea04e79cf058cde49d6424a782640b421
https://github.com/tianocore/edk2/commit/5161ba8ea04e79cf058cde49d6424a782640b421
Author: Laszlo Ersek <[email protected]>
Date: 2023-12-07 (Thu, 07 Dec 2023)
Changed paths:
R OvmfPkg/Csm/Include/Protocol/IsaAcpi.h
M OvmfPkg/OvmfPkg.dec
Log Message:
-----------
OvmfPkg: remove gEfiIsaAcpiProtocolGuid
At this point, gEfiIsaAcpiProtocolGuid is unused; remove it.
This shrinks the list of resources scheduled for removal to:
- GUIDs (protocols or otherwise):
- gEfiLegacy8259ProtocolGuid
- gEfiLegacyBiosGuid
- gEfiLegacyBiosPlatformProtocolGuid
- gEfiLegacyBiosProtocolGuid
- gEfiLegacyInterruptProtocolGuid
- headers:
- FrameworkDxe.h
- Guid/LegacyBios.h
- Protocol/Legacy8259.h
- Protocol/LegacyBios.h
- Protocol/LegacyBiosPlatform.h
- Protocol/LegacyInterrupt.h
- PCDs:
- PcdEbdaReservedMemorySize
- PcdEndOpromShadowAddress
- PcdHighPmmMemorySize
- PcdLegacyBiosCacheLegacyRegion
- PcdLowPmmMemorySize
- PcdOpromReservedMemoryBase
- PcdOpromReservedMemorySize
Cc: Ard Biesheuvel <[email protected]>
Cc: Gerd Hoffmann <[email protected]>
Cc: Jiewen Yao <[email protected]>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4588
Signed-off-by: Laszlo Ersek <[email protected]>
Message-Id: <[email protected]>
Reviewed-by: Jiewen Yao <[email protected]>
Reviewed-by: Ard Biesheuvel <[email protected]>
Acked-by: Corvin Köhne <[email protected]>
Acked-by: Gerd Hoffmann <[email protected]>
Commit: 9d4becddbad24ca00b01d68087e0e86d33ec92b6
https://github.com/tianocore/edk2/commit/9d4becddbad24ca00b01d68087e0e86d33ec92b6
Author: Laszlo Ersek <[email protected]>
Date: 2023-12-07 (Thu, 07 Dec 2023)
Changed paths:
R OvmfPkg/Csm/Include/Guid/LegacyBios.h
M OvmfPkg/OvmfPkg.dec
Log Message:
-----------
OvmfPkg: remove gEfiLegacyBiosGuid
At this point, gEfiLegacyBiosGuid is unused; remove it.
This shrinks the list of resources scheduled for removal to:
- GUIDs (protocols or otherwise):
- gEfiLegacy8259ProtocolGuid
- gEfiLegacyBiosPlatformProtocolGuid
- gEfiLegacyBiosProtocolGuid
- gEfiLegacyInterruptProtocolGuid
- headers:
- FrameworkDxe.h
- Protocol/Legacy8259.h
- Protocol/LegacyBios.h
- Protocol/LegacyBiosPlatform.h
- Protocol/LegacyInterrupt.h
- PCDs:
- PcdEbdaReservedMemorySize
- PcdEndOpromShadowAddress
- PcdHighPmmMemorySize
- PcdLegacyBiosCacheLegacyRegion
- PcdLowPmmMemorySize
- PcdOpromReservedMemoryBase
- PcdOpromReservedMemorySize
Cc: Ard Biesheuvel <[email protected]>
Cc: Gerd Hoffmann <[email protected]>
Cc: Jiewen Yao <[email protected]>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4588
Signed-off-by: Laszlo Ersek <[email protected]>
Message-Id: <[email protected]>
Reviewed-by: Jiewen Yao <[email protected]>
Reviewed-by: Ard Biesheuvel <[email protected]>
Acked-by: Corvin Köhne <[email protected]>
Acked-by: Gerd Hoffmann <[email protected]>
Commit: 8bd14e685ef75d0653ab28f554e647ab4f32cd2c
https://github.com/tianocore/edk2/commit/8bd14e685ef75d0653ab28f554e647ab4f32cd2c
Author: Laszlo Ersek <[email protected]>
Date: 2023-12-07 (Thu, 07 Dec 2023)
Changed paths:
M OvmfPkg/OvmfPkg.dec
Log Message:
-----------
OvmfPkg: remove LegacyBiosDxe PCDs
The following PCDs are unused at this point; remove them:
- PcdEbdaReservedMemorySize
- PcdEndOpromShadowAddress
- PcdHighPmmMemorySize
- PcdLegacyBiosCacheLegacyRegion
- PcdLowPmmMemorySize
- PcdOpromReservedMemoryBase
- PcdOpromReservedMemorySize
This shrinks the list of resources scheduled for removal to:
- GUIDs (protocols or otherwise):
- gEfiLegacy8259ProtocolGuid
- gEfiLegacyBiosPlatformProtocolGuid
- gEfiLegacyBiosProtocolGuid
- gEfiLegacyInterruptProtocolGuid
- headers:
- FrameworkDxe.h
- Protocol/Legacy8259.h
- Protocol/LegacyBios.h
- Protocol/LegacyBiosPlatform.h
- Protocol/LegacyInterrupt.h
Cc: Ard Biesheuvel <[email protected]>
Cc: Gerd Hoffmann <[email protected]>
Cc: Jiewen Yao <[email protected]>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4588
Signed-off-by: Laszlo Ersek <[email protected]>
Message-Id: <[email protected]>
Reviewed-by: Jiewen Yao <[email protected]>
Reviewed-by: Ard Biesheuvel <[email protected]>
Acked-by: Corvin Köhne <[email protected]>
Acked-by: Gerd Hoffmann <[email protected]>
Commit: 86cc0f15d9b120c435e285b38df0072ca404522b
https://github.com/tianocore/edk2/commit/86cc0f15d9b120c435e285b38df0072ca404522b
Author: Laszlo Ersek <[email protected]>
Date: 2023-12-07 (Thu, 07 Dec 2023)
Changed paths:
M OvmfPkg/Bhyve/BhyveX64.dsc
M OvmfPkg/OvmfPkgIa32.dsc
M OvmfPkg/OvmfPkgIa32X64.dsc
M OvmfPkg/OvmfPkgX64.dsc
M OvmfPkg/OvmfXen.dsc
Log Message:
-----------
OvmfPkg: unplug CsmSupportLib from BdsDxe
CsmSupportLib is effectively a hack. It produces the following protocols:
- Legacy Bios Platform,
- Legacy Interrupt,
- Legacy Region2.
(Note that the "OvmfPkg/Csm/CsmSupportLib/CsmSupportLib.inf" file contains
an error where it claims that "Legacy Bios Platform" is "consumed" -- it
is not; the lib instance produces that protocol).
At the same time, the library instance consumes
gEfiLegacyBiosProtocolGuid.
This *seemingly* creates a circular dependency with LegacyBiosDxe, because
that driver has the exact opposite protocol usage patterns. The solution
is that LegacyBiosDxe has a DEPEX on the protocols produced by
CsmSupportLib, while CsmSupportLib consumes the Legacy Bios Protocol from
LegacyBiosDxe only in the member functions of the protocols it produces.
Therefore, once BdsDxe is dispatched, and the CsmSupportLib constructor
exposes those three protocols, LegacyBiosDxe can also be started by the
DXE dispatcher, and then the protocols from CsmSupportLib become
functional.
But the main reason why CsmSupportLib is a hack is that it should be a
normal platform DXE driver (called e.g. "CsmSupportDxe"), and not a NULL
class library that's randomly hooked into BdsDxe.
Given that we have removed LegacyBiosDxe earlier (so there is no DEPEX we
need to satisfy now, conceptually), unhook CsmSupportLib from BdsDxe.
--*--
Note that in the BhyveX64 platform, the pathname
"OvmfPkg/Bhyve/Csm/CsmSupportLib/CsmSupportLib.inf" is bogus, and has
always been, since commit 656419f922c0 ("Add BhyvePkg, to support the
bhyve hypervisor", 2020-07-31).
Cc: Anthony Perard <[email protected]>
Cc: Ard Biesheuvel <[email protected]>
Cc: Corvin Köhne <[email protected]>
Cc: Gerd Hoffmann <[email protected]>
Cc: Jiewen Yao <[email protected]>
Cc: Rebecca Cran <[email protected]>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4588
Signed-off-by: Laszlo Ersek <[email protected]>
Message-Id: <[email protected]>
Reviewed-by: Jiewen Yao <[email protected]>
Reviewed-by: Ard Biesheuvel <[email protected]>
Acked-by: Corvin Köhne <[email protected]>
Acked-by: Gerd Hoffmann <[email protected]>
Commit: bc495d89d4ad1615946fd5a5dd1dcc4f69c8c4e9
https://github.com/tianocore/edk2/commit/bc495d89d4ad1615946fd5a5dd1dcc4f69c8c4e9
Author: Laszlo Ersek <[email protected]>
Date: 2023-12-07 (Thu, 07 Dec 2023)
Changed paths:
R OvmfPkg/Csm/CsmSupportLib/CsmSupportLib.c
R OvmfPkg/Csm/CsmSupportLib/CsmSupportLib.h
R OvmfPkg/Csm/CsmSupportLib/CsmSupportLib.inf
R OvmfPkg/Csm/CsmSupportLib/LegacyInterrupt.c
R OvmfPkg/Csm/CsmSupportLib/LegacyInterrupt.h
R OvmfPkg/Csm/CsmSupportLib/LegacyPlatform.c
R OvmfPkg/Csm/CsmSupportLib/LegacyPlatform.h
R OvmfPkg/Csm/CsmSupportLib/LegacyRegion.c
R OvmfPkg/Csm/CsmSupportLib/LegacyRegion.h
Log Message:
-----------
OvmfPkg: remove CsmSupportLib
CsmSupportLib is not used by any platform at this point, remove it.
This patch removes mentions of the following CSM resources from the source
code [*]:
- GUIDs (protocols or otherwise):
- SYSTEM_ROM_FILE_GUID (1547B4F3-3E8A-4FEF-81C8-328ED647AB1A)
- gEfiFirmwareVolumeProtocolGuid (by cutting the
<Protocol/FirmwareVolume.h> link)
- gEfiLegacyBiosPlatformProtocolGuid
- gEfiLegacyBiosProtocolGuid
- gEfiLegacyInterruptProtocolGuid
- headers:
- FrameworkDxe.h
- Protocol/FirmwareVolume.h
- Protocol/LegacyBiosPlatform.h
- Protocol/LegacyInterrupt.h
which extends the list of resources scheduled for removal to:
- GUIDs (protocols or otherwise):
- SYSTEM_ROM_FILE_GUID (1547B4F3-3E8A-4FEF-81C8-328ED647AB1A)
- gEfiFirmwareVolumeProtocolGuid
- gEfiLegacy8259ProtocolGuid
- gEfiLegacyBiosPlatformProtocolGuid
- gEfiLegacyBiosProtocolGuid
- gEfiLegacyInterruptProtocolGuid
- headers:
- FrameworkDxe.h
- Protocol/FirmwareVolume.h
- Protocol/Legacy8259.h
- Protocol/LegacyBios.h
- Protocol/LegacyBiosPlatform.h
- Protocol/LegacyInterrupt.h
[*] Note that gEfiLegacyRegion2ProtocolGuid, while a CSM-related protocol,
cannot be scheduled for removal, because the protocol GUID is defined in
"MdePkg.dec", and it's not only "OvmfPkg/Csm/CsmSupportLib" that produces
it in all of edk2, but also "MdeModulePkg/Universal/LegacyRegion2Dxe" (not
used by OVMF). For the same reason, the "Protocol/LegacyRegion2.h" header
(from MdePkg) cannot be scheduled for removal.
Cc: Ard Biesheuvel <[email protected]>
Cc: Gerd Hoffmann <[email protected]>
Cc: Jiewen Yao <[email protected]>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4588
Signed-off-by: Laszlo Ersek <[email protected]>
Message-Id: <[email protected]>
Reviewed-by: Jiewen Yao <[email protected]>
Reviewed-by: Ard Biesheuvel <[email protected]>
Acked-by: Corvin Köhne <[email protected]>
Acked-by: Gerd Hoffmann <[email protected]>
Commit: f19b3d0cdcd6bccc16268ba8c822ddc77ee0046b
https://github.com/tianocore/edk2/commit/f19b3d0cdcd6bccc16268ba8c822ddc77ee0046b
Author: Laszlo Ersek <[email protected]>
Date: 2023-12-07 (Thu, 07 Dec 2023)
Changed paths:
R OvmfPkg/Csm/Include/Protocol/FirmwareVolume.h
M OvmfPkg/OvmfPkg.dec
Log Message:
-----------
OvmfPkg: remove gEfiFirmwareVolumeProtocolGuid
At this point, gEfiFirmwareVolumeProtocolGuid is unused; remove it.
This shrinks the list of resources scheduled for removal to:
- GUIDs (protocols or otherwise):
- SYSTEM_ROM_FILE_GUID (1547B4F3-3E8A-4FEF-81C8-328ED647AB1A)
- gEfiLegacy8259ProtocolGuid
- gEfiLegacyBiosPlatformProtocolGuid
- gEfiLegacyBiosProtocolGuid
- gEfiLegacyInterruptProtocolGuid
- headers:
- FrameworkDxe.h
- Protocol/Legacy8259.h
- Protocol/LegacyBios.h
- Protocol/LegacyBiosPlatform.h
- Protocol/LegacyInterrupt.h
Cc: Ard Biesheuvel <[email protected]>
Cc: Gerd Hoffmann <[email protected]>
Cc: Jiewen Yao <[email protected]>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4588
Signed-off-by: Laszlo Ersek <[email protected]>
Message-Id: <[email protected]>
Reviewed-by: Jiewen Yao <[email protected]>
Reviewed-by: Ard Biesheuvel <[email protected]>
Acked-by: Corvin Köhne <[email protected]>
Acked-by: Gerd Hoffmann <[email protected]>
Commit: dd63cb95af127e9ac6726f50d307a892483f4ede
https://github.com/tianocore/edk2/commit/dd63cb95af127e9ac6726f50d307a892483f4ede
Author: Laszlo Ersek <[email protected]>
Date: 2023-12-07 (Thu, 07 Dec 2023)
Changed paths:
R OvmfPkg/Csm/Include/Protocol/LegacyBiosPlatform.h
M OvmfPkg/OvmfPkg.dec
Log Message:
-----------
OvmfPkg: remove gEfiLegacyBiosPlatformProtocolGuid
At this point, gEfiLegacyBiosPlatformProtocolGuid is unused; remove it.
This shrinks the list of resources scheduled for removal to:
- GUIDs (protocols or otherwise):
- SYSTEM_ROM_FILE_GUID (1547B4F3-3E8A-4FEF-81C8-328ED647AB1A)
- gEfiLegacy8259ProtocolGuid
- gEfiLegacyBiosProtocolGuid
- gEfiLegacyInterruptProtocolGuid
- headers:
- FrameworkDxe.h
- Protocol/Legacy8259.h
- Protocol/LegacyBios.h
- Protocol/LegacyInterrupt.h
Cc: Ard Biesheuvel <[email protected]>
Cc: Gerd Hoffmann <[email protected]>
Cc: Jiewen Yao <[email protected]>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4588
Signed-off-by: Laszlo Ersek <[email protected]>
Message-Id: <[email protected]>
Reviewed-by: Jiewen Yao <[email protected]>
Reviewed-by: Ard Biesheuvel <[email protected]>
Acked-by: Corvin Köhne <[email protected]>
Acked-by: Gerd Hoffmann <[email protected]>
Commit: 504a0fed85dd39dc214bbbbe5117e8667364c34b
https://github.com/tianocore/edk2/commit/504a0fed85dd39dc214bbbbe5117e8667364c34b
Author: Laszlo Ersek <[email protected]>
Date: 2023-12-07 (Thu, 07 Dec 2023)
Changed paths:
R OvmfPkg/Csm/Include/Protocol/LegacyBios.h
M OvmfPkg/OvmfPkg.dec
Log Message:
-----------
OvmfPkg: remove gEfiLegacyBiosProtocolGuid
At this point, gEfiLegacyBiosProtocolGuid is unused; remove it.
This shrinks the list of resources scheduled for removal to:
- GUIDs (protocols or otherwise):
- SYSTEM_ROM_FILE_GUID (1547B4F3-3E8A-4FEF-81C8-328ED647AB1A)
- gEfiLegacy8259ProtocolGuid
- gEfiLegacyInterruptProtocolGuid
- headers:
- FrameworkDxe.h
- Protocol/Legacy8259.h
- Protocol/LegacyInterrupt.h
Cc: Ard Biesheuvel <[email protected]>
Cc: Gerd Hoffmann <[email protected]>
Cc: Jiewen Yao <[email protected]>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4588
Signed-off-by: Laszlo Ersek <[email protected]>
Message-Id: <[email protected]>
Reviewed-by: Jiewen Yao <[email protected]>
Reviewed-by: Ard Biesheuvel <[email protected]>
Acked-by: Corvin Köhne <[email protected]>
Acked-by: Gerd Hoffmann <[email protected]>
Commit: f14317e9ba7f6a9656ae08a40e287c7c7aa5283e
https://github.com/tianocore/edk2/commit/f14317e9ba7f6a9656ae08a40e287c7c7aa5283e
Author: Laszlo Ersek <[email protected]>
Date: 2023-12-07 (Thu, 07 Dec 2023)
Changed paths:
R OvmfPkg/Csm/Include/Protocol/LegacyInterrupt.h
M OvmfPkg/OvmfPkg.dec
Log Message:
-----------
OvmfPkg: remove gEfiLegacyInterruptProtocolGuid
At this point, gEfiLegacyInterruptProtocolGuid is unused; remove it.
This shrinks the list of resources scheduled for removal to:
- GUIDs (protocols or otherwise):
- SYSTEM_ROM_FILE_GUID (1547B4F3-3E8A-4FEF-81C8-328ED647AB1A)
- gEfiLegacy8259ProtocolGuid
- headers:
- FrameworkDxe.h
- Protocol/Legacy8259.h
Cc: Ard Biesheuvel <[email protected]>
Cc: Gerd Hoffmann <[email protected]>
Cc: Jiewen Yao <[email protected]>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4588
Signed-off-by: Laszlo Ersek <[email protected]>
Message-Id: <[email protected]>
Reviewed-by: Jiewen Yao <[email protected]>
Reviewed-by: Ard Biesheuvel <[email protected]>
Acked-by: Corvin Köhne <[email protected]>
Acked-by: Gerd Hoffmann <[email protected]>
Commit: 769c46a9a2aa76de227763442a2aa84d913527ec
https://github.com/tianocore/edk2/commit/769c46a9a2aa76de227763442a2aa84d913527ec
Author: Laszlo Ersek <[email protected]>
Date: 2023-12-07 (Thu, 07 Dec 2023)
Changed paths:
R OvmfPkg/Csm/Include/Framework/BootScript.h
R OvmfPkg/Csm/Include/Framework/DxeCis.h
R OvmfPkg/Csm/Include/Framework/FirmwareVolumeHeader.h
R OvmfPkg/Csm/Include/Framework/FirmwareVolumeImageFormat.h
R OvmfPkg/Csm/Include/Framework/FrameworkInternalFormRepresentation.h
R OvmfPkg/Csm/Include/Framework/Hob.h
R OvmfPkg/Csm/Include/Framework/StatusCode.h
R OvmfPkg/Csm/Include/FrameworkDxe.h
M OvmfPkg/OvmfPkg.dec
Log Message:
-----------
OvmfPkg: remove <FrameworkDxe.h>
The <FrameworkDxe.h> header is not used by any source file at this point,
remove it.
<FrameworkDxe.h> is a thin wrapper for including all header files under
the "OvmfPkg/Csm/Include/Framework" directory. Remove that directory at
the same time (nothing else references contents in that directory
directly).
Consequently, the "OvmfPkg/Csm/Include" directory becomes empty, and git
automatically deletes it; remove that include path from
"OvmfPkg/OvmfPkg.dec".
This shrinks the list of resources scheduled for removal to:
- GUIDs (protocols or otherwise):
- SYSTEM_ROM_FILE_GUID (1547B4F3-3E8A-4FEF-81C8-328ED647AB1A)
- gEfiLegacy8259ProtocolGuid
- headers:
- Protocol/Legacy8259.h
Cc: Ard Biesheuvel <[email protected]>
Cc: Gerd Hoffmann <[email protected]>
Cc: Jiewen Yao <[email protected]>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4588
Signed-off-by: Laszlo Ersek <[email protected]>
Message-Id: <[email protected]>
Reviewed-by: Jiewen Yao <[email protected]>
Reviewed-by: Ard Biesheuvel <[email protected]>
Acked-by: Corvin Köhne <[email protected]>
Acked-by: Gerd Hoffmann <[email protected]>
Commit: e8f860d92437dd202941c74cf7dfc11929164051
https://github.com/tianocore/edk2/commit/e8f860d92437dd202941c74cf7dfc11929164051
Author: Laszlo Ersek <[email protected]>
Date: 2023-12-07 (Thu, 07 Dec 2023)
Changed paths:
M OvmfPkg/Bhyve/BhyveX64.dsc
M OvmfPkg/Bhyve/BhyveX64.fdf
M OvmfPkg/OvmfPkgIa32.dsc
M OvmfPkg/OvmfPkgIa32.fdf
M OvmfPkg/OvmfPkgIa32X64.dsc
M OvmfPkg/OvmfPkgIa32X64.fdf
M OvmfPkg/OvmfPkgX64.dsc
M OvmfPkg/OvmfPkgX64.fdf
M OvmfPkg/OvmfXen.dsc
M OvmfPkg/OvmfXen.fdf
Log Message:
-----------
OvmfPkg: exclude Csm16.inf / Csm16.bin
The Csm16 module wraps the CONFIG_CSM build of SeaBIOS. "Csm16.inf" has
FILE_GUID 1547B4F3-3E8A-4FEF-81C8-328ED647AB1A, which was previously
referenced by the (now removed) CsmSupportLib, under the name
SYSTEM_ROM_FILE_GUID.
Nothing relies on the SeaBIOS binary any longer, so exclude the Csm16
module from all OVMF platforms.
(Note that the "OvmfPkg/Bhyve/Csm/BhyveCsm16/BhyveCsm16.inf" pathname that
the BhyveX64 platform refers to is bogus anyway.)
Cc: Anthony Perard <[email protected]>
Cc: Ard Biesheuvel <[email protected]>
Cc: Corvin Köhne <[email protected]>
Cc: Gerd Hoffmann <[email protected]>
Cc: Jiewen Yao <[email protected]>
Cc: Rebecca Cran <[email protected]>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4588
Signed-off-by: Laszlo Ersek <[email protected]>
Message-Id: <[email protected]>
Reviewed-by: Jiewen Yao <[email protected]>
Reviewed-by: Ard Biesheuvel <[email protected]>
Acked-by: Corvin Köhne <[email protected]>
Acked-by: Gerd Hoffmann <[email protected]>
Commit: 528ae029adaac13c661ebb4770ccae6513e47401
https://github.com/tianocore/edk2/commit/528ae029adaac13c661ebb4770ccae6513e47401
Author: Laszlo Ersek <[email protected]>
Date: 2023-12-07 (Thu, 07 Dec 2023)
Changed paths:
M OvmfPkg/Bhyve/BhyveX64.fdf
M OvmfPkg/CloudHv/CloudHvX64.fdf
M OvmfPkg/IntelTdx/IntelTdxX64.fdf
M OvmfPkg/Microvm/MicrovmX64.fdf
M OvmfPkg/OvmfPkgIa32.fdf
M OvmfPkg/OvmfPkgIa32X64.fdf
M OvmfPkg/OvmfPkgX64.fdf
M OvmfPkg/OvmfXen.fdf
Log Message:
-----------
OvmfPkg: remove Rule.Common.USER_DEFINED.CSM from all FDF files
We no longer have
INF RuleOverride=CSM OvmfPkg/Csm/Csm16/Csm16.inf
lines in any of the OVMF platform FDF files; remove the CSM rules
themselves.
(Note that some of the more recent platforms had cargo-culted this rule
from the original ones, without ever referencing the rule with
RuleOverride=CSM. Remove those rules as well.)
Cc: Anatol Belski <[email protected]>
Cc: Anthony Perard <[email protected]>
Cc: Ard Biesheuvel <[email protected]>
Cc: Corvin Köhne <[email protected]>
Cc: Gerd Hoffmann <[email protected]>
Cc: Jianyong Wu <[email protected]>
Cc: Jiewen Yao <[email protected]>
Cc: Rebecca Cran <[email protected]>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4588
Signed-off-by: Laszlo Ersek <[email protected]>
Message-Id: <[email protected]>
Reviewed-by: Jiewen Yao <[email protected]>
Reviewed-by: Ard Biesheuvel <[email protected]>
Acked-by: Corvin Köhne <[email protected]>
Acked-by: Gerd Hoffmann <[email protected]>
Commit: 0e0a0a5ee860605ec76592de7717446944bc9dae
https://github.com/tianocore/edk2/commit/0e0a0a5ee860605ec76592de7717446944bc9dae
Author: Laszlo Ersek <[email protected]>
Date: 2023-12-07 (Thu, 07 Dec 2023)
Changed paths:
R OvmfPkg/Csm/Csm16/Csm16.inf
R OvmfPkg/Csm/Csm16/ReadMe.txt
Log Message:
-----------
OvmfPkg: remove Csm16
Csm16 is not used by any platform at this point, remove it.
This shrinks the list of resources scheduled for removal to:
- GUIDs (protocols or otherwise):
- gEfiLegacy8259ProtocolGuid
- headers:
- Protocol/Legacy8259.h
Cc: Ard Biesheuvel <[email protected]>
Cc: Gerd Hoffmann <[email protected]>
Cc: Jiewen Yao <[email protected]>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4588
Signed-off-by: Laszlo Ersek <[email protected]>
Message-Id: <[email protected]>
Reviewed-by: Jiewen Yao <[email protected]>
Reviewed-by: Ard Biesheuvel <[email protected]>
Acked-by: Corvin Köhne <[email protected]>
Acked-by: Gerd Hoffmann <[email protected]>
Commit: 89bd992b1f2977219a4dc22d6c90058547511ec7
https://github.com/tianocore/edk2/commit/89bd992b1f2977219a4dc22d6c90058547511ec7
Author: Laszlo Ersek <[email protected]>
Date: 2023-12-07 (Thu, 07 Dec 2023)
Changed paths:
M OvmfPkg/OvmfPkgIa32.dsc
M OvmfPkg/OvmfPkgIa32.fdf
M OvmfPkg/OvmfPkgIa32X64.dsc
M OvmfPkg/OvmfPkgIa32X64.fdf
M OvmfPkg/OvmfPkgX64.dsc
M OvmfPkg/OvmfPkgX64.fdf
Log Message:
-----------
OvmfPkg: exclude 8254TimerDxe
In the original three OVMF platforms, CSM_ENABLE selects the legacy timer
driver; exclude it. Instead, include LocalApicTimerDxe unconditionally
(which in turn consumes PcdFSBClock).
Background: commits c37cbc030d96 ("OvmfPkg: Switch timer in build time for
OvmfPkg", 2022-04-02) and 07c0c2eb0a59 ("OvmfPkg: fix PcdFSBClock",
2022-05-25).
Regression test: verified that the BDS progress bar still advanced at
normal speed in each platform.
Cc: Ard Biesheuvel <[email protected]>
Cc: Gerd Hoffmann <[email protected]>
Cc: Jiewen Yao <[email protected]>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4588
Signed-off-by: Laszlo Ersek <[email protected]>
Message-Id: <[email protected]>
Reviewed-by: Jiewen Yao <[email protected]>
Reviewed-by: Ard Biesheuvel <[email protected]>
Acked-by: Corvin Köhne <[email protected]>
Acked-by: Gerd Hoffmann <[email protected]>
Commit: 05cffb66374b5f210a94ed39ce81a693b61a468b
https://github.com/tianocore/edk2/commit/05cffb66374b5f210a94ed39ce81a693b61a468b
Author: Laszlo Ersek <[email protected]>
Date: 2023-12-07 (Thu, 07 Dec 2023)
Changed paths:
R OvmfPkg/8254TimerDxe/8254Timer.inf
R OvmfPkg/8254TimerDxe/Timer.c
R OvmfPkg/8254TimerDxe/Timer.h
R OvmfPkg/8254TimerDxe/Timer.uni
R OvmfPkg/8254TimerDxe/TimerExtra.uni
Log Message:
-----------
OvmfPkg: remove 8254TimerDxe
8254TimerDxe is not used by any platforms at this point, remove it.
This patch removes mentions of the following CSM resources from the source
code:
- GUIDs (protocols or otherwise):
- gEfiLegacy8259ProtocolGuid
- headers:
- Protocol/Legacy8259.h
which extends the list of resources scheduled for removal to:
- GUIDs (protocols or otherwise):
- gEfiLegacy8259ProtocolGuid
- headers:
- Protocol/Legacy8259.h
Cc: Ard Biesheuvel <[email protected]>
Cc: Gerd Hoffmann <[email protected]>
Cc: Jiewen Yao <[email protected]>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4588
Signed-off-by: Laszlo Ersek <[email protected]>
Message-Id: <[email protected]>
Reviewed-by: Jiewen Yao <[email protected]>
Reviewed-by: Ard Biesheuvel <[email protected]>
Acked-by: Corvin Köhne <[email protected]>
Acked-by: Gerd Hoffmann <[email protected]>
Commit: fb5c153abddaf70133f4b8d217552214387517ea
https://github.com/tianocore/edk2/commit/fb5c153abddaf70133f4b8d217552214387517ea
Author: Laszlo Ersek <[email protected]>
Date: 2023-12-07 (Thu, 07 Dec 2023)
Changed paths:
M OvmfPkg/OvmfPkgIa32.dsc
M OvmfPkg/OvmfPkgIa32.fdf
M OvmfPkg/OvmfPkgIa32X64.dsc
M OvmfPkg/OvmfPkgIa32X64.fdf
M OvmfPkg/OvmfPkgX64.dsc
M OvmfPkg/OvmfPkgX64.fdf
Log Message:
-----------
OvmfPkg: exclude 8259InterruptControllerDxe
With 8254TimerDxe gone, no module in OVMF consumes
gEfiLegacy8259ProtocolGuid; exclude 8259InterruptControllerDxe therefore.
Cc: Ard Biesheuvel <[email protected]>
Cc: Gerd Hoffmann <[email protected]>
Cc: Jiewen Yao <[email protected]>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4588
Signed-off-by: Laszlo Ersek <[email protected]>
Message-Id: <[email protected]>
Reviewed-by: Jiewen Yao <[email protected]>
Reviewed-by: Ard Biesheuvel <[email protected]>
Acked-by: Corvin Köhne <[email protected]>
Acked-by: Gerd Hoffmann <[email protected]>
Commit: 67864ffd52338b89458ccabb6339a23a16e2bd2e
https://github.com/tianocore/edk2/commit/67864ffd52338b89458ccabb6339a23a16e2bd2e
Author: Laszlo Ersek <[email protected]>
Date: 2023-12-07 (Thu, 07 Dec 2023)
Changed paths:
R OvmfPkg/8259InterruptControllerDxe/8259.c
R OvmfPkg/8259InterruptControllerDxe/8259.h
R OvmfPkg/8259InterruptControllerDxe/8259.inf
R OvmfPkg/8259InterruptControllerDxe/Legacy8259.uni
R OvmfPkg/8259InterruptControllerDxe/Legacy8259Extra.uni
Log Message:
-----------
OvmfPkg: remove 8259InterruptControllerDxe
8259InterruptControllerDxe is not used by any platforms at this point,
remove it.
This patch removes mentions of the following CSM resources from the source
code:
- GUIDs (protocols or otherwise):
- gEfiLegacy8259ProtocolGuid
- headers:
- Protocol/Legacy8259.h
- PCDs:
- Pcd8259LegacyModeEdgeLevel
- Pcd8259LegacyModeMask
which extends the list of resources scheduled for removal to:
- GUIDs (protocols or otherwise):
- gEfiLegacy8259ProtocolGuid
- headers:
- Protocol/Legacy8259.h
- PCDs:
- Pcd8259LegacyModeEdgeLevel
- Pcd8259LegacyModeMask
Cc: Ard Biesheuvel <[email protected]>
Cc: Gerd Hoffmann <[email protected]>
Cc: Jiewen Yao <[email protected]>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4588
Signed-off-by: Laszlo Ersek <[email protected]>
Message-Id: <[email protected]>
Reviewed-by: Jiewen Yao <[email protected]>
Reviewed-by: Ard Biesheuvel <[email protected]>
Acked-by: Corvin Köhne <[email protected]>
Acked-by: Gerd Hoffmann <[email protected]>
Commit: cf9030f69faf6a82d3a913e9e2055fd56461e0fd
https://github.com/tianocore/edk2/commit/cf9030f69faf6a82d3a913e9e2055fd56461e0fd
Author: Laszlo Ersek <[email protected]>
Date: 2023-12-07 (Thu, 07 Dec 2023)
Changed paths:
R OvmfPkg/Include/Protocol/Legacy8259.h
M OvmfPkg/OvmfPkg.dec
Log Message:
-----------
OvmfPkg: remove gEfiLegacy8259ProtocolGuid
At this point, gEfiLegacy8259ProtocolGuid is unused; remove it.
This shrinks the list of resources scheduled for removal to:
- PCDs:
- Pcd8259LegacyModeEdgeLevel
- Pcd8259LegacyModeMask
Cc: Ard Biesheuvel <[email protected]>
Cc: Gerd Hoffmann <[email protected]>
Cc: Jiewen Yao <[email protected]>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4588
Signed-off-by: Laszlo Ersek <[email protected]>
Message-Id: <[email protected]>
Reviewed-by: Jiewen Yao <[email protected]>
Reviewed-by: Ard Biesheuvel <[email protected]>
Acked-by: Corvin Köhne <[email protected]>
Acked-by: Gerd Hoffmann <[email protected]>
Commit: 605248f0fd230c781e2860ee41d5f366d8bec39c
https://github.com/tianocore/edk2/commit/605248f0fd230c781e2860ee41d5f366d8bec39c
Author: Laszlo Ersek <[email protected]>
Date: 2023-12-07 (Thu, 07 Dec 2023)
Changed paths:
M OvmfPkg/AmdSev/AmdSevX64.dsc
M OvmfPkg/IntelTdx/IntelTdxX64.dsc
M OvmfPkg/Microvm/MicrovmX64.dsc
M OvmfPkg/OvmfPkg.dec
M OvmfPkg/OvmfPkgIa32.dsc
M OvmfPkg/OvmfPkgIa32X64.dsc
M OvmfPkg/OvmfPkgX64.dsc
M OvmfPkg/OvmfXen.dsc
Log Message:
-----------
OvmfPkg: remove Pcd8259LegacyModeEdgeLevel and Pcd8259LegacyModeMask
The following PCDs are unused at this point; remove them:
- Pcd8259LegacyModeEdgeLevel
- Pcd8259LegacyModeMask
This shrinks the list of resources scheduled for removal to nil.
Cc: Anthony Perard <[email protected]>
Cc: Ard Biesheuvel <[email protected]>
Cc: Erdem Aktas <[email protected]>
Cc: Gerd Hoffmann <[email protected]>
Cc: Jiewen Yao <[email protected]>
Cc: Michael Roth <[email protected]>
Cc: Min Xu <[email protected]>
Cc: Tom Lendacky <[email protected]>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4588
Signed-off-by: Laszlo Ersek <[email protected]>
Message-Id: <[email protected]>
Reviewed-by: Jiewen Yao <[email protected]>
Reviewed-by: Ard Biesheuvel <[email protected]>
Acked-by: Corvin Köhne <[email protected]>
Acked-by: Gerd Hoffmann <[email protected]>
Commit: eccdab611c01aa40b6cefcfbcb4d23e54b4c0ec6
https://github.com/tianocore/edk2/commit/eccdab611c01aa40b6cefcfbcb4d23e54b4c0ec6
Author: Laszlo Ersek <[email protected]>
Date: 2023-12-07 (Thu, 07 Dec 2023)
Changed paths:
M OvmfPkg/Bhyve/BhyveX64.dsc
M OvmfPkg/IntelTdx/IntelTdxX64.dsc
M OvmfPkg/OvmfPkgIa32.dsc
M OvmfPkg/OvmfPkgIa32X64.dsc
M OvmfPkg/OvmfPkgX64.dsc
M OvmfPkg/OvmfXen.dsc
Log Message:
-----------
OvmfPkg: remove CSM_ENABLE build macro
At this point, the CSM_ENABLE conditionals only bracket the !error
directives that we added at the front of this series; it's time to remove
CSM_ENABLE.
Cc: Anthony Perard <[email protected]>
Cc: Ard Biesheuvel <[email protected]>
Cc: Corvin Köhne <[email protected]>
Cc: Gerd Hoffmann <[email protected]>
Cc: Jiewen Yao <[email protected]>
Cc: Rebecca Cran <[email protected]>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4588
Signed-off-by: Laszlo Ersek <[email protected]>
Message-Id: <[email protected]>
Reviewed-by: Jiewen Yao <[email protected]>
Reviewed-by: Ard Biesheuvel <[email protected]>
Acked-by: Corvin Köhne <[email protected]>
Acked-by: Gerd Hoffmann <[email protected]>
Compare: https://github.com/tianocore/edk2/compare/238690a30d02...eccdab611c01
_______________________________________________
edk2-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-commits
