Branch: refs/heads/master Home: https://github.com/tianocore/edk2 Commit: 59b4b5017c394a720cb98ce135a67d41791b4d2f https://github.com/tianocore/edk2/commit/59b4b5017c394a720cb98ce135a67d41791b4d2f Author: Mike Maslenkin <mike.maslen...@gmail.com> Date: 2023-12-27 (Wed, 27 Dec 2023)
Changed paths: M RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInterfaceBmcUsbNicLib.inf Log Message: ----------- RedfishPkg: fix RedfishPlatformHostInterfaceLib library class name typo. PlatformHostInterfaceBmcUsbNicLib is the library instance name not the class name. Cc: Nickle Wang <nick...@nvidia.com> Cc: Igor Kulchytskyy <ig...@ami.com> Signed-off-by: Mike Maslenkin <mike.maslen...@gmail.com> Reviewed-by: Abner Chang <abner.ch...@amd.com> Commit: 4fdd5165c15340c40829f766bc0e85b0124cce64 https://github.com/tianocore/edk2/commit/4fdd5165c15340c40829f766bc0e85b0124cce64 Author: Mike Maslenkin <mike.maslen...@gmail.com> Date: 2023-12-27 (Wed, 27 Dec 2023) Changed paths: M RedfishPkg/Library/RedfishPlatformCredentialIpmiLib/RedfishPlatformCredentialIpmiLib.inf Log Message: ----------- RedfishPkg: fix RedfishPlatformCredentialLib library class name typo. RedfishPlatformCredentialIpmiLib is the library instance name not the class name. Cc: Nickle Wang <nick...@nvidia.com> Cc: Igor Kulchytskyy <ig...@ami.com> Signed-off-by: Mike Maslenkin <mike.maslen...@gmail.com> Reviewed-by: Abner Chang <abner.ch...@amd.com> Commit: 0f66c2e687fd789c36ad8f9939449954482bfd21 https://github.com/tianocore/edk2/commit/0f66c2e687fd789c36ad8f9939449954482bfd21 Author: Mike Maslenkin <mike.maslen...@gmail.com> Date: 2023-12-27 (Wed, 27 Dec 2023) Changed paths: M RedfishPkg/Include/Library/RedfishCrtLib.h Log Message: ----------- RedfishPkg: get rid of unused definitions from RedfishCrtLib.h It seems that initial implementation of this header file is based on CrtLibSupport.h from CryptoPkg. But uid, euid, gid, egid and sa_family_t sre not used in RedfishPkg. So remove them. Also take "true" and "false" definition from MdePkg's LibFdtSupport.h header file, that also seems based on a header mentioned above. Cc: Nickle Wang <nick...@nvidia.com> Cc: Igor Kulchytskyy <ig...@ami.com> Signed-off-by: Mike Maslenkin <mike.maslen...@gmail.com> Reviewed-by: Abner Chang <abner.ch...@amd.com> Commit: d81813368a66c1b27f58ecc68e75d1bc850a3e96 https://github.com/tianocore/edk2/commit/d81813368a66c1b27f58ecc68e75d1bc850a3e96 Author: Mike Maslenkin <mike.maslen...@gmail.com> Date: 2023-12-27 (Wed, 27 Dec 2023) Changed paths: M RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c Log Message: ----------- RedfishPkg: RedfishPlatformConfigDxe: reduce memory allocations It's unclear why the new string is allocated as copy of the original string if its pointer is stored in an array and the original string is released immediately after the copy is created. All data allocated in the same pool. Cc: Nickle Wang <nick...@nvidia.com> Cc: Igor Kulchytskyy <ig...@ami.com> Signed-off-by: Mike Maslenkin <mike.maslen...@gmail.com> Reviewed-by: Abner Chang <abner.ch...@amd.com> Commit: a87e8505b1509fb00bc586b7e00c884487c4298d https://github.com/tianocore/edk2/commit/a87e8505b1509fb00bc586b7e00c884487c4298d Author: Mike Maslenkin <mike.maslen...@gmail.com> Date: 2023-12-27 (Wed, 27 Dec 2023) Changed paths: M RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c Log Message: ----------- RedfishPkg: RedfishDiscoverDxe: fix memory leak on error path. Cc: Nickle Wang <nick...@nvidia.com> Cc: Igor Kulchytskyy <ig...@ami.com> Signed-off-by: Mike Maslenkin <mike.maslen...@gmail.com> Reviewed-by: Abner Chang <abner.ch...@amd.com> Commit: 8b59cb79fa4fe704671d1bea70abd89847a1e33f https://github.com/tianocore/edk2/commit/8b59cb79fa4fe704671d1bea70abd89847a1e33f Author: Mike Maslenkin <mike.maslen...@gmail.com> Date: 2023-12-27 (Wed, 27 Dec 2023) Changed paths: A RedfishPkg/RedfishConfigHandler/ComponentName.c M RedfishPkg/RedfishConfigHandler/RedfishConfigHandlerDriver.c M RedfishPkg/RedfishConfigHandler/RedfishConfigHandlerDriver.h M RedfishPkg/RedfishConfigHandler/RedfishConfigHandlerDriver.inf Log Message: ----------- RedfishPkg: add Component Name protocols to RedfishConfigHandler driver Currently there is no description for RedfishConfigHandler driver. This leads to <null string> in the "DRIVER NAME" column of a `drivers` command for example. Cc: Nickle Wang <nick...@nvidia.com> Cc: Igor Kulchytskyy <ig...@ami.com> Signed-off-by: Mike Maslenkin <mike.maslen...@gmail.com> Reviewed-by: Abner Chang <abner.ch...@amd.com> Commit: 24de462a9d931de89426ead8524952e3a2816633 https://github.com/tianocore/edk2/commit/24de462a9d931de89426ead8524952e3a2816633 Author: Mike Maslenkin <mike.maslen...@gmail.com> Date: 2023-12-27 (Wed, 27 Dec 2023) Changed paths: M RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInterfaceBmcUsbNicLib.c Log Message: ----------- RedfishPkg: add proper initialization of IPMI request All fields of IPMI_CHANNEL_INFO_CHANNEL_NUMBER union must be initialized to avoid error condition on BMC side. Cc: Nickle Wang <nick...@nvidia.com> Cc: Igor Kulchytskyy <ig...@ami.com> Signed-off-by: Mike Maslenkin <mike.maslen...@gmail.com> Reviewed-by: Abner Chang <abner.ch...@amd.com> Commit: 5e2338d3df0c4e837489a9f45419c5c67152a5ad https://github.com/tianocore/edk2/commit/5e2338d3df0c4e837489a9f45419c5c67152a5ad Author: Mike Maslenkin <mike.maslen...@gmail.com> Date: 2023-12-27 (Wed, 27 Dec 2023) Changed paths: M EmulatorPkg/EmulatorPkg.dec M EmulatorPkg/Library/RedfishPlatformCredentialLib/RedfishPlatformCredentialLib.c M EmulatorPkg/Library/RedfishPlatformCredentialLib/RedfishPlatformCredentialLib.inf Log Message: ----------- EmulatorPkg: fix typo. PcdRedfishServie -> PcdRedfishService Cc: Nickle Wang <nick...@nvidia.com> Signed-off-by: Mike Maslenkin <mike.maslen...@gmail.com> Reviewed-by: Abner Chang <abner.ch...@amd.com> Commit: 9e3de4eee0ab45c2584e7cee931cd1ea598a6c3f https://github.com/tianocore/edk2/commit/9e3de4eee0ab45c2584e7cee931cd1ea598a6c3f Author: Mike Maslenkin <mike.maslen...@gmail.com> Date: 2023-12-27 (Wed, 27 Dec 2023) Changed paths: M EmulatorPkg/Library/RedfishPlatformHostInterfaceLib/RedfishPlatformHostInterfaceLib.c Log Message: ----------- EmulatorPkg: RedfishPlatformHostInterfaceLib: get rid of unused variable Cc: Nickle Wang <nick...@nvidia.com> Signed-off-by: Mike Maslenkin <mike.maslen...@gmail.com> Reviewed-by: Abner Chang <abner.ch...@amd.com> Commit: 2cd1b439d77b05b94fe174cc83afc0d1f03eafde https://github.com/tianocore/edk2/commit/2cd1b439d77b05b94fe174cc83afc0d1f03eafde Author: Mike Maslenkin <mike.maslen...@gmail.com> Date: 2023-12-27 (Wed, 27 Dec 2023) Changed paths: M RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c Log Message: ----------- RedfishDiscoverDxe: introduce InitInformationData helper function Cc: Nickle Wang <nick...@nvidia.com> Cc: Igor Kulchytskyy <ig...@ami.com> Signed-off-by: Mike Maslenkin <mike.maslen...@gmail.com> Reviewed-by: Abner Chang <abner.ch...@amd.com> Commit: 17870bf3f5f9440bd860e15f1f500d5a5b9e0b7d https://github.com/tianocore/edk2/commit/17870bf3f5f9440bd860e15f1f500d5a5b9e0b7d Author: Mike Maslenkin <mike.maslen...@gmail.com> Date: 2023-12-27 (Wed, 27 Dec 2023) Changed paths: M RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c Log Message: ----------- RedfishDiscoverDxe: refine InitInformationData(), remove unnecessary casts Cc: Nickle Wang <nick...@nvidia.com> Cc: Igor Kulchytskyy <ig...@ami.com> Cc: Pedro Falcato <pedro.falc...@gmail.com> Signed-off-by: Mike Maslenkin <mike.maslen...@gmail.com> Reviewed-by: Abner Chang <abner.ch...@amd.com> Commit: d1c21f8d557f01cd82e06d6b9b6900dec8e6b373 https://github.com/tianocore/edk2/commit/d1c21f8d557f01cd82e06d6b9b6900dec8e6b373 Author: Mike Maslenkin <mike.maslen...@gmail.com> Date: 2023-12-27 (Wed, 27 Dec 2023) Changed paths: M RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c Log Message: ----------- RedfishDiscoverDxe: refine InitInformationData() function Cache size of ASCII string in local variable. Cc: Nickle Wang <nick...@nvidia.com> Cc: Igor Kulchytskyy <ig...@ami.com> Signed-off-by: Mike Maslenkin <mike.maslen...@gmail.com> Reviewed-by: Abner Chang <abner.ch...@amd.com> Commit: f8de39afab5358c05938e89f8f9a1c389dd8e88f https://github.com/tianocore/edk2/commit/f8de39afab5358c05938e89f8f9a1c389dd8e88f Author: Mike Maslenkin <mike.maslen...@gmail.com> Date: 2023-12-27 (Wed, 27 Dec 2023) Changed paths: M RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c Log Message: ----------- RedfishDiscoverDxe: add a helper function deallocating string resources. This patch adds a handy helper function deallocating resources from the EFI_REDFISH_DISCOVERED_INFORMATION structure instance. Cc: Nickle Wang <nick...@nvidia.com> Cc: Igor Kulchytskyy <ig...@ami.com> Signed-off-by: Mike Maslenkin <mike.maslen...@gmail.com> Reviewed-by: Abner Chang <abner.ch...@amd.com> Commit: 139887a98988e1169de64a3ac6f29cfebbf88a42 https://github.com/tianocore/edk2/commit/139887a98988e1169de64a3ac6f29cfebbf88a42 Author: Mike Maslenkin <mike.maslen...@gmail.com> Date: 2023-12-27 (Wed, 27 Dec 2023) Changed paths: M RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c Log Message: ----------- RedfishDiscoverDxe: release resources when refreshing information data It is required to free previously allocated strings stored in DiscoveredInstance->Information structure. Cc: Nickle Wang <nick...@nvidia.com> Cc: Igor Kulchytskyy <ig...@ami.com> Signed-off-by: Mike Maslenkin <mike.maslen...@gmail.com> Reviewed-by: Abner Chang <abner.ch...@amd.com> Commit: 91f1ce4e27649e8e6911a505539b137302f1b02d https://github.com/tianocore/edk2/commit/91f1ce4e27649e8e6911a505539b137302f1b02d Author: Mike Maslenkin <mike.maslen...@gmail.com> Date: 2023-12-27 (Wed, 27 Dec 2023) Changed paths: M RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c Log Message: ----------- RedfishDiscoverDxe: handle memory allocation error conditions. REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4625 Cc: Nickle Wang <nick...@nvidia.com> Cc: Igor Kulchytskyy <ig...@ami.com> Signed-off-by: Mike Maslenkin <mike.maslen...@gmail.com> Reviewed-by: Abner Chang <abner.ch...@amd.com> Commit: d7d4f09ff815794761f84d06e307001afe6376c4 https://github.com/tianocore/edk2/commit/d7d4f09ff815794761f84d06e307001afe6376c4 Author: Mike Maslenkin <mike.maslen...@gmail.com> Date: 2023-12-27 (Wed, 27 Dec 2023) Changed paths: M RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c Log Message: ----------- RedfishPkg: RedfishDiscoverDxe: add [] brackets to URI for IPv6 addresses URI is generated based on the RedfishLocation containing an ASCII string representing the IP address. So, in the case of IPv4 the canonical representation of an IPv4 address was inserted into the resulting Unicode string i.e: "http{,s}://X.X.X.X/". In the case of IPv6, to access resources, the IP address must be specified in brackets, i.e. the resulting string should look like: "http{,s}://[X::X:X:X:X]/". Cc: Nickle Wang <nick...@nvidia.com> Cc: Igor Kulchytskyy <ig...@ami.com> Signed-off-by: Mike Maslenkin <mike.maslen...@gmail.com> Reviewed-by: Abner Chang <abner.ch...@amd.com> Compare: https://github.com/tianocore/edk2/compare/58d946393908...d7d4f09ff815 _______________________________________________ edk2-commits mailing list edk2-commits@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-commits