Branch: refs/heads/master
Home: https://github.com/tianocore/edk2
Commit: 3114fd8ed7ce38464572839fe295aca11d704b7d
https://github.com/tianocore/edk2/commit/3114fd8ed7ce38464572839fe295aca11d704b7d
Author: Nate DeSimone <[email protected]>
Date: 2024-01-05 (Fri, 05 Jan 2024)
Changed paths:
M EmulatorPkg/Win/Host/WinThunk.c
Log Message:
-----------
EmulatorPkg: Improve comments in WinThunk.c
File description has not been updated since Nt32Pkg was merged
with EmulatorPkg, and several details were no longer technically accurate.
Cc: Andrew Fish <[email protected]>
Reviewed-by: Ray Ni <[email protected]>
Cc: Michael D Kinney <[email protected]>
Cc: Chasel Chiu <[email protected]>
Signed-off-by: Nate DeSimone <[email protected]>
Commit: 5a2490df0e6753928a1322436a96e01ffb000f3a
https://github.com/tianocore/edk2/commit/5a2490df0e6753928a1322436a96e01ffb000f3a
Author: Nate DeSimone <[email protected]>
Date: 2024-01-05 (Fri, 05 Jan 2024)
Changed paths:
M EmulatorPkg/Win/Host/WinThunk.c
Log Message:
-----------
EmulatorPkg: Update MMTimerThread() signature
In the early 2000s as part of the x64 transition the definition
for LPTIMECALLBACK changed from (UINT, UINT, DWORD, DWORD, DWORD)
to (UINT, UINT, DWORD_PTR, DWORD_PTR, DWORD_PTR). However,
the MMTimerThread() function was never updated to the new
signature. Since the implementation does not use the last three
parameters, this issue has not been caught until now.
Cc: Andrew Fish <[email protected]>
Reviewed-by: Ray Ni <[email protected]>
Cc: Michael D Kinney <[email protected]>
Signed-off-by: Nate DeSimone <[email protected]>
Commit: 9cf1d03ebe076b3e3825dfebbc19fd6b52b5f336
https://github.com/tianocore/edk2/commit/9cf1d03ebe076b3e3825dfebbc19fd6b52b5f336
Author: Nate DeSimone <[email protected]>
Date: 2024-01-05 (Fri, 05 Jan 2024)
Changed paths:
M EmulatorPkg/Include/Protocol/EmuThunk.h
M EmulatorPkg/Unix/Host/EmuThunk.c
Log Message:
-----------
Add EFI_STATUS return to EMU_THUNK_PROTOCOL.SetTime()
There is an inconsistency between the UNIX and Windows
implementations of EMU_THUNK_PROTOCOL.SetTime(). The Windows
version returns an EFI_STATUS value whereas the the UNIX
implementation is VOID. However, the UNIX implementation is an
unimplemented stub whereas the Windows version is implementated.
The current EMU_THUNK_PROTOCOL function pointer definition
specifies a VOID return type. However, EMU_THUNK_PROTOCOL.SetTime()
is close to the spec defined gRT->SetTime() except for missing the
EFI_STATUS return type.
Therefore, I conclude that the most sensible reconciliation is to
add the EFI_STATUS return type to the protocol definition.
Cc: Andrew Fish <[email protected]>
Reviewed-by: Ray Ni <[email protected]>
Cc: Michael D Kinney <[email protected]>
Cc: Chasel Chiu <[email protected]>
Signed-off-by: Nate DeSimone <[email protected]>
Compare: https://github.com/tianocore/edk2/compare/e8166a852e63...9cf1d03ebe07
_______________________________________________
edk2-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-commits
