Branch: refs/heads/master
  Home:   https://github.com/tianocore/edk2
  Commit: 0395045ae307c43a41f72ca9a8bf4eb8f16b2fe0
      
https://github.com/tianocore/edk2/commit/0395045ae307c43a41f72ca9a8bf4eb8f16b2fe0
  Author: Gerd Hoffmann <[email protected]>
  Date:   2024-01-18 (Thu, 18 Jan 2024)

  Changed paths:
    M OvmfPkg/VirtNorFlashDxe/VirtNorFlash.c
    M OvmfPkg/VirtNorFlashDxe/VirtNorFlash.h

  Log Message:
  -----------
  OvmfPkg/VirtNorFlashDxe: add casts to UINTN and UINT32

This is needed to avoid bit operations being applied to signed integers.

Suggested-by: László Érsek <[email protected]>
Signed-off-by: Gerd Hoffmann <[email protected]>
Reviewed-by: Laszlo Ersek <[email protected]>
Message-Id: <[email protected]>


  Commit: 35d8ea8097794b522149688b5cfaf8364bc44d54
      
https://github.com/tianocore/edk2/commit/35d8ea8097794b522149688b5cfaf8364bc44d54
  Author: Gerd Hoffmann <[email protected]>
  Date:   2024-01-18 (Thu, 18 Jan 2024)

  Changed paths:
    M OvmfPkg/VirtNorFlashDxe/VirtNorFlash.c

  Log Message:
  -----------
  OvmfPkg/VirtNorFlashDxe: clarify block write logic & fix shadowbuffer reads

Introduce 'Start' and 'End' variables to make it easier to follow the
logic and code flow.  Also add a ascii art diagram (based on a
suggestion by Laszlo).

This also fixes the 'Size' calculation for the NorFlashRead() call.
Without this patch the code will read only one instead of two
P30_MAX_BUFFER_SIZE_IN_BYTES blocks in case '*NumBytes' is smaller than
P30_MAX_BUFFER_SIZE_IN_BYTES but 'Offset + *NumBytes' is not, i.e. the
update range crosses a P30_MAX_BUFFER_SIZE_IN_BYTES boundary.

Signed-off-by: Gerd Hoffmann <[email protected]>
Reviewed-by: Laszlo Ersek <[email protected]>
Message-Id: <[email protected]>


  Commit: 28ffd726894f11a587a6ac7f71a4c4af341e24d2
      
https://github.com/tianocore/edk2/commit/28ffd726894f11a587a6ac7f71a4c4af341e24d2
  Author: Gerd Hoffmann <[email protected]>
  Date:   2024-01-18 (Thu, 18 Jan 2024)

  Changed paths:
    M OvmfPkg/VirtNorFlashDxe/VirtNorFlash.c

  Log Message:
  -----------
  OvmfPkg/VirtNorFlashDxe: add a loop for NorFlashWriteBuffer calls.

Replace the two NorFlashWriteBuffer() calls with a loop containing a
single NorFlashWriteBuffer() call.

With the changes in place the code is able to handle updates larger
than two P30_MAX_BUFFER_SIZE_IN_BYTES blocks, even though the patch
does not actually change the size limit.

Signed-off-by: Gerd Hoffmann <[email protected]>
Reviewed-by: Laszlo Ersek <[email protected]>
Message-Id: <[email protected]>


  Commit: b25733c97442513890ae6bb8e10fd340f13844a7
      
https://github.com/tianocore/edk2/commit/b25733c97442513890ae6bb8e10fd340f13844a7
  Author: Gerd Hoffmann <[email protected]>
  Date:   2024-01-18 (Thu, 18 Jan 2024)

  Changed paths:
    M OvmfPkg/VirtNorFlashDxe/VirtNorFlash.c

  Log Message:
  -----------
  OvmfPkg/VirtNorFlashDxe: allow larger writes without block erase

Raise the limit for writes without block erase from two to four
P30_MAX_BUFFER_SIZE_IN_BYTES blocks.  With this in place almost all efi
variable updates are handled without block erase.  With the old limit
some variable updates (with device paths) took the block erase code
path.

Signed-off-by: Gerd Hoffmann <[email protected]>
Reviewed-by: Laszlo Ersek <[email protected]>
Message-Id: <[email protected]>


  Commit: 735d0a5e2e25c1577bf9bea7826da937ca38169d
      
https://github.com/tianocore/edk2/commit/735d0a5e2e25c1577bf9bea7826da937ca38169d
  Author: Gerd Hoffmann <[email protected]>
  Date:   2024-01-18 (Thu, 18 Jan 2024)

  Changed paths:
    M OvmfPkg/VirtNorFlashDxe/VirtNorFlashFvb.c

  Log Message:
  -----------
  OvmfPkg/VirtNorFlashDxe: ValidateFvHeader: unwritten state is EOL too

It is possible to find variable entries with State being 0xff, i.e. not
updated since flash block erase.   This indicates the variable driver
could not complete the header write while appending a new entry, and
therefore State was not set to VAR_HEADER_VALID_ONLY.

This can only happen at the end of the variable list, so treat this as
additional "end of variable list" condition.

Signed-off-by: Gerd Hoffmann <[email protected]>
Reviewed-by: Laszlo Ersek <[email protected]>
Message-Id: <[email protected]>


  Commit: b481b00f593ef37695ee14271453320ed02a1256
      
https://github.com/tianocore/edk2/commit/b481b00f593ef37695ee14271453320ed02a1256
  Author: Gerd Hoffmann <[email protected]>
  Date:   2024-01-18 (Thu, 18 Jan 2024)

  Changed paths:
    M OvmfPkg/VirtNorFlashDxe/VirtNorFlash.c

  Log Message:
  -----------
  OvmfPkg/VirtNorFlashDxe: move DoErase code block into new function

Move the DoErase code block into a separate function, call the function
instead of jumping around with goto.

Signed-off-by: Gerd Hoffmann <[email protected]>
Message-Id: <[email protected]>
Reviewed-by: Laszlo Ersek <[email protected]>


  Commit: 40adbb7f628dee79156c679fb0857968b61b7620
      
https://github.com/tianocore/edk2/commit/40adbb7f628dee79156c679fb0857968b61b7620
  Author: Doug Flick <[email protected]>
  Date:   2024-01-18 (Thu, 18 Jan 2024)

  Changed paths:
    M SecurityPkg/Library/DxeTpm2MeasureBootLib/DxeTpm2MeasureBootLib.c
    M 
SecurityPkg/Library/DxeTpm2MeasureBootLib/DxeTpm2MeasureBootLibSanitization.c
    M 
SecurityPkg/Library/DxeTpm2MeasureBootLib/DxeTpm2MeasureBootLibSanitization.h
    M 
SecurityPkg/Library/DxeTpm2MeasureBootLib/InternalUnitTest/DxeTpm2MeasureBootLibSanitizationTest.c

  Log Message:
  -----------
  SecurityPkg: DxeTpm2MeasureBootLib: SECURITY PATCH 4117/4118 symbol rename

Updates the sanitation function names to be lib unique names

Cc: Jiewen Yao <[email protected]>
Cc: Rahul Kumar <[email protected]>

Signed-off-by: Doug Flick [MSFT] <[email protected]>
Message-Id: 
<7b18434c8a8b561654efd40ced3becb8b378c8f1.1705529990.git.doug.e...@gmail.com>
Reviewed-by: Jiewen Yao <[email protected]>


  Commit: 326db0c9072004dea89427ea3a44393a84966f2b
      
https://github.com/tianocore/edk2/commit/326db0c9072004dea89427ea3a44393a84966f2b
  Author: Doug Flick <[email protected]>
  Date:   2024-01-18 (Thu, 18 Jan 2024)

  Changed paths:
    M SecurityPkg/Library/DxeTpmMeasureBootLib/DxeTpmMeasureBootLib.c
    M 
SecurityPkg/Library/DxeTpmMeasureBootLib/DxeTpmMeasureBootLibSanitization.c
    M 
SecurityPkg/Library/DxeTpmMeasureBootLib/DxeTpmMeasureBootLibSanitization.h
    M 
SecurityPkg/Library/DxeTpmMeasureBootLib/InternalUnitTest/DxeTpmMeasureBootLibSanitizationTest.c

  Log Message:
  -----------
  SecurityPkg: DxeTpmMeasureBootLib: SECURITY PATCH 4117/4118 symbol rename

Updates the sanitation function names to be lib unique names

Cc: Jiewen Yao <[email protected]>
Cc: Rahul Kumar <[email protected]>

Signed-off-by: Doug Flick [MSFT] <[email protected]>
Message-Id: 
<355aa846a99ca6ac0f7574cf5982661da0d9fea6.1705529990.git.doug.e...@gmail.com>
Reviewed-by: Jiewen Yao <[email protected]>


  Commit: 264636d8e6983e0f6dc6be2fca9d84ec81315954
      
https://github.com/tianocore/edk2/commit/264636d8e6983e0f6dc6be2fca9d84ec81315954
  Author: Doug Flick <[email protected]>
  Date:   2024-01-18 (Thu, 18 Jan 2024)

  Changed paths:
    M SecurityPkg/SecurityFixes.yaml

  Log Message:
  -----------
  SecurityPkg: : Updating SecurityFixes.yaml after symbol rename

Adding the new commit titles for the symbol renames

Cc: Jiewen Yao <[email protected]>
Cc: Rahul Kumar <[email protected]>

Signed-off-by: Doug Flick [MSFT] <[email protected]>
Message-Id: 
<5e0e851e97459e183420178888d4fcdadc2f1ae1.1705529990.git.doug.e...@gmail.com>
Reviewed-by: Jiewen Yao <[email protected]>


Compare: https://github.com/tianocore/edk2/compare/59f024c76ee5...264636d8e698


_______________________________________________
edk2-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-commits

Reply via email to