Branch: refs/heads/master
Home: https://github.com/tianocore/edk2
Commit: dae8c29dab546fad2801e70967855a9f6ae14ae0
https://github.com/tianocore/edk2/commit/dae8c29dab546fad2801e70967855a9f6ae14ae0
Author: Michael D Kinney <[email protected]>
Date: 2024-02-27 (Tue, 27 Feb 2024)
Changed paths:
M BaseTools/Scripts/PatchCheck.py
Log Message:
-----------
BaseTools/Scripts/PatchCheck: Update Author checks
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4680
* Reject patches that match Author email "[email protected]"
* Update the current check for " via Groups.Io" to perform a
case insensitive match. It appears that groups.io has changed the
format of this string to use all lower case.
Cc: Rebecca Cran <[email protected]>
Cc: Liming Gao <[email protected]>
Cc: Bob Feng <[email protected]>
Cc: Yuwei Chen <[email protected]>
Signed-off-by: Michael D Kinney <[email protected]>
Reviewed-by: Rebecca Cran <[email protected]>
Reviewed-by: Ard Biesheuvel <[email protected]>
Commit: 45ad13bb6445e18e339311962dc7eaedb8df1d6c
https://github.com/tianocore/edk2/commit/45ad13bb6445e18e339311962dc7eaedb8df1d6c
Author: Michael D Kinney <[email protected]>
Date: 2024-02-27 (Tue, 27 Feb 2024)
Changed paths:
M BaseTools/Scripts/PatchCheck.py
Log Message:
-----------
BaseTools/Scripts/PatchCheck: Return CommitMessageCheck errors
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4693
Commit signatures are checked and error messages are logged but
errors are not captured and returned from find_signatures() in the
CommitMessageCheck class. This causes signature errors to be
silently ignored by CI.
Update logic in CommitMessageCheck class to return errors
detected in commit message signatures.
Cc: Rebecca Cran <[email protected]>
Cc: Liming Gao <[email protected]>
Cc: Bob Feng <[email protected]>
Cc: Yuwei Chen <[email protected]>
Cc: Michael Kubacki <[email protected]>
Signed-off-by: Michael D Kinney <[email protected]>
Reviewed-by: Michael Kubacki <[email protected]>
Reviewed-by: Rebecca Cran <[email protected]>
Commit: 0bbec15b549032f239f0b05a725598f719d74325
https://github.com/tianocore/edk2/commit/0bbec15b549032f239f0b05a725598f719d74325
Author: Michael D Kinney <[email protected]>
Date: 2024-02-27 (Tue, 27 Feb 2024)
Changed paths:
M BaseTools/Scripts/PatchCheck.py
Log Message:
-----------
BaseTools/Scripts/PatchCheck: Error if no Cc tags are present
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4694
If no Cc tags are detected in a commit message, then generate an
error. All patches sent for review are required to provide the set
of maintainers and reviewers responsible for the directories/files
modified. The set of maintainers and reviewers are documented in
Maintainers.txt and can be retrieved using the script
BaseTools/Scripts/GetMaintainer.py.
Cc: Rebecca Cran <[email protected]>
Cc: Liming Gao <[email protected]>
Cc: Bob Feng <[email protected]>
Cc: Yuwei Chen <[email protected]>
Cc: Michael Kubacki <[email protected]>
Signed-off-by: Michael D Kinney <[email protected]>
Reviewed-by: Michael Kubacki <[email protected]>
Reviewed-by: Rebecca Cran <[email protected]>
Commit: 6d571c0070161b1b96049410f8584c0955d73536
https://github.com/tianocore/edk2/commit/6d571c0070161b1b96049410f8584c0955d73536
Author: Michael D Kinney <[email protected]>
Date: 2024-02-27 (Tue, 27 Feb 2024)
Changed paths:
M BaseTools/Scripts/PatchCheck.py
Log Message:
-----------
BaseTools/Scripts/PatchCheck: Error if commit modifies multiple packages
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4679
Update PatchCheck.py to evaluate all the files modified in each commit
and generate an error if:
* A commit adds/modifies files in multiple package directories
* A commit adds/modifies files in multiple non-package directories
* A commit adds/modifies files in both a package and a non-package
directory
* A commit deletes files from multiple package directories
* A commit deletes files from multiple non-package directories
* A commit deletes files from both a package and a non-package
directory
Modifications to files in the root of the repository are not
evaluated.
This check is skipped if PatchCheck.py is run on a patch file or
input from stdin because this multiple package commit check depends
on information from a git repository.
If --ignore-multi-package option is set, then reduce the multiple
package commit check from an error to a warning for all commits in
the commit range provided to PatchCheck.py.
Add check for a 'Continuous-integration-options:' commit message
tag that allows one or more options to be specified at the individual
commit scope to enable/disable continuous integration checks. This
tag must start at the beginning of a commit message line and may
appear more than once in a commit message.
Add support for a Continuous-integration-options tag value of
'PatchCheck.ignore-multi-package' that reduces the multiple package
commit check from an error to a warning for the specific commits that
specify this option. Example:
Continuous-integration-options: PatchCheck.ignore-multi-package
The set of packages are found by searching for DEC files in a git
repository. The list of DEC files in a git repository is collected
with the following git command:
git ls-files *.dec
The set of files added/modified by each commit is found using the
following git command:
git diff-tree --no-commit-id --name-only --diff-filter=AM -r <commit>
The set of files deleted by each commit is found using the
following git command:
git diff-tree --no-commit-id --name-only --diff-filter=D -r <commit>
Cc: Rebecca Cran <[email protected]>
Cc: Liming Gao <[email protected]>
Cc: Bob Feng <[email protected]>
Cc: Yuwei Chen <[email protected]>
Cc: Michael Kubacki <[email protected]>
Cc: Ard Biesheuvel <[email protected]>
Cc: Leif Lindholm <[email protected]>
Signed-off-by: Michael D Kinney <[email protected]>
Reviewed-by: Michael Kubacki <[email protected]>
Reviewed-by: Rebecca Cran <[email protected]>
Compare: https://github.com/tianocore/edk2/compare/e59a40b92ce9...6d571c007016
To unsubscribe from these emails, change your notification settings at
https://github.com/tianocore/edk2/settings/notifications
_______________________________________________
edk2-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-commits
