Branch: refs/heads/master
  Home:   https://github.com/tianocore/edk2
  Commit: 31cd5ee8c0946b62520795bdbe81f886a8b81559
      
https://github.com/tianocore/edk2/commit/31cd5ee8c0946b62520795bdbe81f886a8b81559
  Author: Zhiguang Liu <[email protected]>
  Date:   2024-04-16 (Tue, 16 Apr 2024)

  Changed paths:
    M StandaloneMmPkg/Core/Mmi.c

  Log Message:
  -----------
  Revert 2ec8f0c6407f062441b205b900038933865c7b3c

This reverts commit "StandaloneMmPkg: Disallow unregister MMI
handler in other MMI handler" for better design later.

Cc: Liming Gao <[email protected]>
Cc: Jiaxin Wu <[email protected]>
Cc: Ray Ni <[email protected]>
Cc: Laszlo Ersek <[email protected]>
Reviewed-by: Ray Ni <[email protected]>
Cc: Laszlo Ersek <[email protected]>
Cc: Ard Biesheuvel <[email protected]>
Cc: Sami Mujawar <[email protected]>
Signed-off-by: Zhiguang Liu <[email protected]>


  Commit: de95e919bea2aba6dc56536a7d2849038e801d40
      
https://github.com/tianocore/edk2/commit/de95e919bea2aba6dc56536a7d2849038e801d40
  Author: Zhiguang Liu <[email protected]>
  Date:   2024-04-16 (Tue, 16 Apr 2024)

  Changed paths:
    M StandaloneMmPkg/Core/Mmi.c

  Log Message:
  -----------
  Revert 049ff6c39c73edd3709c05bd0e46184320471358

This reverts commit "StandaloneMmPkg: Support to unregister
MMI handler inside MMI handler" for better design later.

Cc: Liming Gao <[email protected]>
Cc: Jiaxin Wu <[email protected]>
Cc: Ray Ni <[email protected]>
Cc: Laszlo Ersek <[email protected]>
Reviewed-by: Ray Ni <[email protected]>
Cc: Laszlo Ersek <[email protected]>
Cc: Ard Biesheuvel <[email protected]>
Cc: Sami Mujawar <[email protected]>
Signed-off-by: Zhiguang Liu <[email protected]>


  Commit: b594fba4ec5e2a9730979060a24d29d9daaa7bbc
      
https://github.com/tianocore/edk2/commit/b594fba4ec5e2a9730979060a24d29d9daaa7bbc
  Author: Zhiguang Liu <[email protected]>
  Date:   2024-04-16 (Tue, 16 Apr 2024)

  Changed paths:
    M MdeModulePkg/Core/PiSmmCore/Smi.c

  Log Message:
  -----------
  Revert 17b28722008eab745ce186b72cd325944cbe6bf0

This reverts commit "MdeModulePkg/SMM: Disallow unregister
 SMI handler in other SMI handler" for better design later.

Cc: Liming Gao <[email protected]>
Cc: Jiaxin Wu <[email protected]>
Cc: Ray Ni <[email protected]>
Cc: Laszlo Ersek <[email protected]>
Reviewed-by: Ray Ni <[email protected]>
Cc: Laszlo Ersek <[email protected]>
Cc: Ard Biesheuvel <[email protected]>
Cc: Sami Mujawar <[email protected]>
Signed-off-by: Zhiguang Liu <[email protected]>


  Commit: da7858117f12846e5c35922e8917fd0da07dcfef
      
https://github.com/tianocore/edk2/commit/da7858117f12846e5c35922e8917fd0da07dcfef
  Author: Zhiguang Liu <[email protected]>
  Date:   2024-04-16 (Tue, 16 Apr 2024)

  Changed paths:
    M MdeModulePkg/Core/PiSmmCore/Smi.c

  Log Message:
  -----------
  Revert ae1079b386a597108a8070652bf7cdaa4ec3dda3

This reverts "MdeModulePkg/SMM: Support to unregister
SMI handler inside SMI handler" for better design later.

Cc: Liming Gao <[email protected]>
Cc: Jiaxin Wu <[email protected]>
Cc: Ray Ni <[email protected]>
Cc: Laszlo Ersek <[email protected]>
Reviewed-by: Ray Ni <[email protected]>
Cc: Laszlo Ersek <[email protected]>
Cc: Ard Biesheuvel <[email protected]>
Cc: Sami Mujawar <[email protected]>
Signed-off-by: Zhiguang Liu <[email protected]>


  Commit: 74f6ce67343f81a842e6af3c599e4ae2a07ee51b
      
https://github.com/tianocore/edk2/commit/74f6ce67343f81a842e6af3c599e4ae2a07ee51b
  Author: Zhiguang Liu <[email protected]>
  Date:   2024-04-16 (Tue, 16 Apr 2024)

  Changed paths:
    M MdeModulePkg/Core/PiSmmCore/PiSmmCore.h
    M MdeModulePkg/Core/PiSmmCore/Smi.c

  Log Message:
  -----------
  MdeModulePkg/SMM: Support to unregister SMI handler in SMI handlers

This patch fix a use-after-free issue where unregistering an
SMI handler could lead to the deletion of the SMI_HANDLER while it is
still in use by SmiManage(). The fix involves modifying
SmiHandlerUnRegister() to detect whether it is being called from
within the SmiManage() stack. If so, the removal of the SMI_HANDLER
is deferred until SmiManage() has finished executing.
Additionally, due to the possibility of recursive SmiManage() calls,
the unregistration and subsequent removal of the SMI_HANDLER are
ensured to occur only after the outermost SmiManage() invocation has
completed.

Cc: Liming Gao <[email protected]>
Cc: Jiaxin Wu <[email protected]>
Reviewed-by: Ray Ni <[email protected]>
Cc: Laszlo Ersek <[email protected]>

Signed-off-by: Zhiguang Liu <[email protected]>


  Commit: 70892b13b28cdb0a10c82f3d3aca560a38dce5c9
      
https://github.com/tianocore/edk2/commit/70892b13b28cdb0a10c82f3d3aca560a38dce5c9
  Author: Zhiguang Liu <[email protected]>
  Date:   2024-04-16 (Tue, 16 Apr 2024)

  Changed paths:
    M StandaloneMmPkg/Core/Mmi.c

  Log Message:
  -----------
  StandaloneMmPkg: Support to unregister MMI handler in MMI handlers

This patch fix a use-after-free issue where unregistering an
MMI handler could lead to the deletion of the MMI_HANDLER while it is
still in use by MmiManage(). The fix involves modifying
MmiHandlerUnRegister() to detect whether it is being called from
within the MmiManage() stack. If so, the removal of the MMI_HANDLER
is deferred until MmiManage() has finished executing.
Additionally, due to the possibility of recursive MmiManage() calls,
the unregistration and subsequent removal of the MMI_HANDLER are
ensured to occur only after the outermost MmiManage() invocation has
completed.

Cc: Liming Gao <[email protected]>
Cc: Jiaxin Wu <[email protected]>
Reviewed-by: Ray Ni <[email protected]>
Cc: Laszlo Ersek <[email protected]>
Cc: Ard Biesheuvel <[email protected]>
Cc: Sami Mujawar <[email protected]>
Signed-off-by: Zhiguang Liu <[email protected]>


Compare: https://github.com/tianocore/edk2/compare/5ba3602e4580...70892b13b28c

To unsubscribe from these emails, change your notification settings at 
https://github.com/tianocore/edk2/settings/notifications


_______________________________________________
edk2-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-commits

Reply via email to