Branch: refs/heads/master
  Home:   https://github.com/tianocore/edk2
  Commit: 32e2968a1ec05c2631b707ab2175aa25987e3896
      
https://github.com/tianocore/edk2/commit/32e2968a1ec05c2631b707ab2175aa25987e3896
  Author: Cindy Kuo <[email protected]>
  Date:   2024-04-16 (Tue, 16 Apr 2024)

  Changed paths:
    M SecurityPkg/Tcg/Opal/OpalPassword/OpalHii.c

  Log Message:
  -----------
  SecurityPkg/OpalPasswordDxe: Change callback action to meet UEFI spec

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4735

Should not call HiiGetBrowserData() and HiiSetBrowserData() in
ACTION_FORM_OPEN callback function.
Those APIs are called within OpalHiiSetBrowserData/OpalHiiGetBrowserData
which have been used by OpalHii.c.

Change callback action from FORM_OPEN to RETRIEVE to meet UEFI spec.

Cc: Jiewen Yao <[email protected]>
Cc: Rahul Kumar <[email protected]>
Cc: Dandan Bi <[email protected]>
Cc: Ming Tan <[email protected]>
Cc: Arthur Chen <[email protected]>
Cc: Xiao X Chen <[email protected]>
Cc: Tina Chen <[email protected]>

Signed-off-by: CindyX Kuo <[email protected]>
Reviewed-by: Dandan Bi <[email protected]>
Reviewed-by: Tina Chen <[email protected]>
Acked-by: Jiewen Yao <[email protected]>


  Commit: b6cd5ddce9ade43e4215836f12b43ebbb90eecf2
      
https://github.com/tianocore/edk2/commit/b6cd5ddce9ade43e4215836f12b43ebbb90eecf2
  Author: CindyX Kuo <[email protected]>
  Date:   2024-04-16 (Tue, 16 Apr 2024)

  Changed paths:
    M SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.h
    M SecurityPkg/Tcg/Opal/OpalPassword/OpalHii.c
    M SecurityPkg/Tcg/Opal/OpalPassword/OpalHiiFormValues.h
    M SecurityPkg/Tcg/Opal/OpalPassword/OpalPasswordDxe.inf
    M SecurityPkg/Tcg/Opal/OpalPassword/OpalPasswordForm.vfr

  Log Message:
  -----------
  SecurityPkg/OpalPasswordDxe: Force reparsing IFR binary when RETRIEVE

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4735

When change callback action from FORM_OPEN to RETRIEVE, it is observed
that NVNE disks will not be displayed when the user enters the formset
at the first time. Revisit the formset can see the update.

1. Add HiiUpdateForm() to force reparsing the IFR binary when RETRIEVE.
2. Create dummy label with suppressif statement in VFR for form update
usage.

Cc: Jiewen Yao <[email protected]>
Cc: Rahul Kumar <[email protected]>
Cc: Dandan Bi <[email protected]>
Cc: Ming Tan <[email protected]>
Cc: Arthur Chen <[email protected]>
Cc: Xiao X Chen <[email protected]>
Cc: Tina Chen <[email protected]>

Signed-off-by: CindyX Kuo <[email protected]>
Reviewed-by: Dandan Bi <[email protected]>
Reviewed-by: Tina Chen <[email protected]>
Acked-by: Jiewen Yao <[email protected]>


Compare: https://github.com/tianocore/edk2/compare/7ea05d8fe9b2...b6cd5ddce9ad

To unsubscribe from these emails, change your notification settings at 
https://github.com/tianocore/edk2/settings/notifications


_______________________________________________
edk2-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-commits

Reply via email to