Branch: refs/heads/master
  Home:   https://github.com/tianocore/edk2
  Commit: ced13b93afea87a8a1fe6ddbb67240a84cb2e3d3
      
https://github.com/tianocore/edk2/commit/ced13b93afea87a8a1fe6ddbb67240a84cb2e3d3
  Author: Sam <[email protected]>
  Date:   2024-05-30 (Thu, 30 May 2024)

  Changed paths:
    M NetworkPkg/TcpDxe/TcpDriver.c

  Log Message:
  -----------
  NetworkPkg TcpDxe: Fixed system stuck on PXE boot flow in iPXE environment

This bug fix is based on the following commit "NetworkPkg TcpDxe: SECURITY 
PATCH"
REF: 1904a64

Issue Description:
An "Invalid handle" error was detected during runtime when attempting to 
destroy a child instance of the hashing protocol. The problematic code segment 
was:

NetworkPkg\TcpDxe\TcpDriver.c
Status = Hash2ServiceBinding->DestroyChild(Hash2ServiceBinding, 
​&mHash2ServiceHandle);

Root Cause Analysis:
The root cause of the error was the passing of an incorrect parameter type, a 
pointer to an EFI_HANDLE instead of an EFI_HANDLE itself, to the DestroyChild 
function. This mismatch resulted in the function receiving an invalid handle.

Implemented Solution:
To resolve this issue, the function call was corrected to pass 
mHash2ServiceHandle directly:

NetworkPkg\TcpDxe\TcpDriver.c
Status = Hash2ServiceBinding->DestroyChild(Hash2ServiceBinding, 
mHash2ServiceHandle);

This modification ensures the correct handle type is used, effectively 
rectifying the "Invalid handle" error.

Verification:
Testing has been conducted, confirming the efficacy of the fix. Additionally, 
the BIOS can boot into the OS in an iPXE environment.

Cc: Doug Flick [MSFT] <[email protected]>

Signed-off-by: Sam Tsai [Wiwynn] <[email protected]>
Reviewed-by: Saloni Kasbekar <[email protected]>



To unsubscribe from these emails, change your notification settings at 
https://github.com/tianocore/edk2/settings/notifications


_______________________________________________
edk2-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-commits

Reply via email to