Branch: refs/heads/master
  Home:   https://github.com/tianocore/edk2
  Commit: a715d456de47187cbaad1747a398499180cac710
      
https://github.com/tianocore/edk2/commit/a715d456de47187cbaad1747a398499180cac710
  Author: Leif Lindholm <[email protected]>
  Date:   2024-06-26 (Wed, 26 Jun 2024)

  Changed paths:
    M ArmPkg/Library/ArmArchTimerLib/ArmArchTimerLib.c

  Log Message:
  -----------
  ArmPkg: drop manual ARM programming of generic timer frequency

There is a bit of legacy code in ArmArchTimerLib that attempts to program
the generic timer based on a Pcd. This was only ever done for (32-bit)
ARM in case the cpu lacked the Security Extensions (because if they were
there, Secure firmware would be expected to have configured this before
switching to Non-secure state).

We don't support operation without Secure firmware anymore, but also the
code has been incorrectly invoked only on platforms that *do* implement
the Security Extensions since December 2020 and commit 0dd0d42ab5b6
("ArmPkg: use helper to check for Security extensions in ArmArchTimerLib")

As a result, edk2 has been overriding any programming done by Secure
Firmware on ARM platforms. Which is wrong.

Drop this programming in preparation for deleting the Pcd completely.

Signed-off-by: Leif Lindholm <[email protected]>


  Commit: 7ee89453b5a20199e96d08eb80db8dbaf06280e8
      
https://github.com/tianocore/edk2/commit/7ee89453b5a20199e96d08eb80db8dbaf06280e8
  Author: Leif Lindholm <[email protected]>
  Date:   2024-06-26 (Wed, 26 Jun 2024)

  Changed paths:
    M ArmVirtPkg/ArmVirtKvmTool.dsc
    M ArmVirtPkg/ArmVirtQemu.dsc
    M ArmVirtPkg/ArmVirtQemuKernel.dsc
    M ArmVirtPkg/ArmVirtXen.dsc

  Log Message:
  -----------
  ArmVirtPkg: drop use of PcdArmArchTimerFreqInHz

PcdArmArchTimerFreqInHz lets platforms override the architectural timer
frequency, but this really isn't supported in hardware by anything lower
than EL3. Setting it to 0 skips the override - but that is also the
default. So drop the explicit setting in ArmVirtPkg platforms in
preparation for deleting the Pcd completely.

Signed-off-by: Leif Lindholm <[email protected]>


  Commit: 0333faf50e49d3b3ea2c624b4d403b405b3107a1
      
https://github.com/tianocore/edk2/commit/0333faf50e49d3b3ea2c624b4d403b405b3107a1
  Author: Leif Lindholm <[email protected]>
  Date:   2024-06-26 (Wed, 26 Jun 2024)

  Changed paths:
    M ArmPkg/ArmPkg.dec
    M ArmPkg/Library/ArmArchTimerLib/ArmArchTimerLib.c
    M ArmPkg/Library/ArmArchTimerLib/ArmArchTimerLib.inf

  Log Message:
  -----------
  ArmPkg: delete PcdArmArchTimerFreqInHz

PcdArmArchTimerFreqInHz lets platforms override the architectural timer
frequency, but this really isn't supported in hardware by anything lower
than EL3. And we no longer support running edk2 at EL3.

So drop this Pcd and update ArmArchTimerLib to unconditionally use
ArmGenericTimerGetTimerFreq () instead.

Signed-off-by: Leif Lindholm <[email protected]>


Compare: https://github.com/tianocore/edk2/compare/2fbaaa96d11a...0333faf50e49

To unsubscribe from these emails, change your notification settings at 
https://github.com/tianocore/edk2/settings/notifications


_______________________________________________
edk2-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-commits

Reply via email to