Branch: refs/heads/master
  Home:   https://github.com/tianocore/edk2
  Commit: 57151d88f2901ddc5feed1c9772b7bda54e3eb33
      
https://github.com/tianocore/edk2/commit/57151d88f2901ddc5feed1c9772b7bda54e3eb33
  Author: Aaron Pop <[email protected]>
  Date:   2025-11-22 (Sat, 22 Nov 2025)

  Changed paths:
    M MdeModulePkg/Core/Pei/FwVol/FwVol.c
    M MdeModulePkg/Core/Pei/Ppi/Ppi.c
    M MdeModulePkg/Core/PiSmmCore/SmramProfileRecord.c

  Log Message:
  -----------
  MdeModulePkg: Fix comparison with wider widths.

https://codeql.github.com/codeql-query-help/cpp/cpp-comparison-with-wider-type

If the narrow type (smaller range) is compared against a wide type
(larger range), the narrow value may overflow before reaching the wide
value. This can cause unexpected behavior, such as:

Infinite loops (loop condition never becomes false).
Incorrect logic (comparison results are misleading).

Signed-off-by: Aaron Pop <[email protected]>


  Commit: 5214f931c9a9bed62e1d5324864c60f25b77590d
      
https://github.com/tianocore/edk2/commit/5214f931c9a9bed62e1d5324864c60f25b77590d
  Author: Aaron Pop <[email protected]>
  Date:   2025-11-22 (Sat, 22 Nov 2025)

  Changed paths:
    M MdeModulePkg/Core/Dxe/Dispatcher/Dispatcher.c
    M MdeModulePkg/Core/Dxe/Gcd/Gcd.c
    M MdeModulePkg/Core/Dxe/Hand/Handle.c
    M MdeModulePkg/Core/Dxe/Image/Image.c
    M MdeModulePkg/Core/Dxe/Mem/MemoryProfileRecord.c
    M MdeModulePkg/Core/Dxe/Mem/Page.c
    M MdeModulePkg/Core/Dxe/Mem/Pool.c
    M MdeModulePkg/Core/Dxe/Misc/MemoryAttributesTable.c
    M MdeModulePkg/Core/Dxe/SectionExtraction/CoreSectionExtraction.c
    M MdeModulePkg/Core/DxeIplPeim/DxeLoad.c
    M MdeModulePkg/Core/DxeIplPeim/X64/VirtualMemory.c
    M MdeModulePkg/Core/Pei/Dispatcher/Dispatcher.c
    M MdeModulePkg/Core/Pei/Hob/Hob.c
    M MdeModulePkg/Core/PiSmmCore/HeapGuard.c
    M MdeModulePkg/Core/PiSmmCore/MemoryAttributesTable.c
    M MdeModulePkg/Core/PiSmmCore/Page.c
    M MdeModulePkg/Core/PiSmmCore/PiSmmIpl.c
    M MdeModulePkg/Core/PiSmmCore/Pool.c
    M MdeModulePkg/Core/PiSmmCore/SmiHandlerProfile.c
    M MdeModulePkg/Core/PiSmmCore/SmramProfileRecord.c

  Log Message:
  -----------
  MdeModulePkg: Fix missing NULL tests.

https://github.com/github/codeql/blob/codeql-cli-2.7.3/cpp/ql/src/Critical/MissingNullTest.qhelp

For items which allocate memory, or get a pointer from another
structure, it is important to validate that the pointers
are not null before they are dereferenced.

Signed-off-by: Aaron Pop <[email protected]>


Compare: https://github.com/tianocore/edk2/compare/ad961fa9794a...5214f931c9a9

To unsubscribe from these emails, change your notification settings at 
https://github.com/tianocore/edk2/settings/notifications


_______________________________________________
edk2-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-commits

Reply via email to