Branch: refs/heads/master
Home: https://github.com/tianocore/edk2
Commit: 119184aa2c4d9463a1123567104e23773e402397
https://github.com/tianocore/edk2/commit/119184aa2c4d9463a1123567104e23773e402397
Author: Aaron Pop <[email protected]>
Date: 2025-11-23 (Sun, 23 Nov 2025)
Changed paths:
M MdeModulePkg/Universal/CapsulePei/UefiCapsule.c
M MdeModulePkg/Universal/FaultTolerantWriteDxe/FtwMisc.c
M MdeModulePkg/Universal/FaultTolerantWritePei/FaultTolerantWritePei.c
M MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.c
Log Message:
-----------
MdeModulePkg: Fix comparison with wider widths.
https://codeql.github.com/codeql-query-help/cpp/cpp-comparison-with-wider-type
If the narrow type (smaller range) is compared against a wide type
(larger range), the narrow value may overflow before reaching the wide
value. This can cause unexpected behavior, such as:
Infinite loops (loop condition never becomes false).
Incorrect logic (comparison results are misleading).
Signed-off-by: Aaron Pop <[email protected]>
Commit: 61472ad963a22fd108345106e220fcdfcc357207
https://github.com/tianocore/edk2/commit/61472ad963a22fd108345106e220fcdfcc357207
Author: Aaron Pop <[email protected]>
Date: 2025-11-23 (Sun, 23 Nov 2025)
Changed paths:
M MdeModulePkg/Universal/PlatformDriOverrideDxe/PlatDriOverrideDxe.c
M MdeModulePkg/Universal/PlatformDriOverrideDxe/PlatDriOverrideLib.c
Log Message:
-----------
MdeModulePkg: Correct documentation.
Function headers were missing different return statuses which were currently in
use.
Update the function headers to detail the statuses.
Signed-off-by: Aaron Pop <[email protected]>
Commit: 1097edb4c3eac1daf8161f8618a3eb7c81840c98
https://github.com/tianocore/edk2/commit/1097edb4c3eac1daf8161f8618a3eb7c81840c98
Author: Aaron Pop <[email protected]>
Date: 2025-11-23 (Sun, 23 Nov 2025)
Changed paths:
M MdeModulePkg/Universal/BdsDxe/BdsEntry.c
M MdeModulePkg/Universal/BootManagerPolicyDxe/BootManagerPolicyDxe.c
M MdeModulePkg/Universal/DriverHealthManagerDxe/DriverHealthManagerDxe.c
M MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSupportString.c
M MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c
M MdeModulePkg/Universal/FaultTolerantWritePei/FaultTolerantWritePei.c
M MdeModulePkg/Universal/PlatformDriOverrideDxe/PlatDriOverrideDxe.c
M MdeModulePkg/Universal/PlatformDriOverrideDxe/PlatDriOverrideLib.c
M
MdeModulePkg/Universal/ReportStatusCodeRouter/Smm/ReportStatusCodeRouterCommon.c
Log Message:
-----------
MdeModulePkg: Fix missing NULL tests.
https://github.com/github/codeql/blob/codeql-cli-2.7.3/cpp/ql/src/Critical/MissingNullTest.qhelp
For items which allocate memory, or get a pointer from another
structure, it is important to validate that the pointers
are not null before they are dereferenced.
Signed-off-by: Aaron Pop <[email protected]>
Commit: 6d4fbc012fb196ddaff32e48f0c0a57307bf1729
https://github.com/tianocore/edk2/commit/6d4fbc012fb196ddaff32e48f0c0a57307bf1729
Author: Aaron Pop <[email protected]>
Date: 2025-11-23 (Sun, 23 Nov 2025)
Changed paths:
M MdeModulePkg/Universal/Variable/Pei/Variable.c
Log Message:
-----------
MdeModulePkg: Fix unchecked return status.
https://github.com/github/codeql/blob/codeql-cli-2.7.3/csharp/ql/src/API%20Abuse/UncheckedReturnValue.qhelp
When a function has a return status, it should
be checked to verify the function completed successfully.
Failing to check the return status can result in null pointer
dereferences or use of uninitialized variables.
Signed-off-by: Aaron Pop <[email protected]>
Commit: 33219cef7344efa4fb2d2f4c85e9e47e28d38216
https://github.com/tianocore/edk2/commit/33219cef7344efa4fb2d2f4c85e9e47e28d38216
Author: Aaron Pop <[email protected]>
Date: 2025-11-23 (Sun, 23 Nov 2025)
Changed paths:
M MdeModulePkg/Universal/Disk/UdfDxe/FileName.c
M MdeModulePkg/Universal/Disk/UdfDxe/FileSystemOperations.c
M MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSupportString.c
Log Message:
-----------
MdeModulePkg: Fix useless tests.
https://github.com/github/codeql/blob/codeql-cli-2.7.3/java/ql/src/Language%20Abuse/UselessNullCheck.qhelp
These are all recognized as useless checks.
if (*TempString != L'\0' && *TempString == L'\\') {
if ((*FilePath != L'\0') && (*FilePath == L'\\')) {
while (*Str != '\0' && *Str == ' ') {
while (*Str != '\0' && *Str == '0') {
if ((*Str != '\0') && ((*Str == 'x') || (*Str == 'X'))) {
while (*Str != '\0' && *Str == ' ') {
For all of these cases, they are checking if the variable
is not nil before they check if the character matches an exact character.
If the variable matches the exact character, but that virtue,
it will not be nil.
Signed-off-by: Aaron Pop <[email protected]>
Compare: https://github.com/tianocore/edk2/compare/2fd6884a9b56...33219cef7344
To unsubscribe from these emails, change your notification settings at
https://github.com/tianocore/edk2/settings/notifications
_______________________________________________
edk2-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-commits
