Branch: refs/heads/master
Home: https://github.com/tianocore/edk2
Commit: 33e4e73a17bff0823bc916998169b926115b0c6b
https://github.com/tianocore/edk2/commit/33e4e73a17bff0823bc916998169b926115b0c6b
Author: Mike Beaton <[email protected]>
Date: 2025-11-28 (Fri, 28 Nov 2025)
Changed paths:
M
ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturerFunction.c
Log Message:
-----------
ArmPkg: Fix errors in MiscChassisManufacturerFunction
Initial error found while attempting to implement Azure Pipelines
CLANGDWARF CI:
ERROR - Compiler #error from /__w/1/s/ArmPkg/Universal/Smbios/SmbiosMiscDx
e/Type03/MiscChassisManufacturerFunction.c variable 'ContainedElements' is
uninitialized when passed as a const pointer argument here [-Werror,-Wunin
itialized-const-pointer]
The code in question should copy the optional ContainedElements from
InputData, so fix it so that it does.
Additionally:
- Various size calculations in the original code are incorrect, since
the base size for calculations should not include ContainedElements,
so fix these.
- Since we are calculating Hdr.Length separately as part of the above,
add code to ASSERT and return EFI_OUT_OF_RESOURCES if it would
overflow the UINT8 location where it will be stored.
- Since we are adding a new early exit, fix the fact that no error log
message is generated on early exit.
Fixes: bfc0fae459543442f3f17e0de655a72aba5b0920
Signed-off-by: Mike Beaton <[email protected]>
Commit: 04972ca2cf5e70a9f443a55353276fcc3a0e957c
https://github.com/tianocore/edk2/commit/04972ca2cf5e70a9f443a55353276fcc3a0e957c
Author: Mike Beaton <[email protected]>
Date: 2025-11-28 (Fri, 28 Nov 2025)
Changed paths:
M
ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturerFunction.c
Log Message:
-----------
ArmPkg: Switch to AllocatePool in MiscChassisManufacturerFunction
There was only one byte uninitialized in the function as fixed in the
previous commit. Explicitly initialize it and switch to AllocatePool.
Signed-off-by: Mike Beaton <[email protected]>
Commit: 68d8f3a3d2c78ee301f73d484f04e1f00926846b
https://github.com/tianocore/edk2/commit/68d8f3a3d2c78ee301f73d484f04e1f00926846b
Author: Mike Beaton <[email protected]>
Date: 2025-11-28 (Fri, 28 Nov 2025)
Changed paths:
M
ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturerFunction.c
Log Message:
-----------
ArmPkg: Add additional ASSERT in MiscChassisManufacturerFunction
In this revised version of the code, we start with a pointer immediately
past the end of the parts of the struct specified in the input data, and
hopefully end up with a pointer at the end of the entire SMBIOS struct
(version dependent part(s) and all), plus appended strings. If we switch
to doing this fully incrementally - always updating where we are by adding
to the previous pointer - then it seems worth adding an ASSERT to confirm
that we got to the end correctly.
The other change applied here in addition to the ASSERT is in order
to make each next pointer be calculated strictly by adding the intended
size to the immediately previous one, as all the other pointer changes
already were.
Signed-off-by: Mike Beaton <[email protected]>
Commit: af9cc80359e320690877e4add870aa13fe889fbe
https://github.com/tianocore/edk2/commit/af9cc80359e320690877e4add870aa13fe889fbe
Author: Mike Beaton <[email protected]>
Date: 2025-11-28 (Fri, 28 Nov 2025)
Changed paths:
M
ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturerFunction.c
Log Message:
-----------
ArmPkg: Update type for SkuNumberField in MiscChassisManufacturerFunction
SMBIOS_TABLE_STRING is the correct type for the field, even though that
is itself defined as UINT8.
There are five strings handled by this function. Their string numbers are
stored in the five SMBIOS_TABLE_STRING values in the SMBIOS_TABLE_TYPE3
struct. Four of these are defined, with that type, in the fixed-position
portion of the struct, before ContainedElements, and the fifth is the
field which this pointer references (as can be discovered from the
comments on the SMBIOS_TABLE_TYPE3, as well as the usage of this value).
This is clearer when reading the code when the correct type is used.
Signed-off-by: Mike Beaton <[email protected]>
Compare: https://github.com/tianocore/edk2/compare/122f3f351440...af9cc80359e3
To unsubscribe from these emails, change your notification settings at
https://github.com/tianocore/edk2/settings/notifications
_______________________________________________
edk2-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-commits
