Branch: refs/heads/master
Home: https://github.com/tianocore/edk2
Commit: 3f94056b30b1e6949fd4263b594e10609b04096e
https://github.com/tianocore/edk2/commit/3f94056b30b1e6949fd4263b594e10609b04096e
Author: Joey Vagedes <[email protected]>
Date: 2025-12-08 (Mon, 08 Dec 2025)
Changed paths:
M .pytool/Plugin/SpellCheck/SpellCheck.py
Log Message:
-----------
.pytool/SpellCheck: Fix silent cspell run error
In the implementation of the SpellCheck prior to this commit, the logic
assumed that if it was able to successfully call `cspell --version` to
get the version, then any future usage of cspell would work without
error. PR #11783 brought to light an issue in this logic where if the
node version was too out of date, `cspell` could successfully run
`cspell --version` but would hit a runtime error when actually
performing a spell check on a package. This ultimetly resulted in
cspell not running for any package but still reporting a "Success".
This commit updates the error handling logic in the SpellCheck when
running cspell to ensure that when cspell error lines were reported, at
least one misspelled word must be found. In the scenario where error
lines are reported, but no misspelled words were found, we now assume a
runtime error occurred in cspell, log it, and fail the plugin.
Signed-off-by: Joey Vagedes <[email protected]>
To unsubscribe from these emails, change your notification settings at
https://github.com/tianocore/edk2/settings/notifications
_______________________________________________
edk2-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-commits
