Branch: refs/heads/master
Home: https://github.com/tianocore/edk2
Commit: 40c898febeea93cc83e56608a3d1d2e9f85b019a
https://github.com/tianocore/edk2/commit/40c898febeea93cc83e56608a3d1d2e9f85b019a
Author: Leif Lindholm <[email protected]>
Date: 2026-07-31 (Fri, 31 Jul 2026)
Changed paths:
M
ManageabilityPkg/Library/BaseManageabilityTransportHelperLib/BaseManageabilityTransportHelper.c
Log Message:
-----------
ManageabilityPkg: simplify HelperManageabilityPayLoadDebugPrint ()
While reviewing PR #12035, I found this function a bit overcomplicated,
with a bunch of live-coded integers, so I reworked it for improved
human and compiler readability.
Signed-off-by: Leif Lindholm <[email protected]>
Commit: be62f3ded57452bafff4e627313637d4d39c34d9
https://github.com/tianocore/edk2/commit/be62f3ded57452bafff4e627313637d4d39c34d9
Author: Leif Lindholm <[email protected]>
Date: 2026-07-31 (Fri, 31 Jul 2026)
Changed paths:
R
ManageabilityPkg/Library/ManageabilityTransportSsifLib/Common/ManageabilityTransportSsif.h
R ManageabilityPkg/Library/ManageabilityTransportSsifLib/Common/SsifCommon.c
R
ManageabilityPkg/Library/ManageabilityTransportSsifLib/Dxe/DxeManageabilityTransportSsif.inf
R
ManageabilityPkg/Library/ManageabilityTransportSsifLib/Dxe/ManageabilityTransportSsif.c
R
ManageabilityPkg/Library/ManageabilityTransportSsifLib/Dxe/ManageabilityTransportSsif.uni
A
ManageabilityPkg/Library/ManageabilityTransportSsifLib/DxeManageabilityTransportSsif.inf
A
ManageabilityPkg/Library/ManageabilityTransportSsifLib/ManageabilityTransportSsif.c
A
ManageabilityPkg/Library/ManageabilityTransportSsifLib/ManageabilityTransportSsif.h
A
ManageabilityPkg/Library/ManageabilityTransportSsifLib/ManageabilityTransportSsif.uni
R
ManageabilityPkg/Library/ManageabilityTransportSsifLib/Pei/ManageabilityTransportSsif.c
R
ManageabilityPkg/Library/ManageabilityTransportSsifLib/Pei/ManageabilityTransportSsif.uni
R
ManageabilityPkg/Library/ManageabilityTransportSsifLib/Pei/PeiManageabilityTransportSsif.inf
A
ManageabilityPkg/Library/ManageabilityTransportSsifLib/PeiManageabilityTransportSsif.inf
A ManageabilityPkg/Library/ManageabilityTransportSsifLib/SsifCommon.c
M ManageabilityPkg/Manageability.dsc.inc
M ManageabilityPkg/ManageabilityPkg.dsc
Log Message:
-----------
ManageabilityPkg: reorganise ManageabilityTransportSsifLib
For some reason this module was created "backwards", with .inf files
in subdirectories, as well as identical apart from failes to keep in
sync source files for Dxe and Pei drivers.
Flip the thing the right way around and delete the duplicated files.
Signed-off-by: Leif Lindholm <[email protected]>
Commit: e8cbfab461e28ce22be3e0c6beadd82b2f925bc1
https://github.com/tianocore/edk2/commit/e8cbfab461e28ce22be3e0c6beadd82b2f925bc1
Author: Leif Lindholm <[email protected]>
Date: 2026-07-31 (Fri, 31 Jul 2026)
Changed paths:
M ManageabilityPkg/Library/ManageabilityTransportSsifLib/SsifCommon.c
Log Message:
-----------
ManageabilityPkg: refactor SsifWriteRequest #1
Separate input validation from argument marshalling.
Signed-off-by: Leif Lindholm <[email protected]>
Commit: 598025e8660c07ee806aaf0efe2a2fff4e235a9c
https://github.com/tianocore/edk2/commit/598025e8660c07ee806aaf0efe2a2fff4e235a9c
Author: Leif Lindholm <[email protected]>
Date: 2026-07-31 (Fri, 31 Jul 2026)
Changed paths:
M ManageabilityPkg/Library/ManageabilityTransportSsifLib/SsifCommon.c
Log Message:
-----------
ManageabilityPkg: fix/cleanup request size check in SsifWriteRequest
>From the IPMI v2.0 (April 21, 2015 E7 Markup) specification,
Table 22-12, Get System Interface Capabilities Command:
"Input message size in bytes. (1 based.)"
...
"A BMC that supports multi-part Start and End would return
a value from 33 to 64. A BMC that supports multi-part with Middle
transactions would return a value from 65 to 255."
Yet the comment in the existing code describes this as being a
counter of the number of middle packets, with Start and End packets
counting outside of that. This seems very incorrect to me.
Address this, and simplify the code, by using the already existing
global variable mMaxRequestSize. Update the debug error message
text to reflect the functional change.
Signed-off-by: Leif Lindholm <[email protected]>
Commit: 150339f262fc2c54a27dc2aae4a4bbe540379a86
https://github.com/tianocore/edk2/commit/150339f262fc2c54a27dc2aae4a4bbe540379a86
Author: Leif Lindholm <[email protected]>
Date: 2026-07-31 (Fri, 31 Jul 2026)
Changed paths:
M ManageabilityPkg/Library/ManageabilityTransportSsifLib/SsifCommon.c
Log Message:
-----------
ManageabilityPkg: SsifWriteRequest loop refactoring
A multi-part request can consist of a Start, zero-to-several Middle,
and an End packet. For what I can only assume was an attempt to
confuse the enemy, SsifWriteRequest () handled this by setting up
three separate loops.
Rewrite this as a single loop in order to reduce confusion for
revewers and compilers.
Signed-off-by: Leif Lindholm <[email protected]>
Commit: a6a060f940f11e9fb4f204e4110c3cee9dbae9ca
https://github.com/tianocore/edk2/commit/a6a060f940f11e9fb4f204e4110c3cee9dbae9ca
Author: Leif Lindholm <[email protected]>
Date: 2026-07-31 (Fri, 31 Jul 2026)
Changed paths:
M ManageabilityPkg/Library/ManageabilityTransportSsifLib/SsifCommon.c
Log Message:
-----------
ManageabilityPkg: SsifWriteRequest post-refactor cleanup
Now the logic of the function is less convoluted, drop some redundant
casts, variable initialisations and move the MiddleCount definition
into the only block where it's used.
Signed-off-by: Leif Lindholm <[email protected]>
Compare: https://github.com/tianocore/edk2/compare/71dc4edb9217...a6a060f940f1
To unsubscribe from these emails, change your notification settings at
https://github.com/tianocore/edk2/settings/notifications
_______________________________________________
edk2-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-commits
