Branch: refs/heads/master
Home: https://github.com/tianocore/edk2
Commit: a3da9cde61fcc0082c5900106ebe66a4727ecf09
https://github.com/tianocore/edk2/commit/a3da9cde61fcc0082c5900106ebe66a4727ecf09
Author: Pierre Gondois <[email protected]>
Date: 2026-08-04 (Tue, 04 Aug 2026)
Changed paths:
M ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/Edit.c
Log Message:
-----------
ShellPkg/Edit: Remove unused code snippet
The commented out code snippet seems to try to create a new file
with the user input filename. FileBufferRead() seems to have replaced
this code snippet in a better wrapper:
- if the file exists, open it
- otherwise, create the file
Remove the commented-out code snippet.
Signed-off-by: Pierre Gondois <[email protected]>
Commit: 4e1e7393384987244fdb824e80be24db2468da29
https://github.com/tianocore/edk2/commit/4e1e7393384987244fdb824e80be24db2468da29
Author: Pierre Gondois <[email protected]>
Date: 2026-08-04 (Tue, 04 Aug 2026)
Changed paths:
M ShellPkg/Library/UefiShellLevel2CommandsLib/Ls.c
Log Message:
-----------
ShellPkg/Ls: Remove double-free calls
Package is always freed in ShellCommandRunLs().
Remove calls to ShellCommandLineFreeVarList() in MainCmdLs().
This double-free was introduced in:
commit 531b0aa00211 ("ShellPkg/UefiShellLevel2:
Extract MainCmdXXX() function")
Signed-off-by: Pierre Gondois <[email protected]>
Commit: 7ee84dc437ec4df895ebe69a08352e3c13e99f17
https://github.com/tianocore/edk2/commit/7ee84dc437ec4df895ebe69a08352e3c13e99f17
Author: Pierre Gondois <[email protected]>
Date: 2026-08-04 (Tue, 04 Aug 2026)
Changed paths:
M ShellPkg/Library/UefiShellDebug1CommandsLib/Comp.c
M ShellPkg/Library/UefiShellDebug1CommandsLib/Cxl.c
M ShellPkg/Library/UefiShellDebug1CommandsLib/Dblk.c
M ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c
M ShellPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c
Log Message:
-----------
ShellPkg/UefiShellDebug1: Return if ShellCommandLineParse() failed (1/4)
This patch aims to help breaking down the long functions present in
the ShellPkg and reduce complexity/nested code and conditions.
Return directly if ShellCommandLineParse() returned an error Status.
In such case, the "Package" that should be allocated by
ShellCommandLineParse() is already freed in:
ShellCommandLineParse()
\-ShellCommandLineParseEx()
\-InternalCommandLineParse()
so there is no need to free it with ShellCommandLineFreeVarList().
To avoid having one large commit updating all the UefiShellDebug1
commands, only update these files:
- Comp.c
- Cxl.c
- Dblk.c
- Dmem.c
- DmpStore.c
No functional change should be induced by this patch.
Signed-off-by: Pierre Gondois <[email protected]>
Commit: d23559e847f41d9c8fa69cb801a31a9ffda9baa1
https://github.com/tianocore/edk2/commit/d23559e847f41d9c8fa69cb801a31a9ffda9baa1
Author: Pierre Gondois <[email protected]>
Date: 2026-08-04 (Tue, 04 Aug 2026)
Changed paths:
M ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/Edit.c
M ShellPkg/Library/UefiShellDebug1CommandsLib/EfiCompress.c
M ShellPkg/Library/UefiShellDebug1CommandsLib/EfiDecompress.c
M ShellPkg/Library/UefiShellDebug1CommandsLib/HexEdit/HexEdit.c
M ShellPkg/Library/UefiShellDebug1CommandsLib/LoadPciRom.c
Log Message:
-----------
ShellPkg/UefiShellDebug1: Return if ShellCommandLineParse() failed (2/4)
This patch aims to help breaking down the long functions present in
the ShellPkg and reduce complexity/nested code and conditions.
Return directly if ShellCommandLineParse() returned an error Status.
In such case, the "Package" that should be allocated by
ShellCommandLineParse() is already freed in:
ShellCommandLineParse()
\-ShellCommandLineParseEx()
\-InternalCommandLineParse()
so there is no need to free it with ShellCommandLineFreeVarList().
To avoid having one large commit updating all the UefiShellDebug1
commands, only update these files:
- Edit/Edit.c
- EfiCompress.c
- EfiDecompress.c
- HexEdit/HexEdit.c
- LoadPciRom.c
No functional change should be induced by this patch.
Signed-off-by: Pierre Gondois <[email protected]>
Commit: da181122b1640e603c668ef6e10e1aec9e1ca47d
https://github.com/tianocore/edk2/commit/da181122b1640e603c668ef6e10e1aec9e1ca47d
Author: Pierre Gondois <[email protected]>
Date: 2026-08-04 (Tue, 04 Aug 2026)
Changed paths:
M ShellPkg/Library/UefiShellDebug1CommandsLib/MemMap.c
M ShellPkg/Library/UefiShellDebug1CommandsLib/Mm.c
M ShellPkg/Library/UefiShellDebug1CommandsLib/Mode.c
M ShellPkg/Library/UefiShellDebug1CommandsLib/Pci.c
Log Message:
-----------
ShellPkg/UefiShellDebug1: Return if ShellCommandLineParse() failed (3/4)
This patch aims to help breaking down the long functions present in
the ShellPkg and reduce complexity/nested code and conditions.
Return directly if ShellCommandLineParse() returned an error Status.
In such case, the "Package" that should be allocated by
ShellCommandLineParse() is already freed in:
ShellCommandLineParse()
\-ShellCommandLineParseEx()
\-InternalCommandLineParse()
so there is no need to free it with ShellCommandLineFreeVarList().
To avoid having one large commit updating all the UefiShellDebug1
commands, only update these files:
- MemMap.c
- Mm.c
- Mode.c
- Pci.c
No functional change should be induced by this patch.
Signed-off-by: Pierre Gondois <[email protected]>
Commit: 6dea226953e817a24519022b823b62326eaf9bf8
https://github.com/tianocore/edk2/commit/6dea226953e817a24519022b823b62326eaf9bf8
Author: Pierre Gondois <[email protected]>
Date: 2026-08-04 (Tue, 04 Aug 2026)
Changed paths:
M ShellPkg/Library/UefiShellDebug1CommandsLib/SerMode.c
M ShellPkg/Library/UefiShellDebug1CommandsLib/SetSize.c
M ShellPkg/Library/UefiShellDebug1CommandsLib/SetVar.c
M ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/SmbiosView.c
Log Message:
-----------
ShellPkg/UefiShellDebug1: Return if ShellCommandLineParse() failed (4/4)
This patch aims to help breaking down the long functions present in
the ShellPkg and reduce complexity/nested code and conditions.
Return directly if ShellCommandLineParse() returned an error Status.
In such case, the "Package" that should be allocated by
ShellCommandLineParse() is already freed in:
ShellCommandLineParse()
\-ShellCommandLineParseEx()
\-InternalCommandLineParse()
so there is no need to free it with ShellCommandLineFreeVarList().
To avoid having one large commit updating all the UefiShellDebug1
commands, only update these files:
- SerMode.c
- SetSize.c
- SetVar.c
- SmbiosView/SmbiosView.c
No functional change should be induced by this patch.
Signed-off-by: Pierre Gondois <[email protected]>
Commit: c8279789102f699527e5e3060fdfd1f0c2188e76
https://github.com/tianocore/edk2/commit/c8279789102f699527e5e3060fdfd1f0c2188e76
Author: Pierre Gondois <[email protected]>
Date: 2026-08-04 (Tue, 04 Aug 2026)
Changed paths:
M ShellPkg/Library/UefiShellDebug1CommandsLib/LoadPciRom.c
Log Message:
-----------
ShellPkg/LoadPciRom: Fix memory leak
Package is never freed.
Signed-off-by: Pierre Gondois <[email protected]>
Commit: adad73339ddfe5b91d0cc00fea8ac1bdd7a15d81
https://github.com/tianocore/edk2/commit/adad73339ddfe5b91d0cc00fea8ac1bdd7a15d81
Author: Pierre Gondois <[email protected]>
Date: 2026-08-04 (Tue, 04 Aug 2026)
Changed paths:
M ShellPkg/Library/UefiShellDebug1CommandsLib/Cxl.c
M ShellPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c
M ShellPkg/Library/UefiShellDebug1CommandsLib/EfiCompress.c
M ShellPkg/Library/UefiShellDebug1CommandsLib/Mm.c
M ShellPkg/Library/UefiShellDebug1CommandsLib/Pci.c
M ShellPkg/Library/UefiShellDebug1CommandsLib/SerMode.c
M ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/SmbiosView.c
Log Message:
-----------
ShellPkg/ShellDebug1: Rationalize Package init/free
Package is sometimes initialized to NULL and only
freed if not NULL. Remove these as:
- Package is initialized in ShellCommandLineParse().
- If ShellCommandLineFreeVarList() is reached,
Package cannot be NULL.
Signed-off-by: Pierre Gondois <[email protected]>
Commit: cb7f7262d51a92786bc44768bf0e69bdea29d0b1
https://github.com/tianocore/edk2/commit/cb7f7262d51a92786bc44768bf0e69bdea29d0b1
Author: Pierre Gondois <[email protected]>
Date: 2026-08-04 (Tue, 04 Aug 2026)
Changed paths:
M ShellPkg/Library/UefiShellDebug1CommandsLib/Mm.c
Log Message:
-----------
ShellPkg/Mm: Remove unnecessary goto
If ShellCommandLineParse() fails, there is no need to free:
- InputStr
- Package
Remove the goto statement.
Signed-off-by: Pierre Gondois <[email protected]>
Commit: 6d0ef532c633f9924f3f416e744653a0639e7c4e
https://github.com/tianocore/edk2/commit/6d0ef532c633f9924f3f416e744653a0639e7c4e
Author: Pierre Gondois <[email protected]>
Date: 2026-08-04 (Tue, 04 Aug 2026)
Changed paths:
M ShellPkg/Library/UefiShellDebug1CommandsLib/Comp.c
M ShellPkg/Library/UefiShellDebug1CommandsLib/Cxl.c
M ShellPkg/Library/UefiShellDebug1CommandsLib/Dblk.c
M ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c
M ShellPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c
Log Message:
-----------
ShellPkg/UefiShellDebug1: Extract MainCmdXXX() function (1/4)
This patch aims to help breaking down the long functions present in
the ShellPkg and reduce complexity/nested code and conditions.
Extract a MainCmdXXX() function for each shell command.
This command contains the possible operations the command aims
to operate. The ShellCommandRunXXX() function from which it
is extracted is only responsible of:
- initializing the shell/command environment
- parsing the command parameter and creating a Package
- freeing the Package
For the MemMap and SetVar commands, ShellCommandLineFreeVarList()
calls are removed as the Package is now freed in the caller
function: ShellCommandRunXXX().
To avoid having one large commit updating all the UefiShellDebug1
commands, only update these files:
- Comp.c
- Cxl.c
- Dblk.c
- Dmem.c
- DmpStore.c
No functional change should be induced by this patch.
Signed-off-by: Pierre Gondois <[email protected]>
Commit: 5bdbf4462bd50762b308a62498f587650ebaf656
https://github.com/tianocore/edk2/commit/5bdbf4462bd50762b308a62498f587650ebaf656
Author: Pierre Gondois <[email protected]>
Date: 2026-08-04 (Tue, 04 Aug 2026)
Changed paths:
M ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/Edit.c
M ShellPkg/Library/UefiShellDebug1CommandsLib/EfiCompress.c
M ShellPkg/Library/UefiShellDebug1CommandsLib/EfiDecompress.c
M ShellPkg/Library/UefiShellDebug1CommandsLib/HexEdit/HexEdit.c
M ShellPkg/Library/UefiShellDebug1CommandsLib/LoadPciRom.c
Log Message:
-----------
ShellPkg/UefiShellDebug1: Extract MainCmdXXX() function (2/4)
This patch aims to help breaking down the long functions present in
the ShellPkg and reduce complexity/nested code and conditions.
Extract a MainCmdXXX() function for each shell command.
This command contains the possible operations the command aims
to operate. The ShellCommandRunXXX() function from which it
is extracted is only responsible of:
- initializing the shell/command environment
- parsing the command parameter and creating a Package
- freeing the Package
For the MemMap and SetVar commands, ShellCommandLineFreeVarList()
calls are removed as the Package is now freed in the caller
function: ShellCommandRunXXX().
To avoid having one large commit updating all the UefiShellDebug1
commands, only update these files:
- Edit/Edit.c
- EfiCompress.c
- EfiDecompress.c
- HexEdit/HexEdit.c
- LoadPciRom.c
No functional change should be induced by this patch.
Signed-off-by: Pierre Gondois <[email protected]>
Commit: 0b6156b43a545a0a571013293963290eb06c0865
https://github.com/tianocore/edk2/commit/0b6156b43a545a0a571013293963290eb06c0865
Author: Pierre Gondois <[email protected]>
Date: 2026-08-04 (Tue, 04 Aug 2026)
Changed paths:
M ShellPkg/Library/UefiShellDebug1CommandsLib/MemMap.c
M ShellPkg/Library/UefiShellDebug1CommandsLib/Mm.c
M ShellPkg/Library/UefiShellDebug1CommandsLib/Mode.c
M ShellPkg/Library/UefiShellDebug1CommandsLib/Pci.c
Log Message:
-----------
ShellPkg/UefiShellDebug1: Extract MainCmdXXX() function (3/4)
This patch aims to help breaking down the long functions present in
the ShellPkg and reduce complexity/nested code and conditions.
Extract a MainCmdXXX() function for each shell command.
This command contains the possible operations the command aims
to operate. The ShellCommandRunXXX() function from which it
is extracted is only responsible of:
- initializing the shell/command environment
- parsing the command parameter and creating a Package
- freeing the Package
For the MemMap and SetVar commands, ShellCommandLineFreeVarList()
calls are removed as the Package is now freed in the caller
function: ShellCommandRunXXX().
To avoid having one large commit updating all the UefiShellDebug1
commands, only update these files:
- MemMap.c
- Mm.c
- Mode.c
- Pci.c
No functional change should be induced by this patch.
Signed-off-by: Pierre Gondois <[email protected]>
Commit: cebf8bc4ae7e0ecea95377a7eb9582fad92aaa3a
https://github.com/tianocore/edk2/commit/cebf8bc4ae7e0ecea95377a7eb9582fad92aaa3a
Author: Pierre Gondois <[email protected]>
Date: 2026-08-04 (Tue, 04 Aug 2026)
Changed paths:
M ShellPkg/Library/UefiShellDebug1CommandsLib/SerMode.c
M ShellPkg/Library/UefiShellDebug1CommandsLib/SetSize.c
M ShellPkg/Library/UefiShellDebug1CommandsLib/SetVar.c
M ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/SmbiosView.c
Log Message:
-----------
ShellPkg/UefiShellDebug1: Extract MainCmdXXX() function (4/4)
This patch aims to help breaking down the long functions present in
the ShellPkg and reduce complexity/nested code and conditions.
Extract a MainCmdXXX() function for each shell command.
This command contains the possible operations the command aims
to operate. The ShellCommandRunXXX() function from which it
is extracted is only responsible of:
- initializing the shell/command environment
- parsing the command parameter and creating a Package
- freeing the Package
For the MemMap and SetVar commands, ShellCommandLineFreeVarList()
calls are removed as the Package is now freed in the caller
function: ShellCommandRunXXX().
To avoid having one large commit updating all the UefiShellDebug1
commands, only update these files:
- SerMode.c
- SetSize.c
- SetVar.c
- SmbiosView/SmbiosView.c
No functional change should be induced by this patch.
Signed-off-by: Pierre Gondois <[email protected]>
Commit: cad93da7e5efead7c9a7ddb774b968894a538cbd
https://github.com/tianocore/edk2/commit/cad93da7e5efead7c9a7ddb774b968894a538cbd
Author: Pierre Gondois <[email protected]>
Date: 2026-08-04 (Tue, 04 Aug 2026)
Changed paths:
M ShellPkg/Library/UefiShellDebug1CommandsLib/Comp.c
M ShellPkg/Library/UefiShellDebug1CommandsLib/Cxl.c
M ShellPkg/Library/UefiShellDebug1CommandsLib/Dblk.c
M ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c
M ShellPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c
Log Message:
-----------
ShellPkg/UefiShellDebug1: Lower indentation level in MainCmdXXX() (1/4)
This patch aims to help breaking down the long functions present in
the ShellPkg and reduce complexity/nested code and conditions.
Lower the indentation level in the newly created MainCmdXXX()
functions.
To avoid having one large commit updating all the UefiShellDebug1
commands, only update these files:
- Comp.c
- Cxl.c
- Dblk.c
- Dmem.c
- DmpStore.c
No functional change should be induced by this patch.
Signed-off-by: Pierre Gondois <[email protected]>
Commit: d395696428e7198a7369f52a61e579d7a2bf8cd6
https://github.com/tianocore/edk2/commit/d395696428e7198a7369f52a61e579d7a2bf8cd6
Author: Pierre Gondois <[email protected]>
Date: 2026-08-04 (Tue, 04 Aug 2026)
Changed paths:
M ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/Edit.c
M ShellPkg/Library/UefiShellDebug1CommandsLib/EfiCompress.c
M ShellPkg/Library/UefiShellDebug1CommandsLib/EfiDecompress.c
M ShellPkg/Library/UefiShellDebug1CommandsLib/LoadPciRom.c
Log Message:
-----------
ShellPkg/UefiShellDebug1: Lower indentation level in MainCmdXXX() (2/4)
This patch aims to help breaking down the long functions present in
the ShellPkg and reduce complexity/nested code and conditions.
Lower the indentation level in the newly created MainCmdXXX()
functions.
To avoid having one large commit updating all the UefiShellDebug1
commands, only update these files:
- Edit/Edit.c
- EfiCompress.c
- EfiDecompress.c
- LoadPciRom.c
No functional change should be induced by this patch.
Signed-off-by: Pierre Gondois <[email protected]>
Commit: 642954d2956420fa5855754ba41ab2cca7b73c3c
https://github.com/tianocore/edk2/commit/642954d2956420fa5855754ba41ab2cca7b73c3c
Author: Pierre Gondois <[email protected]>
Date: 2026-08-04 (Tue, 04 Aug 2026)
Changed paths:
M ShellPkg/Library/UefiShellDebug1CommandsLib/MemMap.c
M ShellPkg/Library/UefiShellDebug1CommandsLib/Mm.c
M ShellPkg/Library/UefiShellDebug1CommandsLib/Mode.c
M ShellPkg/Library/UefiShellDebug1CommandsLib/Pci.c
Log Message:
-----------
ShellPkg/UefiShellDebug1: Lower indentation level in MainCmdXXX() (3/4)
This patch aims to help breaking down the long functions present in
the ShellPkg and reduce complexity/nested code and conditions.
Lower the indentation level in the newly created MainCmdXXX()
functions.
To avoid having one large commit updating all the UefiShellDebug1
commands, only update these files:
- MemMap.c
- Mm.c
- Mode.c
- Pci.c
No functional change should be induced by this patch.
Signed-off-by: Pierre Gondois <[email protected]>
Commit: 42f1d004c070e60d05281f98afca56d897d395e9
https://github.com/tianocore/edk2/commit/42f1d004c070e60d05281f98afca56d897d395e9
Author: Pierre Gondois <[email protected]>
Date: 2026-08-04 (Tue, 04 Aug 2026)
Changed paths:
M ShellPkg/Library/UefiShellDebug1CommandsLib/SerMode.c
M ShellPkg/Library/UefiShellDebug1CommandsLib/SetSize.c
M ShellPkg/Library/UefiShellDebug1CommandsLib/SetVar.c
M ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/SmbiosView.c
Log Message:
-----------
ShellPkg/UefiShellDebug1: Lower indentation level in MainCmdXXX() (4/4)
This patch aims to help breaking down the long functions present in
the ShellPkg and reduce complexity/nested code and conditions.
Lower the indentation level in the newly created MainCmdXXX()
functions.
To avoid having one large commit updating all the UefiShellDebug1
commands, only update these files:
- SerMode.c
- SetSize.c
- SetVar.c
- SmbiosView/SmbiosView.c
No functional change should be induced by this patch.
Signed-off-by: Pierre Gondois <[email protected]>
Commit: ba2f2169863df9a5012eb2882cfe2822a49955e4
https://github.com/tianocore/edk2/commit/ba2f2169863df9a5012eb2882cfe2822a49955e4
Author: Pierre Gondois <[email protected]>
Date: 2026-08-04 (Tue, 04 Aug 2026)
Changed paths:
M ShellPkg/Library/UefiShellDebug1CommandsLib/Pci.c
Log Message:
-----------
ShellPkg/Pci: Extract PciEnumerateAll()
Extract the default PCI enumeration path into a helper.
No functional change.
Signed-off-by: Pierre Gondois <[email protected]>
Commit: c089090278236fdd84404b9ec233835aa0accc96
https://github.com/tianocore/edk2/commit/c089090278236fdd84404b9ec233835aa0accc96
Author: Pierre Gondois <[email protected]>
Date: 2026-08-04 (Tue, 04 Aug 2026)
Changed paths:
M ShellPkg/Library/UefiShellDebug1CommandsLib/Pci.c
Log Message:
-----------
ShellPkg/Pci: Extract ParsePciBdf()
Extract BDF argument parsing into a helper.
No functional change.
Signed-off-by: Pierre Gondois <[email protected]>
Commit: f260ae0375876d2d8683d7dab54071b1d980b15b
https://github.com/tianocore/edk2/commit/f260ae0375876d2d8683d7dab54071b1d980b15b
Author: Pierre Gondois <[email protected]>
Date: 2026-08-04 (Tue, 04 Aug 2026)
Changed paths:
M ShellPkg/Library/UefiShellDebug1CommandsLib/EfiCompress.c
Log Message:
-----------
ShellPkg/EfiCompress: Extract OpenFileHelper() and CompressFile()
Extract file opening and compression code into helpers.
Upon calling:
- gEfiShellProtocol->GetFileSize()
- gEfiShellProtocol->ReadFile()
the returned Status is now checked.
Upon calling AllocateZeroPool, the failed status is now set to
EFI_OUT_OF_RESOURCES.
Other than that, no functional change.
Signed-off-by: Pierre Gondois <[email protected]>
Commit: d9185d45c21ba5f385996b9d76309e2cc24cc2af
https://github.com/tianocore/edk2/commit/d9185d45c21ba5f385996b9d76309e2cc24cc2af
Author: Pierre Gondois <[email protected]>
Date: 2026-08-04 (Tue, 04 Aug 2026)
Changed paths:
M ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c
Log Message:
-----------
ShellPkg/Dmem: Refactor MainCmdDmem()
Refactor MainCmdDmem() to make it easier to understand.
Signed-off-by: Pierre Gondois <[email protected]>
Commit: 35a2f2754615bb3e029d3c86da09f8a32e5b14a1
https://github.com/tianocore/edk2/commit/35a2f2754615bb3e029d3c86da09f8a32e5b14a1
Author: Pierre Gondois <[email protected]>
Date: 2026-08-04 (Tue, 04 Aug 2026)
Changed paths:
M ShellPkg/Library/UefiShellDebug1CommandsLib/EfiDecompress.c
Log Message:
-----------
ShellPkg/EfiDecompress: Check presence of decompression protocol
Check the return value of LocateProtocol() before
using the decompression protocol. This avoids a
potential NULL pointer derefence spotted by codeql.
Signed-off-by: Pierre Gondois <[email protected]>
Commit: 383e680c3cf62b564783a5a26eae0b9ffd881b61
https://github.com/tianocore/edk2/commit/383e680c3cf62b564783a5a26eae0b9ffd881b61
Author: Pierre Gondois <[email protected]>
Date: 2026-08-04 (Tue, 04 Aug 2026)
Changed paths:
M ShellPkg/Library/UefiShellDebug1CommandsLib/Comp.c
Log Message:
-----------
ShellPkg/Comp: Extract helper functions
Refactor the Comp command and extract 2 functions:
- OpenFileOperand()
- CompareFiles()
This allows to simplify the logic of MainCmdComp() and
fix some codeql reported potential errors.
Signed-off-by: Pierre Gondois <[email protected]>
Commit: fa41c179db1f9fc21eb425f44b85a16262c806ca
https://github.com/tianocore/edk2/commit/fa41c179db1f9fc21eb425f44b85a16262c806ca
Author: Pierre Gondois <[email protected]>
Date: 2026-08-04 (Tue, 04 Aug 2026)
Changed paths:
M ShellPkg/Library/UefiShellDebug1CommandsLib/EfiDecompress.c
Log Message:
-----------
ShellPkg/EfiDecompress: Fix Codeql issues
Fix codeql reported issues by flattening MainCmdEfiDecompress(),
making it easier for the tool to evaluate potential risks.
Signed-off-by: Pierre Gondois <[email protected]>
Compare: https://github.com/tianocore/edk2/compare/f7052e2d029a...fa41c179db1f
To unsubscribe from these emails, change your notification settings at
https://github.com/tianocore/edk2/settings/notifications
_______________________________________________
edk2-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-commits
