On 07/22/15 17:46, Ard Biesheuvel wrote:
> This series implements 4 KB section alignment for ARM, which is required
> for supporting the Properties Table memory protection feature on this
> architecture.
> 
> This applies on top of the series 'BaseTools: unify all GCC linker scripts'
> that I sent out earlier today.

Okay, makes sense. For patch #4:

Acked-by: Laszlo Ersek <ler...@redhat.com>

Thanks
Laszlo

> 
> Note that I do not have access to RVCT to test the GenFw changes, so this
> may only be feasible on GCC, in which case the GenFw changes are going to
> be problematic as well. However, RVCT should support GNU ld style linker
> scripts these days, so hopefully it will just work ...
> 
> Patch #1 is a simple cleanup from the copy/paste that created Elf64Convert.c
> 
> Patch #2 changes the PE/COFF .data alignment to adhere to the global section
> and file alignment. Not doing so means the resulting binary violates the 
> PE/COFF
> spec, but the shift of .data may result in many relative relocations to be
> recomputed (which is presumably the reason why the alignment is omitted here)
> 
> Patch #3 switches to the new GCC linker scripts for ARM
> 
> Patch #4 selects the 4 KB alignment linker script to ensure .text and .data 
> can
> be represented by separate memory regions, allowing their permissions to be 
> set
> to R-X and RW- respectively.
> 
> Ard Biesheuvel (4):
>   BaseTools/GenFw: remove ARM and RVCT references from ELF64 code
>   BaseTools/GenFw: make ARM's .data adhere to PE/COFF section alignment
>   BaseTools/ARM: move to unified GCC linker script
>   ArmVirtPkg: use 4 KB section alignment for ARM DXE_RUNTIME modules
> 
>  ArmVirtPkg/ArmVirt.dsc.inc              |  3 ++-
>  BaseTools/Conf/tools_def.template       |  4 ++--
>  BaseTools/Source/C/GenFw/Elf32Convert.c | 20 +++++++++++++-------
>  BaseTools/Source/C/GenFw/Elf64Convert.c | 17 +----------------
>  4 files changed, 18 insertions(+), 26 deletions(-)
> 

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Reply via email to