On 07/16/15 23:28, Carsey, Jaben wrote: > Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
I'm rounding up patches for Jordan to queue up in the new (temporary) git repo. And, this patch looked like a candidate ready for merging. However, it doesn't apply. The reason is that Olivier submitted this patch on top of his [edk2] [PATCH 0/4] StdLib: Add ARM SoftFloat & AArch64 supports series -- hence the "StdLib/LibC/Softfloat/Softfloat.inf" lines in the context of this patch. That 4-part patch series is not ready for merging yet (it lacks reviews), and I'm not sure if without that patch series, it is valid to rework this patch, ie. drop the Softfloat context, and just add BaseStackCheckLib. So, I am *not* including this patch for now. It should be either reposted by an ARM expert without the softfloat context, or the softfloat dependency should be spelled out clearly in the commit message (or in a separate blurb). Thanks Laszlo > >> -----Original Message----- >> From: Olivier Martin [mailto:olivier.mar...@arm.com] >> Sent: Tuesday, July 14, 2015 9:26 AM >> To: Mcdaniel, Daryl >> Cc: edk2-de...@lists.sourceforge.net >> Subject: [edk2] [PATCH] StdLib: Added BaseStackLib for ARM architectures >> >> Stack protection support is required when building with ARM/AArch64 GCC. >> >> Contributed-under: TianoCore Contribution Agreement 1.0 >> Signed-off-by: Olivier Martin <olivier.mar...@arm.com> >> --- >> StdLib/StdLib.inc | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/StdLib/StdLib.inc b/StdLib/StdLib.inc >> index 51aeefa..7ee2e0a 100644 >> --- a/StdLib/StdLib.inc >> +++ b/StdLib/StdLib.inc >> @@ -74,10 +74,16 @@ >> NULL|ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf >> NULL|StdLib/LibC/Softfloat/Softfloat.inf >> >> + # Add support for GCC stack protector >> + NULL|MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf >> + >> [LibraryClasses.AARCH64] >> # Use the softfloat library to cover missing hardfloat operations. >> NULL|StdLib/LibC/Softfloat/Softfloat.inf >> >> + # Add support for GCC stack protector >> + NULL|MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf >> + >> [Components] >> # BaseLib and BaseMemoryLib need to be built with the /GL- switch when >> using the Microsoft >> # tool chain. This is required so that the library functions can be >> resolved >> during >> -- >> 2.1.1 >> >> >> ------------------------------------------------------------------------------ >> Don't Limit Your Business. Reach for the Cloud. >> GigeNET's Cloud Solutions provide you with the tools and support that >> you need to offload your IT needs and focus on growing your business. >> Configured For All Businesses. Start Your Cloud Today. >> https://www.gigenetcloud.com/ >> _______________________________________________ >> edk2-devel mailing list >> edk2-de...@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/edk2-devel > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel > _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
