On 2015-07-29 08:11:59, Ard Biesheuvel wrote: > Move to the parametrised generic GCC linker script and set 64 KB > alignment, instead of using the AARCH64 specific incremental linker > script for 64 KB alignment which is about to be removed. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> > --- > ArmPlatformPkg/ArmVExpressPkg/ArmVExpress.dsc.inc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress.dsc.inc > b/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress.dsc.inc > index 7e0d8ff4b6e6..d2f8f5aa6d41 100644 > --- a/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress.dsc.inc > +++ b/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress.dsc.inc > @@ -13,7 +13,7 @@ > # > > [BuildOptions.AARCH64.EDKII.DXE_RUNTIME_DRIVER] > - GCC:*_*_AARCH64_DLINK_FLAGS = > --script=$(EDK_TOOLS_PATH)/Scripts/gcc-aarch64-64K-align-ld-script > + GCC:*_*_AARCH64_DLINK_FLAGS = -z common-page-size=0x10000
Nice. This seems like a big improvement. common-page-size doesn't map exactly to 'image section alignment', so there is a little bit of a disconnect here in terminology. I think you said that something like --defsym=IMAGE_SECTION_ALIGN=0x10000 can't be used because it doesn't work in the linker script. Is that right? I guess if we added -z common-page-size=$(SECTIONALIGN_FLAGS) directly in build_rule, then we might be able to use: GCC:*_*_*_SECTIONALIGN_FLAGS = 0x10000 That's not great either. -Jordan > > [LibraryClasses.common] > !if $(TARGET) == RELEASE > -- > 1.9.1 > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
