Star, The NT32Pkg changes are good. Reviewed-by: Ruiyu Ni <ruiyu...@intel.com>
-----Original Message----- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Star Zeng Sent: Monday, August 17, 2015 4:24 PM To: edk2-devel@lists.01.org Subject: [edk2] [PATCH 00/15] Separate variable check service to library NOTICE: To keep git bisect, the update to platform package Nt32Pkg, OvmfPkg, EmulatorPkg, ArmVirtPkg, ArmPlatformPkg and Vlv2TbltDevicePkg has been split to two patches. For your easy review, the forked code is at g...@github.com:lzeng14/edk2.git branch VariableCheckService. What to do: 1. Add VarCheckLib library and VarCheckUefiLib NULL class library. 2. Update Variable driver to consume the separated VarCheckLib. 3. Update platform package to add VarCheckLib library mapping and link separated VarCheckUefiLib NULL class library Why to do: Share code. Separate variable check service from Variable driver in MdeModulePkg. We are going to separate generic software logic code from Variable Driver to benefit other variable driver implementation. Auth services has been done to be AuthVariableLib, now to cover variable check service. What test done: Nt32 and OVMF: Boot fine same with no code separation. Internal real platform: Boot fine to OS. What is the impact to platform: Only platform dsc need to be updated. Star Zeng (15): MdeModulePkg: Add VarCheckLib library MdeModulePkg: Add VarCheckUefiLib NULL class library Nt32Pkg: Add VarCheckLib library mapping OvmfPkg: Add VarCheckLib library mapping EmulatorPkg: Add VarCheckLib library mapping ArmVirtPkg: Add VarCheckLib library mapping ArmPlatformPkg: Add VarCheckLib library mapping Vlv2TbltDevicePkg: Add VarCheckLib library mapping MdeModulePkg Variable: Consume the separated VarCheckLib Nt32Pkg: Link separated VarCheckUefiLib NULL class library instance OvmfPkg: Link separated VarCheckUefiLib NULL class library instance EmulatorPkg: Link separated VarCheckUefiLib NULL class library instance ArmVirtPkg: Link separated VarCheckUefiLib NULL class library instance ArmPlatformPkg: Link separated VarCheckUefiLib NULL class library instance Vlv2TbltDevicePkg: Link separated VarCheckUefiLib NULL class library instance ArmPlatformPkg/ArmJunoPkg/ArmJuno.dsc | 5 +- .../ArmVExpressPkg/ArmVExpress-CTA15-A7.dsc | 5 +- .../ArmVExpressPkg/ArmVExpress-FVP-AArch64.dsc | 5 +- .../ArmVExpressPkg/ArmVExpress-RTSM-A15_MPCore.dsc | 5 +- ArmPlatformPkg/ArmVExpressPkg/ArmVExpress.dsc.inc | 1 + ArmVirtPkg/ArmVirt.dsc.inc | 1 + ArmVirtPkg/ArmVirtQemu.dsc | 5 +- EmulatorPkg/EmulatorPkg.dsc | 6 +- MdeModulePkg/Include/Library/VarCheckLib.h | 180 ++++ MdeModulePkg/Library/VarCheckLib/VarCheckLib.c | 632 +++++++++++ MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf | 51 + MdeModulePkg/Library/VarCheckLib/VarCheckLib.uni | Bin 0 -> 1798 bytes .../Library/VarCheckUefiLib/VarCheckUefiLib.inf | 88 ++ .../Library/VarCheckUefiLib/VarCheckUefiLib.uni | Bin 0 -> 2158 bytes .../VarCheckUefiLib/VarCheckUefiLibNullClass.c | 930 ++++++++++++++++ MdeModulePkg/MdeModulePkg.dec | 4 + MdeModulePkg/MdeModulePkg.dsc | 13 +- .../Universal/Variable/RuntimeDxe/VarCheck.c | 1117 +------------------- .../Universal/Variable/RuntimeDxe/Variable.c | 193 +--- .../Universal/Variable/RuntimeDxe/Variable.h | 97 +- .../Universal/Variable/RuntimeDxe/VariableDxe.c | 48 +- .../Variable/RuntimeDxe/VariableRuntimeDxe.inf | 15 +- .../Universal/Variable/RuntimeDxe/VariableSmm.c | 23 +- .../Universal/Variable/RuntimeDxe/VariableSmm.inf | 15 +- Nt32Pkg/Nt32Pkg.dsc | 6 +- OvmfPkg/OvmfPkgIa32.dsc | 6 +- OvmfPkg/OvmfPkgIa32X64.dsc | 6 +- OvmfPkg/OvmfPkgX64.dsc | 6 +- Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc | 2 + Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 2 + Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 2 + 31 files changed, 2045 insertions(+), 1424 deletions(-) create mode 100644 MdeModulePkg/Include/Library/VarCheckLib.h create mode 100644 MdeModulePkg/Library/VarCheckLib/VarCheckLib.c create mode 100644 MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf create mode 100644 MdeModulePkg/Library/VarCheckLib/VarCheckLib.uni create mode 100644 MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf create mode 100644 MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.uni create mode 100644 MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLibNullClass.c -- 1.9.5.msysgit.0 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
