1. Correct the return comments of entrypoint function. 2. Add parameters' comments for MeasureSmbiosTable(). 3. Correct the Protocols and Guids usage comments in SmbiosMeasurementDxe.inf.
Cc:Jiewen Yao <jiewen....@intel.com> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Star Zeng <star.z...@intel.com> Reviewed-by: Jiewen Yao <jiewen....@intel.com> --- .../Universal/SmbiosMeasurementDxe/SmbiosMeasurementDxe.c | 9 ++++++--- .../Universal/SmbiosMeasurementDxe/SmbiosMeasurementDxe.inf | 6 +++--- 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/MdeModulePkg/Universal/SmbiosMeasurementDxe/SmbiosMeasurementDxe.c b/MdeModulePkg/Universal/SmbiosMeasurementDxe/SmbiosMeasurementDxe.c index 9a73f29..5aafabf 100644 --- a/MdeModulePkg/Universal/SmbiosMeasurementDxe/SmbiosMeasurementDxe.c +++ b/MdeModulePkg/Universal/SmbiosMeasurementDxe/SmbiosMeasurementDxe.c @@ -432,7 +432,11 @@ FilterSmbiosTable ( } /** - Measure SMBIOS with EV_EFI_HANDOFF_TABLES to PCR[1] + Measure SMBIOS with EV_EFI_HANDOFF_TABLES to PCR[1]. + + @param[in] Event Event whose notification function is being invoked. + @param[in] Context Pointer to the notification function's context. + **/ VOID EFIAPI @@ -575,8 +579,7 @@ MeasureSmbiosTable ( @param ImageHandle Module's image handle @param SystemTable Pointer of EFI_SYSTEM_TABLE - @retval EFI_SUCCESS Smbios protocol installed - @retval Other No protocol installed, unload driver. + @return Status returned from EfiCreateEventReadyToBootEx(). **/ EFI_STATUS diff --git a/MdeModulePkg/Universal/SmbiosMeasurementDxe/SmbiosMeasurementDxe.inf b/MdeModulePkg/Universal/SmbiosMeasurementDxe/SmbiosMeasurementDxe.inf index 3193a6d..c5a779c 100644 --- a/MdeModulePkg/Universal/SmbiosMeasurementDxe/SmbiosMeasurementDxe.inf +++ b/MdeModulePkg/Universal/SmbiosMeasurementDxe/SmbiosMeasurementDxe.inf @@ -55,11 +55,11 @@ [LibraryClasses] TpmMeasurementLib [Protocols] - gEfiSmbiosProtocolGuid ## PRODUCES + gEfiSmbiosProtocolGuid ## CONSUMES [Guids] - gEfiSmbiosTableGuid ## SOMETIMES_PRODUCES ## SystemTable - gEfiSmbios3TableGuid ## SOMETIMES_PRODUCES ## SystemTable + gEfiSmbiosTableGuid ## SOMETIMES_CONSUMES ## SystemTable + gEfiSmbios3TableGuid ## SOMETIMES_CONSUMES ## SystemTable [Depex] gEfiSmbiosProtocolGuid -- 1.9.5.msysgit.0 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
