On 10/29/15 02:32, Jordan Justen wrote:
> Move from [PcdsFixedAtBuild, PcdsPatchableInModule] to
> [PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx].
>
> This will allow a platform to set this PCD dynamically if it knows how
> many logical processors the system has. The CpuDxe driver can then use
> this information during multiprocessor initialization to know that all
> of the application processors have started.
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Jordan Justen <jordan.l.jus...@intel.com>
> Cc: Jeff Fan <jeff....@intel.com>
> Cc: Laszlo Ersek <ler...@redhat.com>
> ---
> UefiCpuPkg/UefiCpuPkg.dec | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/UefiCpuPkg/UefiCpuPkg.dec b/UefiCpuPkg/UefiCpuPkg.dec
> index e783a7b..e16780e 100644
> --- a/UefiCpuPkg/UefiCpuPkg.dec
> +++ b/UefiCpuPkg/UefiCpuPkg.dec
> @@ -128,10 +128,6 @@
> # @Prompt Configure delay value after send an INIT IPI
>
> gUefiCpuPkgTokenSpaceGuid.PcdCpuInitIpiDelayInMicroSeconds|10000|UINT32|0x30000002
>
> - ## Specifies max supported number of Logical Processors.
> - # @Prompt Configure max supported number of Logical Processors
> -
> gUefiCpuPkgTokenSpaceGuid.PcdCpuMaxLogicalProcessorNumber|64|UINT32|0x00000002
> -
> ## This value specifies the Application Processor (AP) stack size, used
> for Mp Service, which must
> ## aligns the address on a 4-KByte boundary.
> # @Prompt Configure stack size for Application Processor (AP)
> @@ -178,6 +174,10 @@
> # @Prompt Microcode Region size.
>
> gUefiCpuPkgTokenSpaceGuid.PcdCpuMicrocodePatchRegionSize|0x0|UINT64|0x00000006
>
> + ## Specifies max supported number of Logical Processors.
> + # @Prompt Configure max supported number of Logical Processors
> +
> gUefiCpuPkgTokenSpaceGuid.PcdCpuMaxLogicalProcessorNumber|64|UINT32|0x00000002
> +
> [PcdsDynamic, PcdsDynamicEx]
> ## Contains the pointer to a CPU S3 data buffer of structure ACPI_CPU_DATA.
> # @Prompt The pointer to a CPU S3 data buffer.
>
Two requests, one about your development environment, and another about
the patch itself.
(1) Please append the following to your ".git/info/attributes" file:
----
*.dec diff=ini
*.dsc diff=ini
*.dsc.inc diff=ini
*.fdf diff=ini
*.fdf.inc diff=ini
*.inf diff=ini
----
Then please append the below to your ".git/config" file:
----
[diff "ini"]
xfuncname = "^\\[[A-Za-z0-9_., ]+]"
----
Please format this patch with those settings in place, and then compare
the result against *this* formatting. You'll understand my request then. :)
(2) Regarding the patch, please add a comment to the PCD (or extend its
@Prompt):
"If the execution environment contains more logical processors than this
value, then the behavior is undefined."
Thanks
Laszlo
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
