The OpenSSL function sk_X509_delete_ptr() resolves through preprocessor
substitution to '(X509 *)sk_delete_ptr()', in which the cast causes the
call to be interpreted as an expression (whose value is not used) rather
than a statement, resulting in the following error under Clang:

  ...: error: expression result unused [-Werror,-Wunused-value]

Add (VOID) casts to silence the error.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org>
---
 CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7Verify.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7Verify.c 
b/CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7Verify.c
index 242ba10bbf0e..6a84137632b7 100644
--- a/CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7Verify.c
+++ b/CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7Verify.c
@@ -541,7 +541,7 @@ Pkcs7GetCertificatesList (
       goto _Error;
     }
   }
-  sk_X509_delete_ptr (CertCtx.untrusted, Signer);
+  (VOID)sk_X509_delete_ptr (CertCtx.untrusted, Signer);
 
   //
   // Build certificates stack chained from Signer's certificate.
@@ -571,7 +571,7 @@ Pkcs7GetCertificatesList (
         if (!sk_X509_push (CertCtx.chain, Issuer)) {
           goto _Error;
         }
-        sk_X509_delete_ptr (CertCtx.untrusted, Issuer);
+        (VOID)sk_X509_delete_ptr (CertCtx.untrusted, Issuer);
 
         Cert = Issuer;
         continue;
-- 
1.9.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Reply via email to