On 11/17/15 12:07, Star Zeng wrote: > Generally, this patch series are to upstream SerialDxe from EmbeddedPkg to > MdeModulePkg, > relatively, they are also to upstream SerialPortExtLib.h from EmbeddedPkg to > SerialPortLib.h in MdePkg. > > For your easy review, the forked code is at g...@github.com:lzeng14/edk2.git > branch SerialDxeV2. > > * New in V2: > According the suggestion from Laszlo Ersek <ler...@redhat.com>, > zero *Control first in SerialPortGetControl() for > EmulatorPkg/Omap35xxPkg/OvmfPkg updates.
Please don't post a new version right after getting the initial comment(s) for the previous version -- it's usually prudent to give reviewers more time to review a posted version. In some exceptional cases the last version might be "completely broken", to the point where it makes no sense to continue (or even start) reviewing it. But in this specific case, the above change certainly doesn't warrant an immediate repost. I was still writing my second reply when you posted this version, so you simply couldn't have addressed *those* comments of mine in this version. Therefore I think I won't look at the series again before version 3. (And please give other reviewers more time so that v3 can also address their comments.) Thanks Laszlo > > Star Zeng (12): > MdePkg SerialPortLib: Upstream GetControl/SetControl/SetAttributes > interfaces > PcAtChipsetPkg SerialIoLib: Add GetControl/SetControl/SetAttributes > implementation > MdeModulePkg BaseSerialPortLib16550: Add > GetControl/SetControl/SetAttributes implementation > MdeModulePkg: Upstream SerialDxe from EmbeddedPkg > EmulatorPkg: Use SerialDxe in MdeModulePkg instead of EmbeddedPkg > CorebootPayloadPkg: Use SerialDxe in MdeModulePkg > Omap35xxPkg SerialPortLib: Add GetControl/SetControl/SetAttributes > implementation > BeagleBoardPkg: Use SerialDxe in MdeModulePkg instead of EmbeddedPkg > ArmPlatformPkg: Use SerialDxe in MdeModulePkg instead of EmbeddedPkg > OvmfPkg XenConsoleSerialPortLib: Add > GetControl/SetControl/SetAttributes implementation > ArmVirtPkg: Use SerialDxe in MdeModulePkg instead of EmbeddedPkg > EmbeddedPkg: Remove SerialDxe and SerialPortExtLib libraries > > ArmPlatformPkg/ArmJunoPkg/ArmJuno.dsc | 3 +- > ArmPlatformPkg/ArmJunoPkg/ArmJuno.fdf | 3 +- > .../ArmVExpressPkg/ArmVExpress-CTA15-A7.dsc | 3 +- > .../ArmVExpressPkg/ArmVExpress-CTA15-A7.fdf | 3 +- > .../ArmVExpressPkg/ArmVExpress-FVP-AArch64.dsc | 3 +- > .../ArmVExpressPkg/ArmVExpress-FVP-AArch64.fdf | 3 +- > .../ArmVExpressPkg/ArmVExpress-RTSM-A15_MPCore.dsc | 3 +- > .../ArmVExpressPkg/ArmVExpress-RTSM-A15_MPCore.fdf | 3 +- > ArmPlatformPkg/ArmVExpressPkg/ArmVExpress.dsc.inc | 1 - > .../PL011SerialPortLib/PL011SerialPortExtLib.c | 137 ------- > .../PL011SerialPortLib/PL011SerialPortExtLib.inf | 43 --- > .../PL011SerialPortLib/PL011SerialPortLib.c | 117 +++++- > ArmVirtPkg/ArmVirt.dsc.inc | 1 - > ArmVirtPkg/ArmVirtQemu.dsc | 2 +- > ArmVirtPkg/ArmVirtQemu.fdf | 2 +- > ArmVirtPkg/ArmVirtXen.dsc | 3 +- > ArmVirtPkg/ArmVirtXen.fdf | 3 +- > .../EarlyFdtPL011SerialPortLib.c | 82 ++++- > .../FdtPL011SerialPortLib/FdtPL011SerialPortLib.c | 99 ++++++ > BeagleBoardPkg/BeagleBoardPkg.dsc | 4 +- > BeagleBoardPkg/BeagleBoardPkg.fdf | 3 +- > CorebootPayloadPkg/CorebootPayloadPkg.fdf | 4 +- > CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc | 11 +- > CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc | 11 +- > .../Library/PlatformBdsLib/BdsPlatform.h | 5 +- > .../Library/PlatformHookLib/PlatformHookLib.c | 56 +++ > .../Library/PlatformHookLib/PlatformHookLib.inf | 38 ++ > .../Library/SerialPortLib/SerialPortLib.c | 316 ----------------- > .../Library/SerialPortLib/SerialPortLib.inf | 42 --- > CorebootPayloadPkg/SerialDxe/SerialDxe.inf | 55 --- > CorebootPayloadPkg/SerialDxe/SerialIo.c | 392 -------------------- > EmbeddedPkg/EmbeddedPkg.dsc | 6 +- > EmbeddedPkg/Include/Library/SerialPortExtLib.h | 116 ------ > .../SerialPortExtLibNull/SerialPortExtLibNull.c | 48 --- > .../SerialPortExtLibNull/SerialPortExtLibNull.inf | 30 -- > .../TemplateSerialPortExtLib.c | 79 ----- > .../TemplateSerialPortExtLib.inf | 36 -- > EmbeddedPkg/SerialDxe/SerialDxe.inf | 55 --- > EmbeddedPkg/SerialDxe/SerialIo.c | 391 -------------------- > EmulatorPkg/EmulatorPkg.dsc | 3 +- > EmulatorPkg/EmulatorPkg.fdf | 2 +- > .../DxeEmuSerialPortLib/DxeEmuSerialPortLib.c | 85 ++++- > .../BaseSerialPortLib16550.c | 341 ++++++++++++++++++ > MdeModulePkg/MdeModulePkg.dsc | 2 + > MdeModulePkg/Universal/SerialDxe/SerialDxe.inf | 48 +++ > MdeModulePkg/Universal/SerialDxe/SerialDxe.uni | Bin 0 -> 1892 bytes > .../Universal/SerialDxe/SerialDxeExtra.uni | Bin 0 -> 1324 bytes > MdeModulePkg/Universal/SerialDxe/SerialIo.c | 394 > +++++++++++++++++++++ > MdePkg/Include/Library/SerialPortLib.h | 76 +++- > .../BaseSerialPortLibNull/BaseSerialPortLibNull.c | 81 ++++- > Omap35xxPkg/Library/SerialPortLib/SerialPortLib.c | 84 +++++ > .../XenConsoleSerialPortLib.c | 89 +++++ > PcAtChipsetPkg/Library/SerialIoLib/SerialPortLib.c | 283 ++++++++++++++- > 53 files changed, 1917 insertions(+), 1783 deletions(-) > delete mode 100644 > ArmPlatformPkg/Library/PL011SerialPortLib/PL011SerialPortExtLib.c > delete mode 100644 > ArmPlatformPkg/Library/PL011SerialPortLib/PL011SerialPortExtLib.inf > create mode 100644 > CorebootPayloadPkg/Library/PlatformHookLib/PlatformHookLib.c > create mode 100644 > CorebootPayloadPkg/Library/PlatformHookLib/PlatformHookLib.inf > delete mode 100644 CorebootPayloadPkg/Library/SerialPortLib/SerialPortLib.c > delete mode 100644 CorebootPayloadPkg/Library/SerialPortLib/SerialPortLib.inf > delete mode 100644 CorebootPayloadPkg/SerialDxe/SerialDxe.inf > delete mode 100644 CorebootPayloadPkg/SerialDxe/SerialIo.c > delete mode 100644 EmbeddedPkg/Include/Library/SerialPortExtLib.h > delete mode 100644 > EmbeddedPkg/Library/SerialPortExtLibNull/SerialPortExtLibNull.c > delete mode 100644 > EmbeddedPkg/Library/SerialPortExtLibNull/SerialPortExtLibNull.inf > delete mode 100644 > EmbeddedPkg/Library/TemplateSerialPortExtLib/TemplateSerialPortExtLib.c > delete mode 100644 > EmbeddedPkg/Library/TemplateSerialPortExtLib/TemplateSerialPortExtLib.inf > delete mode 100644 EmbeddedPkg/SerialDxe/SerialDxe.inf > delete mode 100644 EmbeddedPkg/SerialDxe/SerialIo.c > create mode 100644 MdeModulePkg/Universal/SerialDxe/SerialDxe.inf > create mode 100644 MdeModulePkg/Universal/SerialDxe/SerialDxe.uni > create mode 100644 MdeModulePkg/Universal/SerialDxe/SerialDxeExtra.uni > create mode 100644 MdeModulePkg/Universal/SerialDxe/SerialIo.c > _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
