Thanks for your comments. I will update the code and send patches later. Thanks, Dandan
-----Original Message----- From: Gao, Liming Sent: Wednesday, November 18, 2015 5:11 PM To: Bi, Dandan; Dong, Eric; edk2-devel@lists.01.org Subject: RE: [patch 0/7]MdeModulePkg:UiApp remodeling task Dandan: I have some comments. 1) gEfiSetupEnterGuid is not required. Library constructor() can directly do the initialization. 2) gEfiIfrFrontPageGuid can be defined in Package.dec file, and can be referred in C and VFR file. 3) The separate library is NULL class Library instance. They need to be specified in UiApp.inf LibraryClass section in Platform DSC file. Please update MdeModulePkg.dsc and Nt32Pkg.dsc. Thanks Liming -----Original Message----- From: Bi, Dandan Sent: Wednesday, November 11, 2015 4:00 PM To: Dong, Eric; Gao, Liming; edk2-devel@lists.01.org Subject: [patch 0/7]MdeModulePkg:UiApp remodeling task Our current UiApp code is huge and hard to understand and maintain. So we split it to several independent libraries:device manager,boot manager, boot maintenance manager.Make the code clear and easy to maintain. Dandan Bi (7): MdeModulePkg:Create Boot Manager Library MdeModulePkg:Create Device Manager Library. MdeModulePkg:Create Boot Maintenance Manager Library. MdeModulePkg:Refine the UiApp MdeModulePkg/Include/Guid:Add Guid file MdeModulePkg: Modify to support new UiApp. Nt32Pk: To support new UiApp. MdeModulePkg/Application/UiApp/BootMaint/Bm.vfr | 360 ----- MdeModulePkg/Application/UiApp/BootMaint/BmLib.c | 369 ----- .../Application/UiApp/BootMaint/Bmstring.uni | Bin 42642 -> 0 bytes .../Application/UiApp/BootMaint/BootMaint.c | 1383 ----------------- .../Application/UiApp/BootMaint/BootMaint.h | 1567 -------------------- .../Application/UiApp/BootMaint/BootOption.c | 1467 ------------------ .../Application/UiApp/BootMaint/ConsoleOption.c | 1147 -------------- MdeModulePkg/Application/UiApp/BootMaint/Data.c | 289 ---- MdeModulePkg/Application/UiApp/BootMaint/FE.vfr | 131 -- .../Application/UiApp/BootMaint/FileExplorer.c | 449 ------ .../Application/UiApp/BootMaint/FormGuid.h | 223 --- .../Application/UiApp/BootMaint/UpdatePage.c | 1245 ---------------- .../Application/UiApp/BootMaint/Variable.c | 1074 -------------- .../Application/UiApp/BootMngr/BootManager.c | 399 ----- .../Application/UiApp/BootMngr/BootManager.h | 112 -- .../UiApp/BootMngr/BootManagerStrings.uni | Bin 3532 -> 0 bytes .../Application/UiApp/BootMngr/BootManagerVfr.Vfr | 50 - .../Application/UiApp/DeviceMngr/DeviceManager.c | 796 ---------- .../Application/UiApp/DeviceMngr/DeviceManager.h | 155 -- .../UiApp/DeviceMngr/DeviceManagerStrings.uni | Bin 7100 -> 0 bytes .../UiApp/DeviceMngr/DeviceManagerVfr.Vfr | 102 -- .../UiApp/DeviceMngr/DriverHealthVfr.Vfr | 45 - MdeModulePkg/Application/UiApp/FormsetGuid.h | 51 - MdeModulePkg/Application/UiApp/FrontPage.c | 439 +++--- MdeModulePkg/Application/UiApp/FrontPage.h | 58 +- .../Application/UiApp/FrontPageStrings.uni | Bin 11202 -> 8930 bytes MdeModulePkg/Application/UiApp/FrontPageVfr.Vfr | 55 +- MdeModulePkg/Application/UiApp/String.h | 12 - MdeModulePkg/Application/UiApp/Strings.uni | Bin 4716 -> 0 bytes MdeModulePkg/Application/UiApp/Ui.h | 47 +- MdeModulePkg/Application/UiApp/UiApp.inf | 82 +- MdeModulePkg/Application/UiApp/UiApp.uni | Bin 1616 -> 1520 bytes MdeModulePkg/Include/Guid/HiiFrontPageFormset.h | 26 + MdeModulePkg/Include/Guid/HiiSetupEnter.h | 26 + .../Library/BootMaintenanceManagerLib/BmLib.c | 89 ++ .../BootMaintenanceManagerLib/BootMaintenance.c | 1541 +++++++++++++++++++ .../BootMaintenanceManager.h | 1388 +++++++++++++++++ .../BootMaintenanceManager.vfr | 441 ++++++ .../BootMaintenanceManagerLib.inf | 100 ++ .../BootMaintenanceManagerStrings.uni | Bin 0 -> 43398 bytes .../Library/BootMaintenanceManagerLib/BootOption.c | 984 ++++++++++++ .../BootMaintenanceManagerLib/ConsoleOption.c | 1162 +++++++++++++++ .../Library/BootMaintenanceManagerLib/Data.c | 263 ++++ .../Library/BootMaintenanceManagerLib/FormGuid.h | 209 +++ .../Library/BootMaintenanceManagerLib/UpdatePage.c | 1272 ++++++++++++++++ .../Library/BootMaintenanceManagerLib/Variable.c | 1051 +++++++++++++ MdeModulePkg/Library/BootManagerLib/BootManager.c | 820 ++++++++++ MdeModulePkg/Library/BootManagerLib/BootManager.h | 171 +++ .../Library/BootManagerLib/BootManagerLib.inf | 68 + .../Library/BootManagerLib/BootManagerStrings.uni | Bin 0 -> 3880 bytes .../Library/BootManagerLib/BootManagerVfr.Vfr | 48 + .../Library/DeviceManagerLib/DeviceManager.c | 953 ++++++++++++ .../Library/DeviceManagerLib/DeviceManager.h | 195 +++ .../Library/DeviceManagerLib/DeviceManagerLib.inf | 58 + .../DeviceManagerLib/DeviceManagerStrings.uni | Bin 0 -> 7804 bytes .../Library/DeviceManagerLib/DeviceManagerVfr.Vfr | 67 + MdeModulePkg/MdeModulePkg.dec | 6 + MdeModulePkg/MdeModulePkg.dsc | 4 + Nt32Pkg/Nt32Pkg.dsc | 4 + 59 files changed, 11149 insertions(+), 11904 deletions(-) delete mode 100644 MdeModulePkg/Application/UiApp/BootMaint/Bm.vfr delete mode 100644 MdeModulePkg/Application/UiApp/BootMaint/BmLib.c delete mode 100644 MdeModulePkg/Application/UiApp/BootMaint/Bmstring.uni delete mode 100644 MdeModulePkg/Application/UiApp/BootMaint/BootMaint.c delete mode 100644 MdeModulePkg/Application/UiApp/BootMaint/BootMaint.h delete mode 100644 MdeModulePkg/Application/UiApp/BootMaint/BootOption.c delete mode 100644 MdeModulePkg/Application/UiApp/BootMaint/ConsoleOption.c delete mode 100644 MdeModulePkg/Application/UiApp/BootMaint/Data.c delete mode 100644 MdeModulePkg/Application/UiApp/BootMaint/FE.vfr delete mode 100644 MdeModulePkg/Application/UiApp/BootMaint/FileExplorer.c delete mode 100644 MdeModulePkg/Application/UiApp/BootMaint/FormGuid.h delete mode 100644 MdeModulePkg/Application/UiApp/BootMaint/UpdatePage.c delete mode 100644 MdeModulePkg/Application/UiApp/BootMaint/Variable.c delete mode 100644 MdeModulePkg/Application/UiApp/BootMngr/BootManager.c delete mode 100644 MdeModulePkg/Application/UiApp/BootMngr/BootManager.h delete mode 100644 MdeModulePkg/Application/UiApp/BootMngr/BootManagerStrings.uni delete mode 100644 MdeModulePkg/Application/UiApp/BootMngr/BootManagerVfr.Vfr delete mode 100644 MdeModulePkg/Application/UiApp/DeviceMngr/DeviceManager.c delete mode 100644 MdeModulePkg/Application/UiApp/DeviceMngr/DeviceManager.h delete mode 100644 MdeModulePkg/Application/UiApp/DeviceMngr/DeviceManagerStrings.uni delete mode 100644 MdeModulePkg/Application/UiApp/DeviceMngr/DeviceManagerVfr.Vfr delete mode 100644 MdeModulePkg/Application/UiApp/DeviceMngr/DriverHealthVfr.Vfr delete mode 100644 MdeModulePkg/Application/UiApp/FormsetGuid.h delete mode 100644 MdeModulePkg/Application/UiApp/Strings.uni create mode 100644 MdeModulePkg/Include/Guid/HiiFrontPageFormset.h create mode 100644 MdeModulePkg/Include/Guid/HiiSetupEnter.h create mode 100644 MdeModulePkg/Library/BootMaintenanceManagerLib/BmLib.c create mode 100644 MdeModulePkg/Library/BootMaintenanceManagerLib/BootMaintenance.c create mode 100644 MdeModulePkg/Library/BootMaintenanceManagerLib/BootMaintenanceManager.h create mode 100644 MdeModulePkg/Library/BootMaintenanceManagerLib/BootMaintenanceManager.vfr create mode 100644 MdeModulePkg/Library/BootMaintenanceManagerLib/BootMaintenanceManagerLib.inf create mode 100644 MdeModulePkg/Library/BootMaintenanceManagerLib/BootMaintenanceManagerStrings.uni create mode 100644 MdeModulePkg/Library/BootMaintenanceManagerLib/BootOption.c create mode 100644 MdeModulePkg/Library/BootMaintenanceManagerLib/ConsoleOption.c create mode 100644 MdeModulePkg/Library/BootMaintenanceManagerLib/Data.c create mode 100644 MdeModulePkg/Library/BootMaintenanceManagerLib/FormGuid.h create mode 100644 MdeModulePkg/Library/BootMaintenanceManagerLib/UpdatePage.c create mode 100644 MdeModulePkg/Library/BootMaintenanceManagerLib/Variable.c create mode 100644 MdeModulePkg/Library/BootManagerLib/BootManager.c create mode 100644 MdeModulePkg/Library/BootManagerLib/BootManager.h create mode 100644 MdeModulePkg/Library/BootManagerLib/BootManagerLib.inf create mode 100644 MdeModulePkg/Library/BootManagerLib/BootManagerStrings.uni create mode 100644 MdeModulePkg/Library/BootManagerLib/BootManagerVfr.Vfr create mode 100644 MdeModulePkg/Library/DeviceManagerLib/DeviceManager.c create mode 100644 MdeModulePkg/Library/DeviceManagerLib/DeviceManager.h create mode 100644 MdeModulePkg/Library/DeviceManagerLib/DeviceManagerLib.inf create mode 100644 MdeModulePkg/Library/DeviceManagerLib/DeviceManagerStrings.uni create mode 100644 MdeModulePkg/Library/DeviceManagerLib/DeviceManagerVfr.Vfr -- 1.9.5.msysgit.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
