Yes, I will. Thanks! -----Original Message----- From: Fan, Jeff Sent: Tuesday, November 24, 2015 11:35 AM To: Yao, Jiewen; [email protected] Cc: Kinney, Michael D Subject: RE: [patch] UefiCpuPkg/PiSmmCpu: Remove TSS fixup in GDT.
Jiewen, Could you combine this patch with [patch] UefiCpuPkg/PiSmmCpu: Eliminate EFI_IMAGE_MACHINE_TYPE_SUPPORTED(EFI_IMAGE_MACHINE_X64)? Reviewed-by: Jeff Fan <[email protected]> Jeff -----Original Message----- From: Yao, Jiewen Sent: Monday, November 23, 2015 10:15 PM To: [email protected] Cc: Yao, Jiewen; Fan, Jeff; Kinney, Michael D Subject: [patch] UefiCpuPkg/PiSmmCpu: Remove TSS fixup in GDT. The TSS is already fixed in PiSmmCpuDxeSmm/X64/SmmFuncsArch.c, InitGdt(). There is no need to fix it again. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Yao, Jiewen <[email protected]> Cc: Fan, Jeff <[email protected]> Cc: Kinney, Michael D <[email protected]> --- UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiEntry.S | 8 -------- UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiEntry.asm | 8 -------- 2 files changed, 16 deletions(-) diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiEntry.S b/UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiEntry.S index 8315593..95e6dfa 100644 --- a/UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiEntry.S +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiEntry.S @@ -128,14 +128,6 @@ ASM_PFX(gSmiCr3): .space 4 sgdt (%rsp) movl 2(%rsp), %eax # eax = GDT base addl $8, %esp - movl %eax, %edx - addl $GDT_SIZE, %edx - movb %dl, (TSS_SEGMENT + 2)(%rax) - movb %dh, (TSS_SEGMENT + 3)(%rax) - .byte 0xc1, 0xea, 0x10 # shr edx, 16 - movb %dl, (TSS_SEGMENT + 4)(%rax) - movb %dh, (TSS_SEGMENT + 7)(%rax) - movl %eax, %edx movb $0x89, %dl movb %dl, (TSS_SEGMENT + 5)(%rax) # clear busy flag movl $TSS_SEGMENT, %eax diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiEntry.asm b/UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiEntry.asm index c556bf5..4d53db5 100644 --- a/UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiEntry.asm +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiEntry.asm @@ -124,14 +124,6 @@ gSmiCr3 DD ? sgdt fword ptr [rsp] mov eax, [rsp + 2] ; eax = GDT base add esp, 8 - mov edx, eax - add edx, GDT_SIZE - mov [rax + TSS_SEGMENT + 2], dl - mov [rax + TSS_SEGMENT + 3], dh - DB 0c1h, 0eah, 10h ; shr edx, 16 - mov [rax + TSS_SEGMENT + 4], dl - mov [rax + TSS_SEGMENT + 7], dh - mov edx, eax mov dl, 89h mov [rax + TSS_SEGMENT + 5], dl ; clear busy flag mov eax, TSS_SEGMENT -- 1.9.5.msysgit.0 _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
