Star, The series looks good to me, and the feedback I have provided has been addressed.
Thanks, Mike > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Star > Zeng > Sent: Tuesday, November 24, 2015 5:34 PM > To: edk2-devel@lists.01.org > Subject: [edk2] [PATCH V4 00/13] Upstream SerialDxe from EmbeddedPkg to > MdeModulePkg > > Generally, this patch series are to upstream SerialDxe from EmbeddedPkg to > MdeModulePkg, > relatively, they are also to upstream SerialPortExtLib.h from EmbeddedPkg to > SerialPortLib.h in MdePkg. > > For your easy review, the forked code is at g...@github.com:lzeng14/edk2.git > branch SerialDxeV4. > > * New in V2: > According the suggestion from Laszlo Ersek <ler...@redhat.com>, > zero *Control first in SerialPortGetControl() for > EmulatorPkg/Omap35xxPkg/OvmfPkg updates. > > * New in V3: > Address the comments from Laszlo and Mike, > update commit log and FdtPL011SerialPortLib for ArmVirtPkg, > update the function header comment block for SerialPortSetAttributes() > and do some adjustment for SerialDxe in MdeModulePkg. > > * New in V4: > Include the patch suggested by Laszlo to fix a bug in TerminalConIn.c. > Address a comment from Mike to fix the mixed global variables and function > prototypes for SerialDxe. > > Star Zeng (13): > MdeModulePkg: TerminalDxe: avoid checking uninitialized variable > MdePkg SerialPortLib: Upstream Get(Set)Control/SetAttributes > interfaces > PcAtChipsetPkg SerialIoLib: Implement Get(Set)Control/SetAttributes > MdeModulePkg BaseSerialPortLib16550:Implement > Get(Set)Control/SetAttributes > MdeModulePkg: Upstream SerialDxe from EmbeddedPkg > EmulatorPkg: Use SerialDxe in MdeModulePkg instead of EmbeddedPkg > CorebootPayloadPkg: Use SerialDxe in MdeModulePkg > Omap35xxPkg SerialPortLib: Implement Get(Set)Control/SetAttributes > BeagleBoardPkg: Use SerialDxe in MdeModulePkg instead of EmbeddedPkg > ArmPlatformPkg: Use SerialDxe in MdeModulePkg instead of EmbeddedPkg > OvmfPkg XenConsoleSerialPortLib: Implement > Get(Set)Control/SetAttributes > ArmVirtPkg: Use SerialDxe in MdeModulePkg instead of EmbeddedPkg > EmbeddedPkg: Remove SerialDxe and SerialPortExtLib libraries > > ArmPlatformPkg/ArmJunoPkg/ArmJuno.dsc | 3 +- > ArmPlatformPkg/ArmJunoPkg/ArmJuno.fdf | 3 +- > .../ArmVExpressPkg/ArmVExpress-CTA15-A7.dsc | 3 +- > .../ArmVExpressPkg/ArmVExpress-CTA15-A7.fdf | 3 +- > .../ArmVExpressPkg/ArmVExpress-FVP-AArch64.dsc | 3 +- > .../ArmVExpressPkg/ArmVExpress-FVP-AArch64.fdf | 3 +- > .../ArmVExpressPkg/ArmVExpress-RTSM-A15_MPCore.dsc | 3 +- > .../ArmVExpressPkg/ArmVExpress-RTSM-A15_MPCore.fdf | 3 +- > ArmPlatformPkg/ArmVExpressPkg/ArmVExpress.dsc.inc | 1 - > .../PL011SerialPortLib/PL011SerialPortExtLib.c | 137 ------ > .../PL011SerialPortLib/PL011SerialPortExtLib.inf | 43 -- > .../PL011SerialPortLib/PL011SerialPortLib.c | 117 ++++- > ArmVirtPkg/ArmVirt.dsc.inc | 1 - > ArmVirtPkg/ArmVirtQemu.dsc | 2 +- > ArmVirtPkg/ArmVirtQemu.fdf | 2 +- > ArmVirtPkg/ArmVirtXen.dsc | 3 +- > ArmVirtPkg/ArmVirtXen.fdf | 3 +- > .../EarlyFdtPL011SerialPortLib.c | 88 +++- > .../FdtPL011SerialPortLib/FdtPL011SerialPortLib.c | 87 ++++ > BeagleBoardPkg/BeagleBoardPkg.dsc | 4 +- > BeagleBoardPkg/BeagleBoardPkg.fdf | 3 +- > CorebootPayloadPkg/CorebootPayloadPkg.fdf | 4 +- > CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc | 11 +- > CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc | 11 +- > .../Library/PlatformBdsLib/BdsPlatform.h | 5 +- > .../Library/PlatformHookLib/PlatformHookLib.c | 56 +++ > .../Library/PlatformHookLib/PlatformHookLib.inf | 38 ++ > .../Library/SerialPortLib/SerialPortLib.c | 316 ------------- > .../Library/SerialPortLib/SerialPortLib.inf | 42 -- > CorebootPayloadPkg/SerialDxe/SerialDxe.inf | 55 --- > CorebootPayloadPkg/SerialDxe/SerialIo.c | 392 --------------- > EmbeddedPkg/EmbeddedPkg.dsc | 6 +- > EmbeddedPkg/Include/Library/SerialPortExtLib.h | 116 ----- > .../SerialPortExtLibNull/SerialPortExtLibNull.c | 48 -- > .../SerialPortExtLibNull/SerialPortExtLibNull.inf | 30 -- > .../TemplateSerialPortExtLib.c | 79 ---- > .../TemplateSerialPortExtLib.inf | 36 -- > EmbeddedPkg/SerialDxe/SerialDxe.inf | 55 --- > EmbeddedPkg/SerialDxe/SerialIo.c | 391 --------------- > EmulatorPkg/EmulatorPkg.dsc | 3 +- > EmulatorPkg/EmulatorPkg.fdf | 2 +- > .../DxeEmuSerialPortLib/DxeEmuSerialPortLib.c | 91 +++- > .../BaseSerialPortLib16550.c | 347 ++++++++++++++ > MdeModulePkg/MdeModulePkg.dsc | 2 + > .../Universal/Console/TerminalDxe/TerminalConIn.c | 7 +- > MdeModulePkg/Universal/SerialDxe/SerialDxe.inf | 48 ++ > MdeModulePkg/Universal/SerialDxe/SerialDxe.uni | Bin 0 -> 1892 bytes > .../Universal/SerialDxe/SerialDxeExtra.uni | Bin 0 -> 1324 bytes > MdeModulePkg/Universal/SerialDxe/SerialIo.c | 524 > +++++++++++++++++++++ > MdePkg/Include/Library/SerialPortLib.h | 80 ++++ > .../BaseSerialPortLibNull/BaseSerialPortLibNull.c | 85 ++++ > Omap35xxPkg/Library/SerialPortLib/SerialPortLib.c | 90 ++++ > .../XenConsoleSerialPortLib.c | 95 ++++ > PcAtChipsetPkg/Library/SerialIoLib/SerialPortLib.c | 287 +++++++++++ > 54 files changed, 2084 insertions(+), 1783 deletions(-) > delete mode 100644 > ArmPlatformPkg/Library/PL011SerialPortLib/PL011SerialPortExtLib.c > delete mode 100644 > ArmPlatformPkg/Library/PL011SerialPortLib/PL011SerialPortExtLib.inf > create mode 100644 > CorebootPayloadPkg/Library/PlatformHookLib/PlatformHookLib.c > create mode 100644 > CorebootPayloadPkg/Library/PlatformHookLib/PlatformHookLib.inf > delete mode 100644 CorebootPayloadPkg/Library/SerialPortLib/SerialPortLib.c > delete mode 100644 CorebootPayloadPkg/Library/SerialPortLib/SerialPortLib.inf > delete mode 100644 CorebootPayloadPkg/SerialDxe/SerialDxe.inf > delete mode 100644 CorebootPayloadPkg/SerialDxe/SerialIo.c > delete mode 100644 EmbeddedPkg/Include/Library/SerialPortExtLib.h > delete mode 100644 > EmbeddedPkg/Library/SerialPortExtLibNull/SerialPortExtLibNull.c > delete mode 100644 > EmbeddedPkg/Library/SerialPortExtLibNull/SerialPortExtLibNull.inf > delete mode 100644 > EmbeddedPkg/Library/TemplateSerialPortExtLib/TemplateSerialPortExtLib.c > delete mode 100644 > EmbeddedPkg/Library/TemplateSerialPortExtLib/TemplateSerialPortExtLib.inf > delete mode 100644 EmbeddedPkg/SerialDxe/SerialDxe.inf > delete mode 100644 EmbeddedPkg/SerialDxe/SerialIo.c > create mode 100644 MdeModulePkg/Universal/SerialDxe/SerialDxe.inf > create mode 100644 MdeModulePkg/Universal/SerialDxe/SerialDxe.uni > create mode 100644 MdeModulePkg/Universal/SerialDxe/SerialDxeExtra.uni > create mode 100644 MdeModulePkg/Universal/SerialDxe/SerialIo.c > > -- > 1.9.5.msysgit.0 > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel