On 11/25/15 00:47, Michael Kinney wrote:
[snip]
> +//
> +// Data structure that is required for ACPI S3 resume. This structure must
> be
> +// allocated below 4GB from memory of type EfiACPIMemoryNVS. The PCD
> +// PcdCpuS3DataAddress must be set to the physical address where this
> structure
> +// is allocated
> +//
> typedef struct {
> + //
> + // Physical address of 4KB buffer allocated below 1MB from memory of type
> + // EfiReservedMemoryType. The buffer is not required to be initialized,
> but
> + // it is recommended that the buffer be zero-filled. This buffer used to
(1) "This buffer [is] used to"
> + // wake APs during an ACPI S3 resume.
> + //
> EFI_PHYSICAL_ADDRESS StartupVector;
With that change -- and there is no need to submit a v3 just because of
it; it can be fixed at commit time --
Reviewed-by: Laszlo Ersek <ler...@redhat.com>
The documentation looks great, many thanks for writing it up!
Laszlo
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
