On 11/25/15 18:59, Cohen, Eugene wrote:
> Addressing Ard and Laszlo's feedback.
>
> Updated subject. Moved initialization to separate line. Removed the
> typecast which was a carryover from a more strict convention we use in our
> private code.
>
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Eugene Cohen <eug...@hp.com>
> ---
> ArmPkg/Library/UncachedMemoryAllocationLib/UncachedMemoryAllocationLib.c | 1
> +
> 1 file changed, 1 insertion(+)
>
> diff --git
> a/ArmPkg/Library/UncachedMemoryAllocationLib/UncachedMemoryAllocationLib.c
> b/ArmPkg/Library/UncachedMemoryAllocationLib/UncachedMemoryAllocationLib.c
> index 1dfc740..f6c692f 100644
> --- a/ArmPkg/Library/UncachedMemoryAllocationLib/UncachedMemoryAllocationLib.c
> +++ b/ArmPkg/Library/UncachedMemoryAllocationLib/UncachedMemoryAllocationLib.c
> @@ -97,6 +97,7 @@ AllocatePagesFromList (
> //
> // Look in our list for the smallest page that could satisfy the new
> allocation
> //
> + Node = NULL;
> NewNode = NULL;
> for (Link = mPageList.ForwardLink; Link != &mPageList; Link =
> Link->ForwardLink) {
> Node = BASE_CR (Link, FREE_PAGE_NODE, Link);
>
Ard, if you and/or Leif are technically satisfied with this patch, I
think you should go ahead and commit it, fixing up any remaining warts
in the subject line and the commit message. Maintainers should be
helpful and educate re: git by example. (Not saying this because you
wouldn't do it otherwise! :))
/me ducks :)
Thanks!
Laszlo
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
