Yes, that is good suggestion. I will update comment section before check in.
-----Original Message----- From: Kinney, Michael D Sent: Thursday, November 26, 2015 1:50 AM To: Yao, Jiewen; edk2-de...@ml01.01.org; Kinney, Michael D Cc: Yao, Jiewen; Fan, Jeff Subject: RE: [edk2] [patch 2/3] UefiCpuPkg/PiSmmCpu: Add NULL func for 2 new APIs in SmmCpuFeaturesLib. Jiewen, I recommend SmmCpuFeaturesAllocatePageTableMemory () function header comment block be updated clarify that the API can be called more once to allocate memory for page tables. With that comment change: Reviewed-by: Michael Kinney <michael.d.kin...@intel.com> Mike > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > jiewen yao > Sent: Tuesday, November 24, 2015 5:05 PM > To: edk2-de...@ml01.01.org > Cc: Kinney, Michael D <michael.d.kin...@intel.com>; Yao, Jiewen > <jiewen....@intel.com>; Fan, Jeff <jeff....@intel.com> > Subject: [edk2] [patch 2/3] UefiCpuPkg/PiSmmCpu: Add NULL func for 2 new APIs > in SmmCpuFeaturesLib. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: "Yao, Jiewen" <jiewen....@intel.com> > Cc: "Fan, Jeff" <jeff....@intel.com> > Cc: "Kinney, Michael D" <michael.d.kin...@intel.com> > --- > .../Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c | 39 > ++++++++++++++++++++++ > 1 file changed, 39 insertions(+) > > diff --git a/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c > b/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c > index b839d31..d193f6c 100644 > --- a/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c > +++ b/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c > @@ -615,3 +615,42 @@ SmmCpuFeaturesWriteSaveStateRegister ( { > return EFI_UNSUPPORTED; > } > + > +/** > + This function is hook point called after the > +gEfiSmmReadyToLockProtocolGuid > + notification is completely processed. > +**/ > +VOID > +EFIAPI > +SmmCpuFeaturesCompleteSmmReadyToLock ( > + VOID > + ) > +{ > +} > + > +/** > + This API provides a method for a CPU to allocate a specific region for > storing page tables. > + > + Allocates the number of 4KB pages of type EfiRuntimeServicesData > + and returns a pointer to the allocated buffer. The buffer returned > + is aligned on a 4KB boundary. If Pages is 0, then NULL is > + returned. If there is not enough memory remaining to satisfy the request, > then NULL is returned. > + > + This function can also return NULL if there is no preference on where the > page tables are allocated in SMRAM. > + > + @param Pages The number of 4 KB pages to allocate. > + > + @return A pointer to the allocated buffer for page tables. > + @retval NULL Fail to allocate a specific region for storing page > tables, > + Or there is no preference on where the page tables are > allocated in SMRAM. > + > +**/ > +VOID * > +EFIAPI > +SmmCpuFeaturesAllocatePageTableMemory ( > + IN UINTN Pages > + ) > +{ > + return NULL; > +} > + > -- > 1.9.5.msysgit.0 > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
