On 2015/11/3 15:34, Zhang, Chao B wrote:
Enable Secure Boot feature defined in UEFI2.5 ECR1263. Add
gEfiSecureBootModeGuid definition

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Chao Zhang <chao.b.zh...@intel.com>
---
  SecurityPkg/Include/Guid/AuthenticatedVariableFormat.h | 1 +
  SecurityPkg/SecurityPkg.dec                            | 6 +++++-
  2 files changed, 6 insertions(+), 1 deletion(-)

The code change is good to me.
And please follow Laszlo's suggestion in [PATCH 0/5] to update the patch title.

If you follow the suggestion above, you can have my
Reviewed-by: Star Zeng <star.z...@intel.com>

Thanks,
Star


diff --git a/SecurityPkg/Include/Guid/AuthenticatedVariableFormat.h 
b/SecurityPkg/Include/Guid/AuthenticatedVariableFormat.h
index 1f007cf..dfd3f36 100644
--- a/SecurityPkg/Include/Guid/AuthenticatedVariableFormat.h
+++ b/SecurityPkg/Include/Guid/AuthenticatedVariableFormat.h
@@ -28,6 +28,7 @@ extern EFI_GUID gEfiSecureBootEnableDisableGuid;
  extern EFI_GUID gEfiCertDbGuid;
  extern EFI_GUID gEfiCustomModeEnableGuid;
  extern EFI_GUID gEfiVendorKeysNvGuid;
+extern EFI_GUID gEfiSecureBootModeGuid;

  ///
  /// "SecureBootEnable" variable for the Secure Boot feature enable/disable.
diff --git a/SecurityPkg/SecurityPkg.dec b/SecurityPkg/SecurityPkg.dec
index 959acf0..f768161 100644
--- a/SecurityPkg/SecurityPkg.dec
+++ b/SecurityPkg/SecurityPkg.dec
@@ -109,7 +109,11 @@
    ## GUID used to "certdb" variable to store the signer's certificates for 
common variables with EFI_VARIABLE_TIME_BASED_AUTHENTICATED_WRITE_ACCESS attribute.
    #  Include/Guid/AuthenticatedVariableFormat.h
    gEfiCertDbGuid                     = { 0xd9bee56e, 0x75dc, 0x49d9, { 0xb4, 
0xd7, 0xb5, 0x34, 0x21, 0xf, 0x63, 0x7a } }
-
+
+  ## GUID used to "SecureBootMode" variable to save platform secure boot mode
+  #  Include/Guid/AuthenticatedVariableFormat.h
+  gEfiSecureBootModeGuid             = { 0xc573b77, 0xeb93, 0x4d3d, { 0xaf, 
0xfc, 0x5f, 0xeb, 0xca, 0xfb, 0x65, 0xb0 } }
+
    ## Hob GUID used to pass a TCG_PCR_EVENT from a TPM PEIM to a TPM DXE 
Driver.
    #  Include/Guid/TcgEventHob.h
    gTcgEventEntryHobGuid              = { 0x2b9ffb52, 0x1b13, 0x416f, { 0xa8, 
0x7b, 0xbc, 0x93, 0xd, 0xef, 0x92, 0xa8 }}


_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Reply via email to