Ard: It is good to me. Reviewed-by: Chao Zhang <chao.b.zh...@intel.com>
Thanks & Best regards Chao Zhang -----Original Message----- From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] Sent: Thursday, December 03, 2015 4:38 PM To: edk2-devel@lists.01.org; Zhang, Chao B Cc: Gao, Liming Subject: Re: [PATCH 3/5] SecurityPkg: put missing empty lines at the end of some header files On 2 December 2015 at 18:02, Ard Biesheuvel <ard.biesheu...@linaro.org> wrote: > Some compilers (like RVCT) reject input files that do not end in a > newline. So add missing newlines to some SecurityPkg header files. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> Hello Chao, Do you have any comments on this patch? Thanks, Ard. > --- > SecurityPkg/Library/DxeImageVerificationLib/DxeImageVerificationLib.h > | 2 +- > SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfigImpl.h > | 2 +- > > SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfig > NvData.h | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git > a/SecurityPkg/Library/DxeImageVerificationLib/DxeImageVerificationLib. > h > b/SecurityPkg/Library/DxeImageVerificationLib/DxeImageVerificationLib. > h index b09ef8afd3e1..cff6076368b5 100644 > --- > a/SecurityPkg/Library/DxeImageVerificationLib/DxeImageVerificationLib. > h > +++ b/SecurityPkg/Library/DxeImageVerificationLib/DxeImageVerification > +++ Lib.h > @@ -204,4 +204,4 @@ typedef struct { > HASH_FINAL HashFinal; > } HASH_TABLE; > > -#endif > \ No newline at end of file > +#endif > diff --git > a/SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConf > igImpl.h > b/SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConf > igImpl.h index 228f44bde814..bcb1c12e2314 100644 > --- > a/SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConf > igImpl.h > +++ b/SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBoot > +++ ConfigImpl.h > @@ -621,4 +621,4 @@ GuidToString ( > IN UINTN BufferSize > ); > > -#endif > \ No newline at end of file > +#endif > diff --git > a/SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConf > igNvData.h > b/SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConf > igNvData.h index b628bcb1f532..7aebc1f99e85 100644 > --- > a/SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConf > igNvData.h > +++ b/SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBoot > +++ ConfigNvData.h > @@ -133,4 +133,4 @@ typedef struct { > EFI_HII_TIME RevocationTime; // The revocation time of the > certificate } SECUREBOOT_CONFIGURATION; > > -#endif > \ No newline at end of file > +#endif > -- > 1.9.1 > _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
