Yes. Thanks for the reminder. -----Original Message----- From: Zeng, Star Sent: Monday, December 14, 2015 9:38 AM To: Yao, Jiewen; edk2-devel@lists.01.org Subject: Re: [edk2] [patch] MdeModulePkg: add clarification for PcdAcpiDefault value PCD.
On 2015/12/14 8:59, Zeng, Star wrote: > On 2015/12/11 9:41, jiewen yao wrote: >> Add clarification for PcdAcpiDefaultOemTableId, >> PcdAcpiDefaultOemRevision, PcdAcpiDefaultCreatorId, >> PcdAcpiDefaultCreatorRevision. >> According to ACPI spec, they are used as special meaning for SSDT, so >> we ignore them in updating generic SSDT provided by EDKII. >> >> Contributed-under: TianoCore Contribution Agreement 1.0 >> Signed-off-by: "Yao, Jiewen" <jiewen....@intel.com> >> Cc: "Zeng, Star" <star.z...@intel.com>com> >> --- >> MdeModulePkg/MdeModulePkg.dec | 14 ++++++++++++++ >> 1 file changed, 14 insertions(+) > > Reviewed-by: Star Zeng <star.z...@intel.com> Forgot one thing, please remember to also update the uni files. Thanks, Star > >> >> diff --git a/MdeModulePkg/MdeModulePkg.dec >> b/MdeModulePkg/MdeModulePkg.dec index 5ec37c5..e2e0b75 100644 >> --- a/MdeModulePkg/MdeModulePkg.dec >> +++ b/MdeModulePkg/MdeModulePkg.dec >> @@ -1408,18 +1408,32 @@ >> gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiDefaultOemId|"INTEL >> "|VOID*|0x30001034 >> >> ## Default OEM Table ID for ACPI table creation, it is "EDK2 ". >> + # Accroding to ACPI specification, this field is particularly >> useful when >> + # defining a definition block to distinguish definition block >> functions. >> + # The OEM assigns each dissimilar table a new OEM Table ID. >> + # This PCD is ignored for definition block. >> # @Prompt Default OEM Table ID for ACPI table creation. >> >> gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiDefaultOemTableId|0x20202020324 >> B4445|UINT64|0x30001035 >> >> >> ## Default OEM Revision for ACPI table creation. >> + # Accroding to ACPI specification, for LoadTable() opcode, the OS >> can also >> + # check the OEM Table ID and Revision ID against a database for a >> newer >> + # revision Definition Block of the same OEM Table ID and load it >> instead. >> + # This PCD is ignored for definition block. >> # @Prompt Default OEM Revision for ACPI table creation. >> >> gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiDefaultOemRevision|0x00000002|U >> INT32|0x30001036 >> >> >> ## Default Creator ID for ACPI table creation. >> + # Accroding to ACPI specification, for tables containing >> Definition Blocks, >> + # this is the ID for the ASL Compiler. >> + # This PCD is ignored for definition block. >> # @Prompt Default Creator ID for ACPI table creation. >> >> gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiDefaultCreatorId|0x20202020|UIN >> T32|0x30001037 >> >> >> ## Default Creator Revision for ACPI table creation. >> + # Accroding to ACPI specification, for tables containing >> Definition Blocks, >> + # this is the revision for the ASL Compiler. >> + # This PCD is ignored for definition block. >> # @Prompt Default Creator Revision for ACPI table creation. >> >> gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiDefaultCreatorRevision|0x010000 >> 13|UINT32|0x30001038 >> >> >> _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
