Jaben, Using UEFI_APPLICATION for all Shell app and libraries allows the use of different compiler flags for the Shell application itself and also for any other applications that are built separately and that use Shell libraries.
It looks like the ShellPkg INFs use a mix of UEFI_APPLICATION and UEFI_DRIVER. Do you think they should all be cleaned up to be consistent, or left alone and this change discarded? Thanks, --Samer -----Original Message----- From: Carsey, Jaben [mailto:[email protected]] Sent: Monday, December 21, 2015 8:16 PM To: El-Haj-Mahmoud, Samer <[email protected]>; [email protected] Cc: Qiu, Shumin <[email protected]>; El-Haj-Mahmoud, Samer <[email protected]>; Carsey, Jaben <[email protected]> Subject: RE: [PATCH] ShellPkg : Change UefiShellInstall1CommandsLib.inf type to UEFI_APPLICATION What's the benefit of this change? It's not bad, but I don't know why its important... Jaben > -----Original Message----- > From: Samer El-Haj-Mahmoud [mailto:[email protected]] > Sent: Monday , December 21, 2015 4:29 PM > To: [email protected] > Cc: Qiu, Shumin <[email protected]>; Carsey, Jaben > <[email protected]>; Samer El-Haj-Mahmoud <samer.el-haj- > [email protected]>; Samer El-Haj-Mahmoud <[email protected]> > Subject: [PATCH] ShellPkg : Change UefiShellInstall1CommandsLib.inf > type to UEFI_APPLICATION > Importance: High > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Samer El-Haj-Mahmoud <[email protected]> > --- > .../UefiShellInstall1CommandsLib/UefiShellInstall1CommandsLib.inf | 3 > ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git > a/ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstall1Comma > ndsLi > b.inf > b/ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstall1Comma > ndsLi > b.inf > index dc1b622..b2644c2 100644 > --- > a/ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstall1Comma > ndsLi > b.inf > +++ b/ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstall1C > +++ om > +++ mandsLib.inf > @@ -2,6 +2,7 @@ > # Provides shell install1 functions > # > # Copyright (c) 2010 - 2015, Intel Corporation. All rights reserved. > <BR> > +# (C) Copyright 2015 Hewlett Packard Enterprise Development LP<BR> > # > # This program and the accompanying materials # are licensed and > made available under the terms and conditions of the BSD License @@ > -16,7 +17,7 @@ > INF_VERSION = 0x00010006 > BASE_NAME = UefiShellInstall1CommandsLib > FILE_GUID = D250E364-51C6-49ed-AEBF-6D83F5130F74 > - MODULE_TYPE = UEFI_DRIVER > + MODULE_TYPE = UEFI_APPLICATION > VERSION_STRING = 1.0 > LIBRARY_CLASS = NULL|UEFI_APPLICATION UEFI_DRIVER > CONSTRUCTOR = ShellInstall1CommandsLibConstructor > -- > 2.6.3.windows.1 _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
