On 2016/1/18 14:51, jiewen yao wrote:
Microsoft published secure MOR implementation at
https://msdn.microsoft.com/en-us/library/windows/hardware/mt270973(v=vs.85).aspx
with revision 2 update.
This series patches add MOR lock revision 2
to variable driver.
jiewen yao (3):
MdeModulePkg: Add MorLockSmm to variable driver.
MdeModulePkg: Add MorLockDxe to variable driver.
MdeModulePkg: Add MorLock to variable driver.
.../Universal/Variable/RuntimeDxe/TcgMorLockDxe.c | 89 +++++
.../Universal/Variable/RuntimeDxe/TcgMorLockSmm.c | 394 +++++++++++++++++++++
.../Universal/Variable/RuntimeDxe/Variable.c | 60 +++-
.../Variable/RuntimeDxe/VariableRuntimeDxe.inf | 6 +-
.../Universal/Variable/RuntimeDxe/VariableSmm.inf | 6 +-
5 files changed, 552 insertions(+), 3 deletions(-)
create mode 100644 MdeModulePkg/Universal/Variable/RuntimeDxe/TcgMorLockDxe.c
create mode 100644 MdeModulePkg/Universal/Variable/RuntimeDxe/TcgMorLockSmm.c
Reviewed-by: Star Zeng <[email protected]>
Only minor comments below
1. About the inf changes in [[patch V2 3/3].
+ gEfiMemoryOverwriteControlDataGuid ## PRODUCES ##
Variable:L"MemoryOverwriteRequestControl"
should be CONSUMES?
+ gEfiMemoryOverwriteRequestControlLockGuid ## CONSUMES ##
Variable:L"MemoryOverwriteRequestControlLock"
+
should be PRODUCES?
2. Should SecurityPkg\Tcg\MemoryOverwriteRequestControlLock be removed
or indicated to be deprecated or commented with more information to say
it only supports MOR lock revision 1?
Thanks,
Star
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.01.org/mailman/listinfo/edk2-devel
