Signal a closed event will still invoke the event notification function,
it could only be exposed when no the DEBUG_PROPERTY_CLEAR_MEMORY_ENABLED
bit set in PcdDebugPropertyMask.
For example:
gBS->CreateEvent (
EVT_NOTIFY_SIGNAL,
TPL_CALLBACK,
CallbackFun,
NULL,
&Event
);
gBS->CloseEvent (Event);
gBS->SignalEvent (Event); <- CallbackFun still be invoked
Although the case to signal a closed event is abnormal, the code could
still be enhanced to avoid it.
Cc: Liming Gao <liming....@intel.com>
Cc: Feng Tian <feng.t...@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng <star.z...@intel.com>
---
MdeModulePkg/Core/Dxe/Event/Event.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/MdeModulePkg/Core/Dxe/Event/Event.c
b/MdeModulePkg/Core/Dxe/Event/Event.c
index 34b34ac..9792430 100644
--- a/MdeModulePkg/Core/Dxe/Event/Event.c
+++ b/MdeModulePkg/Core/Dxe/Event/Event.c
@@ -769,6 +769,11 @@ CoreCloseEvent (
CoreUnregisterProtocolNotify (Event);
}
+ //
+ // To avoid the Event to be signalled wrongly after closed,
+ // clear the memory of Event before free pool.
+ //
+ ZeroMem (Event, sizeof (IEVENT));
Status = CoreFreePool (Event);
ASSERT_EFI_ERROR (Status);
--
2.7.0.windows.1
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
