Hello Jiewen, On 01/29/16 13:12, jiewen yao wrote: > This series patches add UEFI2.6 MemoryAttributesTable support. > This table is used to retire old PropertiesTable. > This is standalone table published by DxeCore, so there is no > compatibility issue. > > The patch is validated with or without properties table.
Do you mean, tested with PcdPropertiesTableEnable set to FALSE vs. TRUE? I skimmed the commit messages, and it looks like the properties table is preserved, but now it serves only as foundation for the memory attributes table. In OVMF we set PcdPropertiesTableEnable to FALSE by default, but flip it dynamically to TRUE in PlatformPei, if the user requests the feature on the QEMU command line. This is being done for avoiding regressions with OSes that don't know about the properties table, and its impact on the UEFI memmap. However, if the memory attributes table is safe for OSes that don't know about it, I think we can eliminate the above "FALSE" default, and dynamism, from OVMF, and just inherit the PcdPropertiesTableEnable=TRUE setting from "MdeModulePkg.dec". Does it sound reasonable to you? Thanks! Laszlo > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: "Yao, Jiewen" <jiewen....@intel.com> > Cc: "Gao, Liming" <liming....@intel.com> > > jiewen yao (7): > MdePkg: Add UEFI2.6 MemoryAttributes Table definition. > MdePkg: Add UEFI2.6 MemoryAttributesTable GUID > MdeModulePkg: Add MemoryAttributesTable generation. > MdeModulePkg: Update PropertiesTable for MemoryAttributesTable. > MdeModulePkg: Add CoreInitializeMemoryAttributesTable() to header > file. > MdePkg: Call CoreInitializeMemoryAttributesTable() in DXE Entrypoint. > MdePkg: Update DxeCore INF for MemoryAttributesTable. > > MdeModulePkg/Core/Dxe/DxeMain.h | 11 +- > MdeModulePkg/Core/Dxe/DxeMain.inf | 4 +- > MdeModulePkg/Core/Dxe/DxeMain/DxeMain.c | 3 +- > MdeModulePkg/Core/Dxe/Misc/MemoryAttributesTable.c | 214 > +++++++++++++++++++++ > MdeModulePkg/Core/Dxe/Misc/PropertiesTable.c | 100 +++++++++- > MdePkg/Include/Guid/MemoryAttributesTable.h | 34 ++++ > MdePkg/MdePkg.dec | 11 +- > 7 files changed, 362 insertions(+), 15 deletions(-) > create mode 100644 MdeModulePkg/Core/Dxe/Misc/MemoryAttributesTable.c > create mode 100644 MdePkg/Include/Guid/MemoryAttributesTable.h > _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
