Hi Laszlo, Thanks for your comments! I will pay attention to this, when check in code or send new patches, will add the space. And I will follow the request to send patches for review. Thank you very much.
Thanks, Dandan -----Original Message----- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo Ersek Sent: Tuesday, February 02, 2016 4:41 PM To: Bi, Dandan Cc: edk2-de...@ml01.01.org; Dong, Eric; Zhang, Chao B Subject: Re: [edk2] [patch 0/6] Use FileExplorerLib in SecureBootConfigDxe On 02/02/16 03:17, Dandan Bi wrote: > Using existing library FileExplorerLib to replace the same logic in > SecureBootConfigDxe.And add FileExplorerLib to dsc files of related > packages which use SecureBootConfigDxe. > > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Dandan Bi <dandan...@intel.com> > > Dandan Bi (6): > ArmPlatformPkg:Add FileExplorerLib.inf to the dsc file > ArmVirPkg:Add FileExplorerLib.inf to the dsc file > OvmfPkg:Add FileExplorerLib.inf to the dsc file > Vlv2TbltDevicePkg:Add FileExplorerLib.inf to the dsc file > SecurityPkg:Add FileExplorerLib.inf to the dsc file > SecurityPkg:Use FileExplorerLib in SecureBootConfigDxe > > .../ArmVExpressPkg/ArmVExpress-FVP-AArch64.dsc | 3 +- > ArmVirtPkg/ArmVirtQemu.dsc | 3 +- > OvmfPkg/OvmfPkgIa32.dsc | 3 +- > OvmfPkg/OvmfPkgIa32X64.dsc | 3 +- > OvmfPkg/OvmfPkgX64.dsc | 3 +- > SecurityPkg/SecurityPkg.dsc | 1 + > .../SecureBootConfigDxe/SecureBootConfig.vfr | 109 +- > .../SecureBootConfigDxe/SecureBootConfigDxe.inf | 3 +- > .../SecureBootConfigFileExplorer.c | 1127 > +++++++++++++++++--- > .../SecureBootConfigDxe/SecureBootConfigImpl.c | 167 ++- > .../SecureBootConfigDxe/SecureBootConfigImpl.h | 142 +-- > .../SecureBootConfigDxe/SecureBootConfigNvData.h | 10 + > Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc | 3 +- > Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 3 +- > Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 3 +- > 15 files changed, 1242 insertions(+), 341 deletions(-) > * A general comment for this series: please replace the ":" substring in each subject line with a ": " string. Example: OvmfPkg:Add FileExplorerLib.inf to the dsc file --> OvmfPkg: Add FileExplorerLib.inf to the dsc file ^ please add this space * Another request: for each patch, please look up the package maintainers from Maintainers.txt, and add those addresses to the commit messages, after your Signed-off-by, with "Cc:". For example, for patch 1: ... Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi <dandan...@intel.com> Cc: Leif Lindholm <leif.lindh...@linaro.org> Cc: Ard Biesheuvel <ard.biesheu...@linaro.org> Thanks! Laszlo _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
