On 2 February 2016 at 08:33, Ard Biesheuvel <ard.biesheu...@linaro.org> wrote:
> On 2 February 2016 at 09:20, Laszlo Ersek <ler...@redhat.com> wrote:
>> Ard, Leif, can you please review this?
>>
>> Thanks
>> Laszlo
>>
>> On 02/02/16 03:17, Dandan Bi wrote:
>>> Because SecureBootConfigDxe use FileExplorerLib now,but

FVP only includes SecureBootConfigDxe if SECURE_BOOT_ENABLE is TRUE.
So I think you should to add !if statements, as below:


>>> FileExplorerLib is not in the dsc file of the package
>>> which use SecureBootConfigDxe.Now add it to pass build.
>>>
>>> Contributed-under: TianoCore Contribution Agreement 1.0
>>> Signed-off-by: Dandan Bi <dandan...@intel.com>
>
> Reviewed-by: Ard Biesheuvel <ard.biesheu...@linaro.org>
>
>
>>> ---
>>>  ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-FVP-AArch64.dsc | 3 ++-
>>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-FVP-AArch64.dsc 
>>> b/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-FVP-AArch64.dsc
>>> index af46331..4837ca1 100644
>>> --- a/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-FVP-AArch64.dsc
>>> +++ b/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-FVP-AArch64.dsc
>>> @@ -1,8 +1,8 @@
>>>  #
>>>  #  Copyright (c) 2011-2015, ARM Limited. All rights reserved.
>>> -#  Copyright (c) 2015, Intel Corporation. All rights reserved.<BR>
>>> +#  Copyright (c) 2015-2016, Intel Corporation. All rights reserved.<BR>
>>>  #
>>>  #  This program and the accompanying materials
>>>  #  are licensed and made available under the terms and conditions of the 
>>> BSD License
>>>  #  which accompanies this distribution.  The full text of the license may 
>>> be found at
>>>  #  http://opensource.org/licenses/bsd-license.php
>>> @@ -47,10 +47,11 @@
>>>    TimerLib|ArmPkg/Library/ArmArchTimerLib/ArmArchTimerLib.inf
>>>
>>>    # Virtio Support
>>>    VirtioLib|OvmfPkg/Library/VirtioLib/VirtioLib.inf
>>>    
>>> VirtioMmioDeviceLib|OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDeviceLib.inf

!if $(SECURE_BOOT_ENABLE) == TRUE
>>> +  FileExplorerLib|MdeModulePkg/Library/FileExplorerLib/FileExplorerLib.inf
!endif

>>>
>>>  [LibraryClasses.common.SEC]
>>>    ArmLib|ArmPkg/Library/ArmLib/AArch64/AArch64LibSec.inf
>>>    
>>> ArmPlatformSecLib|ArmPlatformPkg/ArmVExpressPkg/Library/ArmVExpressSecLibRTSM/ArmVExpressSecLib.inf
>>>    
>>> ArmPlatformLib|ArmPlatformPkg/ArmVExpressPkg/Library/ArmVExpressLibRTSM/ArmVExpressLibSec.inf
>>>
>>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Reply via email to