On 02/18/16 09:14, Ni, Ruiyu wrote:
> Laszlo,
> " you could instead snarf the reporter's email address from the
> report, and CC him or her *directly on the patch*."
>
> Can you tell me how to get the reporter's email address from
> the report?
That's exactly the problem! It is not possible.
I wrote:
*if* github's issue tracker wasn't utterly broken,
[then] you could instead snarf the reporter's email address from the
report ...
I was speaking in conditional mood.
It cannot be helped at the moment; github's issue tracker is lame.
Sorry about the confusion -- I didn't mean to imply that you missed
anything. You didn't.
Thanks
Laszlo
>
> Regards,
> Ray
>
>
> -----Original Message-----
> From: Laszlo Ersek [mailto:[email protected]]
> Sent: Thursday, February 18, 2016 3:43 PM
> To: Ni, Ruiyu <[email protected]>; [email protected]
> Cc: Tian, Feng <[email protected]>
> Subject: Re: [edk2] [Patch] MdeModulePkg/Partition: Use proper partition
> number for MBR
>
> On 02/18/16 07:42, Ruiyu Ni wrote:
>> UEFI Spec 2.3.1.D Section 9.3.5.1 says Partitions are numbered
>> according to their entry in their respective partition table,
>> starting with 1.
>> Update the code for MBR partition to follow this rule.
>>
>> Contributed-under: TianoCore Contribution Agreement 1.0
>> Signed-off-by: Ruiyu Ni <[email protected]>
>> Cc: Feng Tian <[email protected]>
>> ---
>> MdeModulePkg/Universal/Disk/PartitionDxe/Mbr.c | 10 ++++------
>> 1 file changed, 4 insertions(+), 6 deletions(-)
>
> Can you please add the following line to the end of the commit message:
>
> Ref: https://github.com/tianocore/edk2/issues/50
>
> (no need to repost, can be done before pushing)
>
> Also, a general note: I think it's catastrophic that the email address
> of the bug reporter (on github) is not immediately available to us. I
> can see that you pasted the patch into the issue report as well. I agree
> this is a good goal, but if github's issue tracker wasn't utterly
> broken, you could instead snarf the reporter's email address from the
> report, and CC him or her *directly on the patch*.
>
> Then he or she could also respond with a Tested-by, if appropriate.
> (Well, not publicly, because the mailing list doesn't allow posting
> without subscription. Which is *also* broken, by the way.)
>
> Anyway, my point specifically for the patch is only the Ref: line.
>
> Thanks
> Laszlo
>
>
>> diff --git a/MdeModulePkg/Universal/Disk/PartitionDxe/Mbr.c
>> b/MdeModulePkg/Universal/Disk/PartitionDxe/Mbr.c
>> index 4b0159c..1946334 100644
>> --- a/MdeModulePkg/Universal/Disk/PartitionDxe/Mbr.c
>> +++ b/MdeModulePkg/Universal/Disk/PartitionDxe/Mbr.c
>> @@ -12,7 +12,7 @@
>> the legacy boot strap code.
>>
>> Copyright (c) 2014, Hewlett-Packard Development Company, L.P.<BR>
>> -Copyright (c) 2006 - 2013, Intel Corporation. All rights reserved.<BR>
>> +Copyright (c) 2006 - 2016, Intel Corporation. All rights reserved.<BR>
>> This program and the accompanying materials
>> are licensed and made available under the terms and conditions of the BSD
>> License
>> which accompanies this distribution. The full text of the license may be
>> found at
>> @@ -136,7 +136,6 @@ PartitionInstallMbrChildHandles (
>> HARDDRIVE_DEVICE_PATH HdDev;
>> HARDDRIVE_DEVICE_PATH ParentHdDev;
>> EFI_STATUS Found;
>> - UINT32 PartitionNumber;
>> EFI_DEVICE_PATH_PROTOCOL *DevicePathNode;
>> EFI_DEVICE_PATH_PROTOCOL *LastDevicePathNode;
>> UINT32 BlockSize;
>> @@ -192,8 +191,6 @@ PartitionInstallMbrChildHandles (
>> }
>> }
>>
>> - PartitionNumber = 1;
>> -
>> ZeroMem (&HdDev, sizeof (HdDev));
>> HdDev.Header.Type = MEDIA_DEVICE_PATH;
>> HdDev.Header.SubType = MEDIA_HARDDRIVE_DP;
>> @@ -223,7 +220,7 @@ PartitionInstallMbrChildHandles (
>> continue;
>> }
>>
>> - HdDev.PartitionNumber = PartitionNumber ++;
>> + HdDev.PartitionNumber = Index + 1;
>> HdDev.PartitionStart = UNPACK_UINT32
>> (Mbr->Partition[Index].StartingLBA);
>> HdDev.PartitionSize = UNPACK_UINT32
>> (Mbr->Partition[Index].SizeInLBA);
>> CopyMem (HdDev.Signature, &(Mbr->UniqueMbrSignature[0]), sizeof
>> (Mbr->UniqueMbrSignature));
>> @@ -252,6 +249,7 @@ PartitionInstallMbrChildHandles (
>> // It's an extended partition. Follow the extended partition
>> // chain to get all the logical drives
>> //
>> + Index = 0;
>> ExtMbrStartingLba = 0;
>>
>> do {
>> @@ -277,7 +275,7 @@ PartitionInstallMbrChildHandles (
>> ExtMbrStartingLba = UNPACK_UINT32 (Mbr->Partition[0].StartingLBA);
>> continue;
>> }
>> - HdDev.PartitionNumber = PartitionNumber ++;
>> + HdDev.PartitionNumber = ++Index;
>> HdDev.PartitionStart = UNPACK_UINT32 (Mbr->Partition[0].StartingLBA)
>> + ExtMbrStartingLba + ParentHdDev.PartitionStart;
>> HdDev.PartitionSize = UNPACK_UINT32 (Mbr->Partition[0].SizeInLBA);
>> if ((HdDev.PartitionStart + HdDev.PartitionSize - 1 >=
>> ParentHdDev.PartitionStart + ParentHdDev.PartitionSize) ||
>>
>
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.01.org/mailman/listinfo/edk2-devel
