Mike, One more comment. Please add the @param as blow in CheckFeatureSupported()'s function header.
@param[in,out] Buffer The pointer to private data buffer. Thanks! Jeff -----Original Message----- From: Fan, Jeff Sent: Friday, February 19, 2016 3:54 PM To: Michael Kinney; [email protected] Cc: Yao, Jiewen; Laszlo Ersek Subject: RE: [edk2] [Patch v2] UefiCpuPkg/PiSmmCpuDxeSmm: Add EFIAPI to CheckFeatureSupported() Reviewed-by: Jeff Fan <[email protected]> -----Original Message----- From: edk2-devel [mailto:[email protected]] On Behalf Of Michael Kinney Sent: Friday, February 19, 2016 9:54 AM To: [email protected] Cc: Yao, Jiewen; Laszlo Ersek; Fan, Jeff Subject: [edk2] [Patch v2] UefiCpuPkg/PiSmmCpuDxeSmm: Add EFIAPI to CheckFeatureSupported() The function CheckFeatureSupported() is used as an EFI_AP_PROCEDURE in the MP Services Protocol service StartAllAPs(). Any function used as an EFI_AP_PROCEDURE must use EFIAPI calling convention. Cc: Laszlo Ersek <[email protected]> Cc: Jeff Fan <[email protected]> Cc: Jiewen Yao <[email protected]> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Michael Kinney <[email protected]> --- UefiCpuPkg/PiSmmCpuDxeSmm/SmmProfile.c | 9 +++++---- UefiCpuPkg/PiSmmCpuDxeSmm/SmmProfile.h | 5 +++-- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/SmmProfile.c b/UefiCpuPkg/PiSmmCpuDxeSmm/SmmProfile.c index ec4ec9b..9c4f387 100644 --- a/UefiCpuPkg/PiSmmCpuDxeSmm/SmmProfile.c +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/SmmProfile.c @@ -1,7 +1,7 @@ /** @file Enable SMM profile. -Copyright (c) 2012 - 2015, Intel Corporation. All rights reserved.<BR> +Copyright (c) 2012 - 2016, Intel Corporation. All rights reserved.<BR> This program and the accompanying materials are licensed and made available under the terms and conditions of the BSD License which accompanies this distribution. The full text of the license may be found at @@ -930,8 +930,9 @@ InitSmmProfileInternal ( **/ VOID +EFIAPI CheckFeatureSupported ( - VOID + IN OUT VOID *Buffer ) { UINT32 RegEax; @@ -1001,7 +1002,7 @@ CheckProcessorFeature ( // // Check if XD and BTS are supported on all processors. // - CheckFeatureSupported (); + CheckFeatureSupported (NULL); // //Check on other processors if BSP supports this @@ -1009,7 +1010,7 @@ CheckProcessorFeature ( if (mXdSupported || mBtsSupported) { MpServices->StartupAllAPs ( MpServices, - (EFI_AP_PROCEDURE) CheckFeatureSupported, + CheckFeatureSupported, TRUE, NULL, 0, diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/SmmProfile.h b/UefiCpuPkg/PiSmmCpuDxeSmm/SmmProfile.h index 4548467..d65048e 100644 --- a/UefiCpuPkg/PiSmmCpuDxeSmm/SmmProfile.h +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/SmmProfile.h @@ -1,7 +1,7 @@ /** @file SMM profile header file. -Copyright (c) 2012 - 2015, Intel Corporation. All rights reserved.<BR> +Copyright (c) 2012 - 2016, Intel Corporation. All rights reserved.<BR> This program and the accompanying materials are licensed and made available under the terms and conditions of the BSD License which accompanies this distribution. The full text of the license may be found at @@ -97,8 +97,9 @@ PageFaultIdtHandlerSmmProfile ( **/ VOID +EFIAPI CheckFeatureSupported ( - VOID + IN OUT VOID *Buffer ); /** -- 2.6.3.windows.1 _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
